spi: clps711x: Enable driver compilation with COMPILE_TEST

PATCH Superseded Axel Lin 2 participants 5 messages Mar 26, 2014 3 messages not in the archive SPI

lore

Share & tools

lore

Axel Lin

author

2014-03-26 08:22 UTC #0 lore raw

PATCH 1/1 spi: clps711x: Enable driver compilation with COMPILE_TEST

This helps increasing build testing coverage.
This driver uses SYSCON APIs, so it needs to depend on MFD_SYSCON.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/spi/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/spi/Kconfig +2 -1

index 1ee6a54..78ca395 100644
@@ -150,7 +150,8 @@ config SPI_BUTTERFLY
 
 config SPI_CLPS711X
 	tristate "CLPS711X host SPI controller"
-	depends on ARCH_CLPS711X
+	depends on MFD_SYSCON
+	depends on ARCH_CLPS711X || COMPILE_TEST
 	help
 	  This enables dedicated general purpose SPI/Microwire1-compatible
 	  master mode interface (SSI1) for CLPS711X-based CPUs.

Signature · 8 lines

1.8.3.2



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

V2VkLCAyNiBNYXIgMjAxNCAxNjoyMjo1MCArMDgwMCDQvtGCIEF4ZWwgTGluIDxheGVsLmxpbkBp bmdpY3MuY29tPjoKPiBUaGlzIGhlbHBzIGluY3JlYXNpbmcgYnVpbGQgdGVzdGluZyBjb3ZlcmFn ZS4KPiBUaGlzIGRyaXZlciB1c2VzIFNZU0NPTiBBUElzLCBzbyBpdCBuZWVkcyB0byBkZXBlbmQg b24gTUZEX1NZU0NPTi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBeGVsIExpbiA8YXhlbC5saW5AaW5n aWNzLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9zcGkvS2NvbmZpZyB8IDMgKystCj4gIDEgZmlsZSBj aGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9zcGkvS2NvbmZpZyBiL2RyaXZlcnMvc3BpL0tjb25maWcKPiBpbmRleCAxZWU2YTU0 Li43OGNhMzk1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvc3BpL0tjb25maWcKPiArKysgYi9kcml2 ZXJzL3NwaS9LY29uZmlnCj4gQEAgLTE1MCw3ICsxNTAsOCBAQCBjb25maWcgU1BJX0JVVFRFUkZM WQo+ICAKPiAgY29uZmlnIFNQSV9DTFBTNzExWAo+ICAJdHJpc3RhdGUgIkNMUFM3MTFYIGhvc3Qg U1BJIGNvbnRyb2xsZXIiCj4gLQlkZXBlbmRzIG9uIEFSQ0hfQ0xQUzcxMVgKPiArCWRlcGVuZHMg b24gTUZEX1NZU0NPTgo+ICsJZGVwZW5kcyBvbiBBUkNIX0NMUFM3MTFYIHx8IENPTVBJTEVfVEVT VAo+ICAJaGVscAo+ICAJICBUaGlzIGVuYWJsZXMgZGVkaWNhdGVkIGdlbmVyYWwgcHVycG9zZSBT UEkvTWljcm93aXJlMS1jb21wYXRpYmxlCj4gIAkgIG1hc3RlciBtb2RlIGludGVyZmFjZSAoU1NJ MSkgZm9yIENMUFM3MTFYLWJhc2VkIENQVXMuCj4gLS0gCgpNRkRfU1lTQ09OIGlzIHNlbGVjdGVk IGJ5IEFSQ0hfQ0xQUzcxMVggYW5kIHRoaXMgc3ltYm9sIGlzCm5vdCBuZWVkZWQgZm9yIENPTVBJ TEVfVEVTVCwgc28gSSBhbSBkbyBub3QgYWdyZWUgd2l0aCB0aGlzIHBhdGNoLgoKLS0tCgo= --
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1395822666.112180924-lVoEP/[email protected]

Axel Lin

author

2014-03-26 08:34 UTC #3 lore raw

Quoted 3 lines

MFD_SYSCON is selected by ARCH_CLPS711X and this symbol is not needed for COMPILE_TEST, so I am do not agree with this patch.

COMPILE_TEST is purely for build test.
I have no problem to build this driver for x86 and some arm configs with this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): CAFRkauAS-q0+z1YKvbU=j==faK48WHgWdDmSnjjtcEnJWG8syA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

Alexander Shiyan

2014-03-26 08:36 UTC #5 lore raw

V2VkLCAyNiBNYXIgMjAxNCAxNjozNDo1MCArMDgwMCDQvtGCIEF4ZWwgTGluIDxheGVsLmxpbkBp bmdpY3MuY29tPjoKPiA+Cj4gPiBNRkRfU1lTQ09OIGlzIHNlbGVjdGVkIGJ5IEFSQ0hfQ0xQUzcx MVggYW5kIHRoaXMgc3ltYm9sIGlzCj4gPiBub3QgbmVlZGVkIGZvciBDT01QSUxFX1RFU1QsIHNv IEkgYW0gZG8gbm90IGFncmVlIHdpdGggdGhpcyBwYXRjaC4KPiAKPiBDT01QSUxFX1RFU1QgaXMg cHVyZWx5IGZvciBidWlsZCB0ZXN0Lgo+IEkgaGF2ZSBubyBwcm9ibGVtIHRvIGJ1aWxkIHRoaXMg ZHJpdmVyIGZvciB4ODYgYW5kIHNvbWUgYXJtIGNvbmZpZ3MKPiB3aXRoIHRoaXMgcGF0Y2guCgpZ ZXMuIGJ1dCBkcml2ZXIgY2FuIGJlIGNvbXBpbGVkIHdpdGhvdXQgTUZEX1NZU0NPTiBpbiBzdWNo IGNhc2VzLgoKLS0tCgo=
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1395822990.6485242-lVoEP/[email protected]

Axel Lin

author

2014-03-26 08:53 UTC #7 lore raw

2014-03-26 16:36 GMT+08:00 Alexander Shiyan <shc_work-JGs/[email protected]>:

Quoted 10 lines

Wed, 26 Mar 2014 16:34:50 +0800 от Axel Lin <[email protected]>:
Quoted 7 lines
Quoted 3 lines
MFD_SYSCON is selected by ARCH_CLPS711X and this symbol is not needed for COMPILE_TEST, so I am do not agree with this patch.
COMPILE_TEST is purely for build test.
I have no problem to build this driver for x86 and some arm configs with this patch.
Yes. but driver can be compiled without MFD_SYSCON in such cases.

Ok. v2 is no the way.

Thanks,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html