ARM: shmobile: r8a7779: Remove unused clock constants
PATCH 1/1 ARM: shmobile: r8a7779: Remove unused clock constants
--- arch/arm/mach-shmobile/clock-r8a7779.c | 8 -------- 1 file changed, 8 deletions(-)
arch/arm/mach-shmobile/clock-r8a7779.c +0 -8
@@ -47,17 +47,9 @@#define MD (nr) BIT(nr) -#define FRQMR IOMEM(0xffc80014)#define MSTPCR0 IOMEM(0xffc80030)#define MSTPCR1 IOMEM(0xffc80034)#define MSTPCR3 IOMEM(0xffc8003c) -#define MSTPSR1 IOMEM(0xffc80044) -#define MSTPSR4 IOMEM(0xffc80048) -#define MSTPSR6 IOMEM(0xffc8004c) -#define MSTPCR4 IOMEM(0xffc80050) -#define MSTPCR5 IOMEM(0xffc80054) -#define MSTPCR6 IOMEM(0xffc80058) -#define MSTPCR7 IOMEM(0xffc80040)#define MODEMR 0xffcc0020
Signature · 1 line
1.8.4
PATCH 1/1 ARM: shmobile: r8a7779: Remove unused clock constants
Hi Simon,
Thank you for the patch.
Quoted 14 lines · On Wednesday 06 November 2013 15:48:43 Simon Horman wrote:
Signed-off-by Simon Horman <[email protected]>--- arch/arm/mach-shmobile/clock-r8a7779.c | 8 -------- 1 file changed, 8 deletions(-)(quoted diff) +0
-0
b/arch/arm/mach-shmobile/clock-r8a7779.cindex b7ce0e7..3083c70 100644arch/arm/mach-shmobile/clock-r8a7779.c +0
-1@@ -47,17 +47,9 @@#define MD (nr) BIT(nr) -#define FRQMR IOMEM(0xffc80014)
arch/arm/mach-shmobile/clock-r8a7779.c line 60
Quoted 10 lines
arch/arm/mach-shmobile/clock-r8a7779.c +0
-7#define MSTPCR0 IOMEM(0xffc80030)#define MSTPCR1 IOMEM(0xffc80034)#define MSTPCR3 IOMEM(0xffc8003c) -#define MSTPSR1 IOMEM(0xffc80044) -#define MSTPSR4 IOMEM(0xffc80048) -#define MSTPSR6 IOMEM(0xffc8004c) -#define MSTPCR4 IOMEM(0xffc80050) -#define MSTPCR5 IOMEM(0xffc80054) -#define MSTPCR6 IOMEM(0xffc80058) -#define MSTPCR7 IOMEM(0xffc80040)
It has been pointed out to me that the CPG requires waiting for clocks to be enabled on all R-Mobile and R-Car SoCs. I've send a patch series to implement this for r8a7790 ("[PATCH 0/2] ARM: shmobile: r8a7790: Wait for status on all MSTP clocks"). Should we expand that to the other SoCs as well ? In that case the constants would be needed.
Quoted 1 line
arch/arm/mach-shmobile/clock-r8a7779.c +0
-0#define MODEMR 0xffcc0020
Signature · 3 lines
Regards, Laurent Pinchart
PATCH 1/1 ARM: shmobile: r8a7779: Remove unused clock constants
Quoted 27 lines · Laurent Pinchart
Hi Simon,
Thank you for the patch.
Quoted 22 lines · On Wednesday 06 November 2013 15:48:43 Simon Horman wrote:
Signed-off-by Simon Horman <[email protected]>--- arch/arm/mach-shmobile/clock-r8a7779.c | 8 -------- 1 file changed, 8 deletions(-)(quoted diff) +0
-0
b/arch/arm/mach-shmobile/clock-r8a7779.cindex b7ce0e7..3083c70 100644arch/arm/mach-shmobile/clock-r8a7779.c +0
-6@@ -47,17 +47,9 @@#define MD (nr) BIT(nr) -#define FRQMR IOMEM(0xffc80014)#define MSTPCR0 IOMEM(0xffc80030)#define MSTPCR1 IOMEM(0xffc80034)#define MSTPCR3 IOMEM(0xffc8003c) -#define MSTPSR1 IOMEM(0xffc80044) -#define MSTPSR4 IOMEM(0xffc80048) -#define MSTPSR6 IOMEM(0xffc8004c) -#define MSTPCR4 IOMEM(0xffc80050) -#define MSTPCR5 IOMEM(0xffc80054)
Quoted 8 lines
arch/arm/mach-shmobile/clock-r8a7779.c line 60
Quoted 2 lines
arch/arm/mach-shmobile/clock-r8a7779.c +0
-2-#define MSTPCR6 IOMEM(0xffc80058) -#define MSTPCR7 IOMEM(0xffc80040)It has been pointed out to me that the CPG requires waiting for clocks to be enabled on all R-Mobile and R-Car SoCs. I've send a patch series to implement this for r8a7790 ("[PATCH 0/2] ARM: shmobile: r8a7790: Wait for status on all MSTP clocks"). Should we expand that to the other SoCs as well ? In that case the constants would be needed.
That is a good question.
I am unsure if waiting is only required for Gen2 R-Car SoCs or Gen1 as well. If it is requried for Gen1 then it would make sense to extend the coverage of your series to H1 (r8a7779).