Skip to contentSkip to conversation

cooker: Only change self.data if it exists

PATCH New Richard Purdie 1 participant 1 message Mar 28, 2014

lore
Share & tools
lore

Richard Purdie

author
#0 lore raw

PATCH 1/1 cooker: Only change self.data if it exists

With the change to more optimal default featureset behaviour, a race was exposed by hob where the code may try and change self.data before it exists. This change avoids that.

When the datastore is created, the cooker configuration is used so data tracking is correctly handled regardless.

Signed-off-by Richard Purdie <[email protected]>

---

bitbake/lib/bb/cooker.py +4 -2
index e81d887..5d3ac60 100644
@@ -207,11 +207,13 @@ class BBCooker:
 
     def enableDataTracking(self):
         self.configuration.tracking = True
-        self.data.enableTracking()
+        if hasattr(self, "data"):
+            self.data.enableTracking()
 
     def disableDataTracking(self):
         self.configuration.tracking = False
-        self.data.disableTracking()
+        if hasattr(self, "data"):
+            self.data.disableTracking()
 
     def modifyConfigurationVar(self, var, val, default_file, op):
         if op == "append":