pci: changed '...pci_bus* bus' to '...pci_bus *bus'
PATCH 1/1 pci: changed '...pci_bus* bus' to '...pci_bus *bus'
change made to resolve following checkpatch message:
drivers/pci/pci.c:109: ERROR: "foo* bar" should be "foo *bar"
--- drivers/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pci.c +1 -1
@@ -106,7 +106,7 @@ static bool pcie_ari_disabled;* Given a PCI bus, returns the highest PCI bus number present in the set * including the given PCI bus and its list of child PCI buses. */ -unsigned char pci_bus_max_busnr (struct pci_bus * bus) +unsigned char pci_bus_max_busnr (struct pci_bus *bus) {struct list_head *tmp;unsigned char max, n;
Signature · 1 line
1.9.1
Hello,
This is my first patch. I'm looking for feedback pertaining to my submission that way I can submit more patches correctly in the future. Any constructive feedback is welcome.
I have one question in particular regarding the 'Sign by' section in the git commit message. Am I suppose to add a 'Sign by' line for myself or is that for the core kernel team?
Thank you for time and feedback,
Ryan
Quoted 19 lines · Ryan Desfosses
change made to resolve following checkpatch message:
drivers/pci/pci.c:109: ERROR: "foo* bar" should be "foo *bar"--- drivers/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/pci.c +1
-1@@ -106,7 +106,7 @@ static bool pcie_ari_disabled;* Given a PCI bus, returns the highest PCI bus number present in the set * including the given PCI bus and its list of child PCI buses. */ -unsigned char pci_bus_max_busnr (struct pci_bus * bus) +unsigned char pci_bus_max_busnr (struct pci_bus *bus) {struct list_head *tmp;unsigned char max, n;
Quoted 5 lines · Ryan
Hello,
This is my first patch. I'm looking for feedback pertaining to my submission that way I can submit more patches correctly in the future. Any constructive feedback is welcome.
Documentation/SubmittingPatches is always a good source of good practices.
Quoted 4 lines
I have one question in particular regarding the 'Sign by' section in the git commit message. Am I suppose to add a 'Sign by' line for myself or is that for the core kernel team?
You can find Section 12 of the file mentioned above relevant. Signed-off-by is a way of telling others that you have the right to release the code that you are posting *and* (IMHO) will take responsability for the modifications you make (i.e. if someone will complain about things breaking up you will fix them).
Best regards,
Liviu
Quoted 30 lines
Thank you for time and feedback,
RyanQuoted 11 lines · Ryan Desfosses
change made to resolve following checkpatch message:
drivers/pci/pci.c:109: ERROR: "foo* bar" should be "foo *bar"--- drivers/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/pci.c +0
-0drivers/pci/pci.c static bool pcie_ari_disabled; · line 112
Quoted 8 lines
drivers/pci/pci.c +1
-1@@ -106,7 +106,7 @@ static bool pcie_ari_disabled;* Given a PCI bus, returns the highest PCI bus number present in the set * including the given PCI bus and its list of child PCI buses. */ -unsigned char pci_bus_max_busnr (struct pci_bus * bus) +unsigned char pci_bus_max_busnr (struct pci_bus *bus) {struct list_head *tmp;unsigned char max, n;--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 8 lines
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯