dt/bindings: add binding for ARM Versatile character LCD
Subsystems (2)
PATCH 1/2 dt/bindings: add binding for ARM Versatile character LCD
From: Rob Herring <[email protected]>
Add binding doc for Versatile platforms character LCD controller interface.
--- Documentation/devicetree/bindings/misc/arm-charlcd.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/arm-charlcd.txt
Documentation/devicetree/bindings/misc/arm-charlcd.txt new file +18 -0
@@ -0,0 +1,18 @@ +ARM Versatile Character LCD +----------------------------------------------------- +This binding defines the character LCD interface found on ARM Versatile AB +and PB reference platforms. + +Required properties: +- compatible : "arm,versatile-clcd" +- reg : Location and size of character LCD registers + +Optional properties: +- interrupts - single interrupt for character LCD. The character LCD can + operate in polled mode without an interrupt. + +Example: + lcd at 10008000 { + compatible = "arm,versatile-lcd"; + reg = <0x10008000 0x1000>; + };
Signature · 1 line
1.8.3.2
PATCH 2/2 misc: arm-charlcd: add DT probe support
From: Rob Herring <[email protected]>
Add the DT match table to enable DT based probe matching.
--- drivers/misc/arm-charlcd.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/misc/arm-charlcd.c +7 -0
@@ -11,6 +11,7 @@#include <linux/module.h> #include <linux/interrupt.h> #include <linux/platform_device.h> +#include <linux/of.h> #include <linux/completion.h> #include <linux/delay.h> #include <linux/io.h>
@@ -366,11 +367,17 @@ static const struct dev_pm_ops charlcd_pm_ops = { .resume = charlcd_resume, }; +static const struct of_device_id charlcd_match[] = { + { .compatible ="arm,versatile-lcd" , }, + {} +}; +static struct platform_driver charlcd_driver = { .driver = { .name =DRIVERNAME , .owner =THIS_MODULE , .pm = &charlcd_pm_ops, + .of_match_table =of_match_ptr (charlcd_match), }, .remove =__exit_p (charlcd_remove), };
Signature · 1 line
1.8.3.2
Quoted 30 lines · Rob Herring
From: Rob Herring <[email protected]>
Add binding doc for Versatile platforms character LCD controller interface.
Signed-off-by Rob Herring <[email protected]>Cc Pawel Moll <[email protected]>Cc Mark Rutland <[email protected]>Cc Ian Campbell <[email protected]>Cc Kumar Gala <[email protected]>--- Documentation/devicetree/bindings/misc/arm-charlcd.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/arm-charlcd.txtDocumentation/devicetree/bindings/misc/arm-charlcd.txt new file +6
-0@@ -0,0 +1,18 @@ +ARM Versatile Character LCD +----------------------------------------------------- +This binding defines the character LCD interface found on ARM Versatile AB +and PB reference platforms. + +Required properties:
Documentation/devicetree/bindings/misc/arm-charlcd.txt line 16
Quoted 10 lines
Documentation/devicetree/bindings/misc/arm-charlcd.txt new file +10
-0+- compatible : "arm,versatile-clcd" +- reg : Location and size of character LCD registers + +Optional properties: +- interrupts - single interrupt for character LCD. The character LCD can + operate in polled mode without an interrupt. + +Example: + lcd@10008000 { + compatible = "arm,versatile-lcd";
Should be "arm,versatile-clcd" here?
Dinh
Quoted 10 lines
Documentation/devicetree/bindings/misc/arm-charlcd.txt new file +2
-1+ reg = <0x10008000 0x1000>; + }; --1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 21 lines · Rob Herring
From: Rob Herring <[email protected]>
Add binding doc for Versatile platforms character LCD controller interface.
Signed-off-by Rob Herring <[email protected]>Cc Pawel Moll <[email protected]>Cc Mark Rutland <[email protected]>Cc Ian Campbell <[email protected]>Cc Kumar Gala <[email protected]>--- Documentation/devicetree/bindings/misc/arm-charlcd.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/arm-charlcd.txtDocumentation/devicetree/bindings/misc/arm-charlcd.txt new file +0
-0
Documentation/devicetree/bindings/misc/arm-charlcd.txt line 7
Quoted 7 lines
Documentation/devicetree/bindings/misc/arm-charlcd.txt new file +7
-0@@ -0,0 +1,18 @@ +ARM Versatile Character LCD +----------------------------------------------------- +This binding defines the character LCD interface found on ARM Versatile AB +and PB reference platforms. + +Required properties: +- compatible : "arm,versatile-clcd"
Should this be "arm,versatile-lcd"?
Dinh
Quoted 11 lines
Documentation/devicetree/bindings/misc/arm-charlcd.txt new file +11
-0+- reg : Location and size of character LCD registers + +Optional properties: +- interrupts - single interrupt for character LCD. The character LCD can + operate in polled mode without an interrupt. + +Example: + lcd at 10008000 { + compatible = "arm,versatile-lcd"; + reg = <0x10008000 0x1000>; + };
Quoted 16 lines · Dinh Nguyen
Quoted 15 lines · Rob Herring
From: Rob Herring <[email protected]>
Add binding doc for Versatile platforms character LCD controller interface.
Signed-off-by Rob Herring <[email protected]>Cc Pawel Moll <[email protected]>Cc Mark Rutland <[email protected]>Cc Ian Campbell <[email protected]>Cc Kumar Gala <[email protected]>--- Documentation/devicetree/bindings/misc/arm-charlcd.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/arm-charlcd.txt
Quoted 15 lines
Documentation/devicetree/bindings/misc/arm-charlcd.txt line 7
Quoted 13 lines
Documentation/devicetree/bindings/misc/arm-charlcd.txt new file +7
-0@@ -0,0 +1,18 @@ +ARM Versatile Character LCD +----------------------------------------------------- +This binding defines the character LCD interface found on ARM Versatile AB +and PB reference platforms. + +Required properties: +- compatible : "arm,versatile-clcd"Should this be "arm,versatile-lcd"?
Make up your mind. ;) -lcd is what is already used in the dts, but since there was no driver support it should be okay to change the dts. If we're changing, I think I'll change it to "arm,versatile-char-lcd". 'c' alone could just mean color.
Rob
Quoted 33 lines · Rob Herring
Quoted 16 lines · Dinh Nguyen
Quoted 15 lines · Rob Herring
From: Rob Herring <[email protected]>
Add binding doc for Versatile platforms character LCD controller interface.
Signed-off-by Rob Herring <[email protected]>Cc Pawel Moll <[email protected]>Cc Mark Rutland <[email protected]>Cc Ian Campbell <[email protected]>Cc Kumar Gala <[email protected]>--- Documentation/devicetree/bindings/misc/arm-charlcd.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/arm-charlcd.txtQuoted 15 lines
Documentation/devicetree/bindings/misc/arm-charlcd.txt line 7
Quoted 13 lines
Documentation/devicetree/bindings/misc/arm-charlcd.txt new file +7
-0@@ -0,0 +1,18 @@ +ARM Versatile Character LCD +----------------------------------------------------- +This binding defines the character LCD interface found on ARM Versatile AB +and PB reference platforms. + +Required properties: +- compatible : "arm,versatile-clcd"Should this be "arm,versatile-lcd"?
Quoted 4 lines
Make up your mind. ;) -lcd is what is already used in the dts, but since there was no driver support it should be okay to change the dts. If we're changing, I think I'll change it to "arm,versatile-char-lcd". 'c' alone could just mean color.
Sorry...what I meant was that in your patch, the examples was using "lcd", and here's its "clcd". Then your 2/2 patch is using "lcd".
Dinh
Quoted 2 lines
Rob