Skip to contentSkip to conversation

misc: add driver support for MAX8997 MUIC

PATCH 함명주 2 participants 2 messages Dec 16, 2011

lore
Share & tools
lore

함명주

author
#0 lore raw
Quoted 25 lines · Samuel Ortiz

Hi Arnd,

Quoted 23 lines · Arnd Bergmann
Quoted 8 lines · MyungJoo Ham
Quoted 6 lines · Arnd Bergmann

On Monday 12 December 2011, Samuel Ortiz wrote:
The part that is not clear to me is how this new driver fits in with the first fsa9480 driver and the currently discussed extcon subsystem, apparently all written by the same team at Samsung. Is this misc driver still useful when the extcon framework gets merged?

Quoted 8 lines

When extcom gets merged, this driver should be updated. It looks like allowing the interrupt handler to update extcon state would be enough. Bascially, this is all this driver is required for extcon to work. (and the prvious author of extcon--"extended" switch class at that time--was the author of this patch.)

Anyway, this patch has just told me that I'll need to add more sysfs entries for extcon to show the list of cable names and/or to show the status for each of them, soon or later.

I think it would be better not to merge this driver until the user interface in the extcon framework has been finalized. I don't mind the driver, but I want to prevent user interfaces from appearing in the kernel that we intend to change anyway.

Quoted 7 lines
Quoted 2 lines

How about dropping the driver from the mfd tree, and adding it into the extcon series for the next posting?

Sounds good to me, I'll drop it.

Cheers,
Samuel.

To wait for extcon get merged and keep the MAX8997-MUIC without any sysfs interfaces or extcon feature, the following patch has been submitted yesterday:

http://lkml.org/lkml/2011/12/15/123

[PATCH] misc: max8997-muic: remove sysfs attribute

Quoted 8 lines

The 'switch' sysfs attribute is used for
showing and setting the switch state of the device. However, setting it from the userspace focibly is not appropriate. And showing the state can be handled from
other places (e.g. external connector) in a unified manner. This patch removes the sysfs attribute.
Plus, uevent messages for interrupts are also removed.

Quoted 7 lines

The initial max8997-muic driver is merged at:
git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6.git for-next

We can send the patch (with extcon support) later anyway if it's going to be dropped for now.

And, this MAX8997-MUIC will be the example driver for extcon located at /drivers/extcon/.

Cheers! MyungJoo.�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay����,j�f"톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&x�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�

#1 lore raw
Quoted 4 lines · 함명주

We can send the patch (with extcon support) later anyway if it's going to be dropped for now.

And, this MAX8997-MUIC will be the example driver for extcon located at /drivers/extcon/.

Ok, sounds good.

Arnd