Skip to contentSkip to conversation

mfd: bcm590xx: Fix modalias prefix

PATCH Applied Axel Lin 2 participants 4 messages Mar 31, 2014 – Apr 15, 2014 Multifunction devices (MFD)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 mfd: bcm590xx: Fix modalias prefix

This is a i2c driver, so uses i2c prefix in modalias.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/mfd/bcm590xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/bcm590xx.c +1 -1
index e9a33c7..40c0dd3 100644
@@ -90,4 +90,4 @@ module_i2c_driver(bcm590xx_i2c_driver);
 MODULE_AUTHOR("Matt Porter <[email protected]>");
 MODULE_DESCRIPTION("BCM590xx multi-function driver");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("platform:bcm590xx");
+MODULE_ALIAS("i2c:bcm590xx");
Signature · 1 line
1.8.3.2
author
#1 lore raw

PATCH 2/2 mfd: bcm590xx: Add missing remove function

Add missing mfd_remove_devices() call in remove function.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/mfd/bcm590xx.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/mfd/bcm590xx.c +7 -0
index 40c0dd3..c986149 100644
@@ -64,6 +64,12 @@ static int bcm590xx_i2c_probe(struct i2c_client *i2c,
 	return ret;
 }
 
+static int bcm590xx_i2c_remove(struct i2c_client *i2c)
+{
+	mfd_remove_devices(&i2c->dev);
+	return 0;
+}
+
 static const struct of_device_id bcm590xx_of_match[] = {
 	{ .compatible = "brcm,bcm59056" },
 	{ }

@@ -83,6 +89,7 @@ static struct i2c_driver bcm590xx_i2c_driver = {
 		   .of_match_table = of_match_ptr(bcm590xx_of_match),
 	},
 	.probe = bcm590xx_i2c_probe,
+	.remove = bcm590xx_i2c_remove,
 	.id_table = bcm590xx_i2c_id,
 };
 module_i2c_driver(bcm590xx_i2c_driver);
Signature · 1 line
1.8.3.2
Applied
#2 lore raw

Re: [PATCH 2/2] mfd: bcm590xx: Add missing remove function

Quoted 6 lines

Add missing mfd_remove_devices() call in remove function.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/mfd/bcm590xx.c | 7 +++++++
 1 file changed, 7 insertions(+)

Applied, thanks.

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Applied
#3 lore raw
In reply to Axel Lin
Quoted 6 lines

This is a i2c driver, so uses i2c prefix in modalias.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/mfd/bcm590xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog