Skip to contentSkip to conversation

kernel-arch: Always use ld.bfd to link the kernel

PATCH In review Phil Blundell 3 participants 4 messages Apr 23, 2013 – Apr 1, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel-arch: Always use ld.bfd to link the kernel

The kernel's penchant for custom linker scripts means that it doesn't generally get on very well with gold. Make sure we are using the BFD linker here no matter what the distro default is set to.

---
 meta/classes/kernel-arch.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta/classes/kernel-arch.bbclass
index b3b71ba..4a140eb 100644

meta/classes/kernel-arch.bbclass +1 -1
@@ -53,6 +53,6 @@ TARGET_AR_KERNEL_ARCH ?= ""
 HOST_AR_KERNEL_ARCH ?= "${TARGET_AR_KERNEL_ARCH}"
 
 KERNEL_CC = "${CCACHE}${HOST_PREFIX}gcc ${HOST_CC_KERNEL_ARCH}"
-KERNEL_LD = "${CCACHE}${HOST_PREFIX}ld ${HOST_LD_KERNEL_ARCH}"
+KERNEL_LD = "${CCACHE}${HOST_PREFIX}ld.bfd ${HOST_LD_KERNEL_ARCH}"
 KERNEL_AR = "${CCACHE}${HOST_PREFIX}ar ${HOST_AR_KERNEL_ARCH}"
 
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 15 lines · Phil Blundell

The kernel's penchant for custom linker scripts means that it doesn't generally get on very well with gold. Make sure we are using the BFD linker here no matter what the distro default is set to.

---
 meta/classes/kernel-arch.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/kernel-arch.bbclass +0 -0
index b3b71ba..4a140eb 100644

meta/classes/kernel-arch.bbclass TARGET_AR_KERNEL_ARCH ?= "" · line 57

Quoted 6 lines
meta/classes/kernel-arch.bbclass +1 -1
@@ -53,6 +53,6 @@ TARGET_AR_KERNEL_ARCH ?= ""
 HOST_AR_KERNEL_ARCH ?= "${TARGET_AR_KERNEL_ARCH}"
 
 KERNEL_CC = "${CCACHE}${HOST_PREFIX}gcc ${HOST_CC_KERNEL_ARCH}"
-KERNEL_LD = "${CCACHE}${HOST_PREFIX}ld ${HOST_LD_KERNEL_ARCH}"
+KERNEL_LD = "${CCACHE}${HOST_PREFIX}ld.bfd ${HOST_LD_KERNEL_ARCH}"
 KERNEL_AR = "${CCACHE}${HOST_PREFIX}ar ${HOST_AR_KERNEL_ARCH}"

I know this is almost a year-old change.

The question I have is - what should one do when using an external toolchain that doesn't have ld.bfd provided? I know these days with gold vs. BFD linker, it's common to have ld.bfd, but there could be exceptions...

Should this assignment be conditional, so it's easier to override from local.conf or distro?

Signature · 1 line
Denys
#2 lore raw
Quoted 6 lines · Denys Dmytriyenko

meta/classes/kernel-arch.bbclass TARGET_AR_KERNEL_ARCH ?= "" · line 57

Quoted 3 lines
meta/classes/kernel-arch.bbclass +1 -1
-KERNEL_LD = "${CCACHE}${HOST_PREFIX}ld ${HOST_LD_KERNEL_ARCH}"
+KERNEL_LD = "${CCACHE}${HOST_PREFIX}ld.bfd ${HOST_LD_KERNEL_ARCH}"
 KERNEL_AR = "${CCACHE}${HOST_PREFIX}ar ${HOST_AR_KERNEL_ARCH}"

I know this is almost a year-old change.

Quoted 6 lines

The question I have is - what should one do when using an external toolchain that doesn't have ld.bfd provided? I know these days with gold vs. BFD linker, it's common to have ld.bfd, but there could be exceptions...

Should this assignment be conditional, so it's easier to override from local.conf or distro?

Can external toolchain create ld.bfd symlink ?

#3 lore raw
In reply to Denys Dmytriyenko
Quoted 7 lines · Denys Dmytriyenko

meta/classes/kernel-arch.bbclass TARGET_AR_KERNEL_ARCH ?= "" · line 57

Quoted 4 lines

KERNEL_CC = "${CCACHE}${HOST_PREFIX}gcc ${HOST_CC_KERNEL_ARCH}"

meta/classes/kernel-arch.bbclass +1 -1
-KERNEL_LD = "${CCACHE}${HOST_PREFIX}ld ${HOST_LD_KERNEL_ARCH}"
+KERNEL_LD = "${CCACHE}${HOST_PREFIX}ld.bfd ${HOST_LD_KERNEL_ARCH}"
 KERNEL_AR = "${CCACHE}${HOST_PREFIX}ar ${HOST_AR_KERNEL_ARCH}"

I know this is almost a year-old change.

Quoted 6 lines

The question I have is - what should one do when using an external toolchain that doesn't have ld.bfd provided? I know these days with gold vs. BFD linker, it's common to have ld.bfd, but there could be exceptions...

Should this assignment be conditional, so it's easier to override from local.conf or distro?

Making those assignments all be conditional doesn't sound like a totally unreasonable plan to me. (I think it would be a bad idea to make KERNEL_LD alone be conditional; if we change one then we should change all four.)

Alternatively I guess you could take the view that the external toolchain packaging ought to be providing an ld.bfd symlink if there isn't already one. There are other places in oe-core which mention ld.bfd (one of them is gcc-cross-initial, which probably wouldn't be an issue for external toolchains, but another is u-boot which might be) and fixing the problem in the external toolchain would avoid the need to find and fix every place that refers to ld.bfd. So I think this would be my preference.

p.