ASoC: cs42l52: Fix mask for REVID

PATCH Applied Axel Lin 3 participants 3 messages Apr 5, 2014 – Apr 7, 2014

Subsystems (3)

Sound ASoC Cirrus Logic audio codecs

lore

Share & tools

lore

Axel Lin

author

2014-04-05 16:58 UTC #0 lore raw

PATCH 1/1 ASoC: cs42l52: Fix mask for REVID

BIT[0:2] of register 01h is REVID, so the mask for REVID should be 0x7. Also updates the code to use CS42L52_CHIP_REV_MASK.

Signed-off-by Axel Lin <[email protected]>

---
 sound/soc/codecs/cs42l52.c | 2 +-
 sound/soc/codecs/cs42l52.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

sound/soc/codecs/cs42l52.c +1 -1

index f0ca6be..460d355 100644
@@ -1259,7 +1259,7 @@ static int cs42l52_i2c_probe(struct i2c_client *i2c_client,
 	}
 
 	dev_info(&i2c_client->dev, "Cirrus Logic CS42L52, Revision: %02X\n",
-			reg & 0xFF);
+		 reg & CS42L52_CHIP_REV_MASK);
 
 	/* Set Platform Data */
 	if (cs42l52->pdata.mica_diff_cfg)

sound/soc/codecs/cs42l52.h +1 -1

index 6fb8f00..ac445993 100644
@@ -37,7 +37,7 @@
 #define CS42L52_CHIP_REV_A0			0x00
 #define CS42L52_CHIP_REV_A1			0x01
 #define CS42L52_CHIP_REV_B0			0x02
-#define CS42L52_CHIP_REV_MASK			0x03
+#define CS42L52_CHIP_REV_MASK			0x07
 
 #define CS42L52_PWRCTL1				0x02
 #define CS42L52_PWRCTL1_PDN_ALL			0x9F

Signature · 1 line

1.8.3.2

Austin, Brian

Acked-by on v1 1/1

2014-04-05 16:52 UTC #1 lore raw

Quoted 9 lines · Axel Lin

BIT[0:2] of register 01h is REVID, so the mask for REVID should be 0x7. Also updates the code to use CS42L52_CHIP_REV_MASK.
Signed-off-by Axel Lin <[email protected]>
---

Acked-by Brian Austin <[email protected]>

Thanks

Mark Brown

maintainer Applied

2014-04-07 09:49 UTC #2 lore raw

In reply to Axel Lin

Quoted 2 lines · Axel Lin

BIT[0:2] of register 01h is REVID, so the mask for REVID should be 0x7. Also updates the code to use CS42L52_CHIP_REV_MASK.

Applied, thanks.