powerpc/opal: Add missing include
Subsystems (2)
PATCH 1/1 powerpc/opal: Add missing include
next-20140324 currently fails compiling celleb_defconfig with:
arch/powerpc/include/asm/opal.h:894:42: error: 'struct notifier_block' declared inside parameter list [-Werror] arch/powerpc/include/asm/opal.h:894:42: error: its scope is only this definition or declaration, which is probably not what you want [-Werror] arch/powerpc/include/asm/opal.h:896:14: error: 'struct notifier_block' declared inside parameter list [-Werror]
This is due to a missing include which is added here.
arch/powerpc/include/asm/opal.h +2 -0
@@ -177,6 +177,8 @@ extern int opal_enter_rtas(struct rtas_args *args,#ifndef __ASSEMBLY__ +#include <linux/notifier.h> +/* Other enums */ enum OpalVendorApiTokens { OPAL_START_VENDOR_API_RANGE = 1000, OPAL_END_VENDOR_API_RANGE = 1999
Quoted 7 lines · Michael Neuling
next-20140324 currently fails compiling
celleb_defconfigwith:
arch/powerpc/include/asm/opal.h:894:42: error: 'structnotifier_block' declared inside parameter list [-Werror]arch/powerpc/include/asm/opal.h:894:42: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]arch/powerpc/include/asm/opal.h:896:14: error: 'structnotifier_block' declared inside parameter list [-Werror]This is due to a missing include which is added here.
This build issue has now been in mainline since a few days.
Quoted 7 lines
Signed-off-by Michael Neuling <[email protected]>arch/powerpc/include/asm/opal.h +0
-0
arch/powerpc/include/asm/opal.h extern int opal_enter_rtas(struct rtas_args *args, · line 184
Quoted 8 lines
arch/powerpc/include/asm/opal.h +2
-0@@ -177,6 +177,8 @@ extern int opal_enter_rtas(struct rtas_args *args,#ifndef __ASSEMBLY__ +#include <linux/notifier.h> +/* Other enums */ enum OpalVendorApiTokens { OPAL_START_VENDOR_API_RANGE = 1000, OPAL_END_VENDOR_API_RANGE = 1999
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 10 lines · Geert Uytterhoeven
Quoted 7 lines · Michael Neuling
next-20140324 currently fails compiling
celleb_defconfigwith:
arch/powerpc/include/asm/opal.h:894:42: error: 'structnotifier_block' declared inside parameter list [-Werror]arch/powerpc/include/asm/opal.h:894:42: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]arch/powerpc/include/asm/opal.h:896:14: error: 'structnotifier_block' declared inside parameter list [-Werror]This is due to a missing include which is added here.
This build issue has now been in mainline since a few days.
It's in my tree, I will send the patch upstream in the next couple of days (having a medical procedure today).
Ben.
Quoted 26 lines
Quoted 7 lines
Signed-off-by Michael Neuling <[email protected]>arch/powerpc/include/asm/opal.h +0
-0arch/powerpc/include/asm/opal.h extern int opal_enter_rtas(struct rtas_args *args, · line 184
Quoted 8 lines
arch/powerpc/include/asm/opal.h +2
-0@@ -177,6 +177,8 @@ extern int opal_enter_rtas(struct rtas_args *args,#ifndef __ASSEMBLY__ +#include <linux/notifier.h> +/* Other enums */ enum OpalVendorApiTokens { OPAL_START_VENDOR_API_RANGE = 1000, OPAL_END_VENDOR_API_RANGE = 1999Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds