Skip to contentSkip to conversation

Staging:Line6:usbdefs.h parenthesis for Marcos

PATCH In review Paul McQuade 2 participants 2 messages Apr 8, 2014 – Apr 17, 2014 Staging

lore
Share & tools
lore

Paul McQuade

author
#0 lore raw

PATCH 1/1 Staging:Line6:usbdefs.h parenthesis for Marcos

ERROR: Macros with complex values should be enclosed in parenthesis

Signed-off-by Paul McQuade <[email protected]>
---
 drivers/staging/line6/usbdefs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/line6/usbdefs.h +1 -1
index 2d1cc47..48958b5 100644
@@ -40,7 +40,7 @@
 #define LINE6_DEVID_TONEPORT_UX2  0x4142
 #define LINE6_DEVID_VARIAX        0x534d
 
-#define LINE6_BIT(x) LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x
+#define LINE6_BIT(x) (LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x)
 
 enum {
 	LINE6_INDEX_BASSPODXT,
Signature · 1 line
1.8.3.2
maintainer
#1 lore raw
Quoted 12 lines · Paul McQuade

ERROR: Macros with complex values should be enclosed in parenthesis

Signed-off-by Paul McQuade <[email protected]>
---
 drivers/staging/line6/usbdefs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/line6/usbdefs.h +0 -0
index 2d1cc47..48958b5 100644

drivers/staging/line6/usbdefs.h line 43

Quoted 5 lines
drivers/staging/line6/usbdefs.h +1 -1
@@ -40,7 +40,7 @@
 #define LINE6_DEVID_TONEPORT_UX2  0x4142
 #define LINE6_DEVID_VARIAX        0x534d
 
-#define LINE6_BIT(x) LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x
+#define LINE6_BIT(x) (LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x)

I love this one, it gets people all the time who don't actually test their changes...

Hint, it breaks the build, which isn't nice at all. Please ALWAYS test build your kernel changes, don't break other people's build boxes...

greg k-h