mtd: spi-nor: EXPORT symbols which could be used by module drivers
Subsystems (2)
PATCH 1/1 mtd: spi-nor: EXPORT symbols which could be used by module drivers
Fix errors like this:
ERROR: "spi_nor_ids" [drivers/mtd/devices/m25p80.ko] undefined!
ERROR: "spi_nor_scan" [drivers/mtd/devices/m25p80.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2---
Based on l2-mtd.git:spinor
drivers/mtd/spi-nor/spi-nor.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/mtd/spi-nor/spi-nor.c +3 -0
@@ -584,6 +584,7 @@ const struct spi_device_id spi_nor_ids[] = { { "cat25128", CAT25_INFO(2048, 8, 64, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) }, { }, }; +EXPORT_SYMBOL (spi_nor_ids);static const struct spi_device_id *spi_nor_read_id (struct spi_nor *nor) {
@@ -1081,6 +1082,7 @@ int spi_nor_scan(struct spi_nor *nor, const struct spi_device_id *id, mtd->eraseregions[i].numblocks);return 0 ; } +EXPORT_SYMBOL (spi_nor_scan);const struct spi_device_id *spi_nor_match_id (char *name) {
@@ -1093,6 +1095,7 @@ const struct spi_device_id *spi_nor_match_id(char *name) }return NULL ; } +EXPORT_SYMBOL (spi_nor_match_id);MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Huang Shijie <[email protected]>" );
Signature · 1 line
1.8.3.2
Quoted 10 lines · Brian Norris
Fix errors like this:
ERROR: "spi_nor_ids" [drivers/mtd/devices/m25p80.ko] undefined! ERROR: "spi_nor_scan" [drivers/mtd/devices/m25p80.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2Signed-off-by Brian Norris <[email protected]>---
Based on l2-mtd.git:spinor
Applied to l2-mtd.git/spinor, to fix the build errors.
Brian
Quoted 6 lines · Brian Norris
Fix errors like this:
ERROR: "spi_nor_ids" [drivers/mtd/devices/m25p80.ko] undefined! ERROR: "spi_nor_scan" [drivers/mtd/devices/m25p80.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2
Why not EXPORT_SYMBOL_GPL ?
Best regards,
Marek Vasut
Quoted 9 lines · Marek Vasut
Quoted 6 lines · Brian Norris
Fix errors like this:
ERROR: "spi_nor_ids" [drivers/mtd/devices/m25p80.ko] undefined! ERROR: "spi_nor_scan" [drivers/mtd/devices/m25p80.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2Why not
EXPORT_SYMBOL_GPL?
_GPL probably makes more sense. Squashed this in and pushed to l2-mtd.git/spinor.
Thanks,
Brian
Quoted 8 lines · Brian Norris
Quoted 7 lines · Marek Vasut
Quoted 5 lines · Brian Norris
Fix errors like this:
ERROR: "spi_nor_ids" [drivers/mtd/devices/m25p80.ko] undefined! ERROR: "spi_nor_scan" [drivers/mtd/devices/m25p80.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2
Quoted 4 lines
Quoted 1 line
Why not
EXPORT_SYMBOL_GPL?
_GPLprobably makes more sense. Squashed this in and pushed to l2-mtd.git/spinor.
Thanks!
btw Brian, completely off-topic, but is there a special ML for SPI NOR stuff or is all of that going through linux-mtd ?
Best regards,
Marek Vasut
Quoted 2 lines · Marek Vasut
btw Brian, completely off-topic, but is there a special ML for SPI NOR stuff or is all of that going through linux-mtd ?
All on linux-mtd, AFAIK. Occasionally we'll CC linux-spi as well, since Mark Brown was interested in some of this (mostly to keep "SPI NOR" out of drivers/spi/, I think).
Brian
Quoted 7 lines · Brian Norris
Quoted 2 lines · Marek Vasut
btw Brian, completely off-topic, but is there a special ML for SPI NOR stuff or is all of that going through linux-mtd ?
All on linux-mtd, AFAIK. Occasionally we'll CC linux-spi as well, since Mark Brown was interested in some of this (mostly to keep "SPI NOR" out of
drivers/spi/, I think).
OK, this makes sense. Thanks!
Best regards,
Marek Vasut