ipc:sem.c #include <linux/uaccess.h>
PATCH 3/15 ipc:sem.c #include <linux/uaccess.h>
WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
--- ipc/sem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ipc/sem.c +1 -1
@@ -87,7 +87,7 @@#include <linux/nsproxy.h> #include <linux/ipc_namespace.h> -#include <asm/uaccess.h> +#include <linux/uaccess.h> #include "util.h" /* One semaphore structure for each semaphore in the system. */
Signature · 1 line
1.8.3.2
Quoted 1 line · Paul McQuade
WARNING: Use #include <
linux/uaccess.h> instead of <asm/uaccess.h>
Nit: the subject should be less code and more text, something like "do not include asm uaccess directly" or "replace <asm/uaccess.h> by <linux/uaccess.h>"
Curious, how are you seeing these warnings?
Also, while at it we should probably get rid of the rest in ipc/:
compat.c:#include <asm/uaccess.h>
compat_mq.c:#include <asm/uaccess.h>
msg.c:#include <asm/uaccess.h>
sem.c:#include <asm/uaccess.h>
shm.c:#include <asm/uaccess.h>
Quoted 9 lines · Davidlohr Bueso
Quoted 1 line · Paul McQuade
WARNING: Use #include <
linux/uaccess.h> instead of <asm/uaccess.h>Nit: the subject should be less code and more text, something like "do not include asm uaccess directly" or "replace <
asm/uaccess.h> by <linux/uaccess.h>"Curious, how are you seeing these warnings?
Quoted 7 lines
Also, while at it we should probably get rid of the rest in
ipc/:compat.c:#include <
asm/uaccess.h>
compat_mq.c:#include <asm/uaccess.h>
msg.c:#include <asm/uaccess.h>
sem.c:#include <asm/uaccess.h>
shm.c:#include <asm/uaccess.h>
*sigh* you did but didn't maintain the CCs. It would make a lot more sense to keep it in the same patch.