xfs: wrong error sign conversion during failed DIO writes
PATCH 1/1 xfs: wrong error sign conversion during failed DIO writes
From: Dave Chinner <[email protected]>
We negate the error value being returned from a generic function incorrectly. The code path that it is running in returned negative errors, so there is no need to negate it to get the correct error signs here.
This was uncovered by generic/019.
--- fs/xfs/xfs_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_file.c +1 -1
@@ -679,7 +679,7 @@ xfs_file_dio_aio_write( goto out;if (mapping->nrpages) { - ret = -filemap_write_and_wait_range (VFS_I (ip)->i_mapping, + ret =filemap_write_and_wait_range (VFS_I (ip)->i_mapping, pos,-1 );if (ret) goto out;
Signature · 6 lines
1.9.0 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 8 lines · Dave Chinner
From: Dave Chinner <[email protected]>
We negate the error value being returned from a generic function incorrectly. The code path that it is running in returned negative errors, so there is no need to negate it to get the correct error signs here.
This was uncovered by generic/019.
Looks good,
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs