ARM: dts: imx6sl-evk: Add an entry for MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 ARM: dts: imx6sl-evk: Add an entry for MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11
From: Fabio Estevam <[email protected]>
In case the bootloader has incorrectly configured the ALT mode of MX6SL_PAD_ECSPI1_SS0 pad, we end up with the following probe error:
m25p80 spi0.0: found mr25h256, expected m25p32
m25p80 spi0.0: mr25h256 (32 Kbytes)
In order to avoid this issue, add an entry for MX6SL_PAD_ECSPI1_SS0 pad, so that kernel configures the ECSPI chip select as GPIO functionality, which results in correct SPI NOR probe.
--- arch/arm/boot/dts/imx6sl-evk.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/imx6sl-evk.dts +1 -0
@@ -282,6 +282,7 @@ MX6SL_PAD_ECSPI1_MISO__ECSPI1_MISO 0x100b1 MX6SL_PAD_ECSPI1_MOSI__ECSPI1_MOSI 0x100b1 MX6SL_PAD_ECSPI1_SCLK__ECSPI1_SCLK 0x100b1 + MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11 0x80000000 >; };
Signature · 1 line
1.8.3.2
PATCH 1/1 ARM: dts: imx6sl-evk: Add an entry for MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11
Quoted 22 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
In case the bootloader has incorrectly configured the ALT mode of
MX6SL_PAD_ECSPI1_SS0pad, we end up with the following probe error:m25p80 spi0.0: found mr25h256, expected m25p32
m25p80 spi0.0: mr25h256 (32 Kbytes)In order to avoid this issue, add an entry for
MX6SL_PAD_ECSPI1_SS0pad, so that kernel configures the ECSPI chip select as GPIO functionality, which results in correct SPI NOR probe.Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/boot/dts/imx6sl-evk.dts | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/arch/arm/boot/dts/imx6sl-evk.dtsindex 864d8df..a8d9a93 100644
arch/arm/boot/dts/imx6sl-evk.dts line 285
Quoted 4 lines
arch/arm/boot/dts/imx6sl-evk.dts +1
-0@@ -282,6 +282,7 @@ MX6SL_PAD_ECSPI1_MISO__ECSPI1_MISO 0x100b1 MX6SL_PAD_ECSPI1_MOSI__ECSPI1_MOSI 0x100b1 MX6SL_PAD_ECSPI1_SCLK__ECSPI1_SCLK 0x100b1 + MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11
0x80000000
Doesn't 0x80000000 mean "do not configure this pin, leave it as it was configured before" ?
Best regards,
Marek Vasut
Fabio Estevam
reviewerPATCH 1/1 ARM: dts: imx6sl-evk: Add an entry for MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11
Quoted 11 lines · Marek Vasut
arch/arm/boot/dts/imx6sl-evk.dts line 285
Quoted 9 lines
(quoted diff) +0
-0
b/arch/arm/boot/dts/imx6sl-evk.dtsindex 864d8df..a8d9a93 100644arch/arm/boot/dts/imx6sl-evk.dts +1
-0@@ -282,6 +282,7 @@ MX6SL_PAD_ECSPI1_MISO__ECSPI1_MISO 0x100b1 MX6SL_PAD_ECSPI1_MOSI__ECSPI1_MOSI 0x100b1 MX6SL_PAD_ECSPI1_SCLK__ECSPI1_SCLK 0x100b1 + MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11
0x80000000
Quoted 2 lines
Doesn't
0x80000000mean "do not configure this pin, leave it as it was configured before" ?
For the PAD settings, yes, but here I am interested in setting the ALT mode to GPIO.
It is OK to leave the PAD settings as is for the GPIO.
Regards,
Fabio Estevam
Shawn Guo
AppliedPATCH 1/1 ARM: dts: imx6sl-evk: Add an entry for MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11
In reply to Fabio EstevamQuoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
In case the bootloader has incorrectly configured the ALT mode of
MX6SL_PAD_ECSPI1_SS0pad, we end up with the following probe error:
Quoted 8 lines
m25p80 spi0.0: found mr25h256, expected m25p32
m25p80 spi0.0: mr25h256 (32 Kbytes)In order to avoid this issue, add an entry for
MX6SL_PAD_ECSPI1_SS0pad, so that kernel configures the ECSPI chip select as GPIO functionality, which results in correct SPI NOR probe.Signed-off-by Fabio Estevam <[email protected]>
Applied, thanks.