Skip to contentSkip to conversation

perf list: Fix --raw-dump argument

PATCH New Ramkumar Ramachandra 1 participant 1 message Apr 11, 2014 perf events

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 perf list: Fix --raw-dump argument

While adding usage information, 44d742e (perf list: Add usage, 2013-10-30) broke

  $ perf list --raw-dump

Fix this by making raw-dump a subcommand. Also update the completion script and manpage.

Cc David Ahern <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/Documentation/perf-list.txt | 3 +++
 tools/perf/builtin-list.c              | 2 +-
 tools/perf/perf-completion.sh          | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)
tools/perf/Documentation/perf-list.txt +3 -0
index 6fce6a6..13fe4f4 100644
@@ -108,6 +108,9 @@ To limit the list use:
 
 . 'pmu' to print the kernel supplied PMU events.
 
+. 'raw-dump' to print out the names of all events. For internal use by
+  the completion script.
+
 . If none of the above is matched, it will apply the supplied glob to all
   events, printing the ones that match.
 
tools/perf/builtin-list.c +1 -1
index 011195e..c74aef5 100644
@@ -53,7 +53,7 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused)
 			print_hwcache_events(NULL, false);
 		else if (strcmp(argv[i], "pmu") == 0)
 			print_pmu_events(NULL, false);
-		else if (strcmp(argv[i], "--raw-dump") == 0)
+		else if (strcmp(argv[i], "raw-dump") == 0)
 			print_events(NULL, true);
 		else {
 			char *sep = strchr(argv[i], ':'), *s;
tools/perf/perf-completion.sh +1 -1
index ae3a576..8f518f0 100644
@@ -119,7 +119,7 @@ __perf_main ()
 		fi
 	# List possible events for -e option
 	elif [[ $prev == "-e" && "${words[1]}" == @(record|stat|top) ]]; then
-		evts=$($cmd list --raw-dump)
+		evts=$($cmd list raw-dump)
 		__perfcomp_colon "$evts" "$cur"
 	# List subcommands for 'perf kvm'
 	elif [[ $prev == "kvm" ]]; then
Signature · 1 line
1.9.2.667.ge5b74e1