bitbake-worker: Drop BBHASH variables

PATCH New Richard Purdie 1 participant 1 message Apr 13, 2014

Share & tools

Richard Purdie

author

2014-04-13 10:50 UTC #0 lore raw

PATCH 1/1 bitbake-worker: Drop BBHASH variables

Iterating through and calling setVar on this number of variables has significant overhead in the profiling data. By not setting this, we save 3,000 calls to setVar which gives a noticeable improvement to the speed of task execution.

The BBHASH variables have since been replaced by accessing that data through the siggen code and going forward, that is the preferred way work with it.

Signed-off-by Richard Purdie <[email protected]>

---

bitbake/bin/bitbake-worker +0 -4

index 68e2bf4..05e0cf6 100755
@@ -159,10 +159,6 @@ def fork_off_task(cfg, data, workerdata, fn, task, taskname, appends, taskdepdat
             try:
                 the_data = bb.cache.Cache.loadDataFull(fn, appends, data)
                 the_data.setVar('BB_TASKHASH', workerdata["runq_hash"][task])
-                for h in workerdata["hashes"]:
-                    the_data.setVar("BBHASH_%s" % h, workerdata["hashes"][h])
-                for h in workerdata["hash_deps"]:
-                    the_data.setVar("BBHASHDEPS_%s" % h, workerdata["hash_deps"][h])
 
                 # exported_vars() returns a generator which *cannot* be passed to os.environ.update() 
                 # successfully. We also need to unset anything from the environment which shouldn't be there