Enhance Skeleton Linux Yocto Kernel Recipe
v2 cover Enhance Skeleton Linux Yocto Kernel Recipe
From: Nitin A Kamble <[email protected]>
In this v2 pull request, the commit is updated as per feedback received from Darren.
Thanks,
Nitin
The following changes since commit 863cc7483f5ee43189537940de8ee5c0964d24cc:
poky.conf: Post release version bump (2014-04-10 18:03:07 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib nitin/misc
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=nitin/misc
Nitin A Kamble (1):
meta-skeleton: linux-yocto-custom.bb: use machine overrides
meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)
Signature · 1 line
1.8.1.4
PATCH v2 1/1 meta-skeleton: linux-yocto-custom.bb: use machine overrides
From: Nitin A Kamble <[email protected]>
Use machine overrides for variables for this skeleton kernel recipe so that people following skeleton do it right at the beginning.
The machine overrides for the variables reduces variable name-space pollution and avoids unintentional influences on other layers.
--- meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)
meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb +9 -7
@@ -44,21 +44,23 @@ inherit kernel require recipes-kernel/linux/linux-yocto.inc +#Note: Replace the yourmachine string with your actual machine name here + # Override SRC_URI in a bbappend file to point at a different source # tree if you do not want to build from Linus' tree. -SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=machine" +SRC_URI_yourmachine = "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=yourmachine" -LINUX_VERSION ?= "3.4" -LINUX_VERSION_EXTENSION ?= "-custom" +LINUX_VERSION_yourmachine ?= "3.4" +LINUX_VERSION_EXTENSION_yourmachine ?= "-custom" # Override SRCREV to point to a different commit in a bbappend file to # build a different release of the Linux kernel. # tag: v3.4 76e10d158efb6d4516018846f60c2ab5501900bc -SRCREV_machine="76e10d158efb6d4516018846f60c2ab5501900bc" +SRCREV_yourmachine="76e10d158efb6d4516018846f60c2ab5501900bc" PR = "r1" PV = "${LINUX_VERSION}+git${SRCPV}" -# Override COMPATIBLE_MACHINE to include your machine in a bbappend -# file. Leaving it empty here ensures an early explicit build failure. -COMPATIBLE_MACHINE = "(^$)" +# Override COMPATIBLE_MACHINE to include your yourmachine in a bbappend +# file. +COMPATIBLE_MACHINE_yourmachine = "yourmachine"
Signature · 1 line
1.8.1.4
Re: [Patch v2 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides
Quoted 9 lines · Nitin A
From: Nitin A Kamble <[email protected]>
Use machine overrides for variables for this skeleton kernel recipe so that people following skeleton do it right at the beginning.
The machine overrides for the variables reduces variable name-space pollution and avoids unintentional influences on other layers.
Signed-off-by Nitin A Kamble <[email protected]>
Thanks Nitin,
Signature · 2 lines
Darren Hart Open Source Technology Center [email protected] Intel Corporation
Re: [Patch v2 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides
In reply to [email protected]Quoted 38 lines · On Fri, 2014-04-11 at 10:59 -0700, [email protected] wrote:
From: Nitin A Kamble <[email protected]>
Use machine overrides for variables for this skeleton kernel recipe so that people following skeleton do it right at the beginning.
The machine overrides for the variables reduces variable name-space pollution and avoids unintentional influences on other layers.
Signed-off-by Nitin A Kamble <[email protected]>--- meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb +6
-4@@ -44,21 +44,23 @@ inherit kernel require recipes-kernel/linux/linux-yocto.inc +#Note: Replace the yourmachine string with your actual machine name here + # Override SRC_URI in a bbappend file to point at a different source # tree if you do not want to build from Linus' tree. -SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=machine" +SRC_URI_yourmachine = "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=yourmachine" -LINUX_VERSION ?= "3.4" -LINUX_VERSION_EXTENSION ?= "-custom" +LINUX_VERSION_yourmachine ?= "3.4" +LINUX_VERSION_EXTENSION_yourmachine ?= "-custom" # Override SRCREV to point to a different commit in a bbappend file to # build a different release of the Linux kernel. # tag: v3.4 76e10d158efb6d4516018846f60c2ab5501900bc -SRCREV_machine="76e10d158efb6d4516018846f60c2ab5501900bc" +SRCREV_yourmachine="76e10d158efb6d4516018846f60c2ab5501900bc"
meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb line 66
Quoted 10 lines
meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb +3
-3PR = "r1" PV = "${LINUX_VERSION}+git${SRCPV}" -# Override COMPATIBLE_MACHINE to include your machine in a bbappend -# file. Leaving it empty here ensures an early explicit build failure. -COMPATIBLE_MACHINE = "(^$)" +# Override COMPATIBLE_MACHINE to include your yourmachine in a bbappend +# file. +COMPATIBLE_MACHINE_yourmachine = "yourmachine"
This breaks the autobuilder:
Cheers,
Richard
Re: [Patch v2 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides
Indeed, because the SRCURI was made machine specific. In the case of Linux Yocto custom... Their is no namespace pollution to worry about, as there is with Linux Yocto... Should we perhaps drop all the overrides and provide comented examples instead?
On Apr 13, 2014 8:39 AM, Richard Purdie <[email protected]> wrote:
Quoted 38 lines · On Fri, 2014-04-11 at 10:59 -0700, [email protected] wrote:
From: Nitin A Kamble <[email protected]>
Use machine overrides for variables for this skeleton kernel recipe so that people following skeleton do it right at the beginning.
The machine overrides for the variables reduces variable name-space pollution and avoids unintentional influences on other layers.
Signed-off-by Nitin A Kamble <[email protected]>--- meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb +6
-4@@ -44,21 +44,23 @@ inherit kernel require recipes-kernel/linux/linux-yocto.inc +#Note: Replace the yourmachine string with your actual machine name here + # Override SRC_URI in a bbappend file to point at a different source # tree if you do not want to build from Linus' tree. -SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=machine" +SRC_URI_yourmachine = "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=yourmachine" -LINUX_VERSION ?= "3.4" -LINUX_VERSION_EXTENSION ?= "-custom" +LINUX_VERSION_yourmachine ?= "3.4" +LINUX_VERSION_EXTENSION_yourmachine ?= "-custom" # Override SRCREV to point to a different commit in a bbappend file to # build a different release of the Linux kernel. # tag: v3.4 76e10d158efb6d4516018846f60c2ab5501900bc -SRCREV_machine="76e10d158efb6d4516018846f60c2ab5501900bc" +SRCREV_yourmachine="76e10d158efb6d4516018846f60c2ab5501900bc"
meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb line 66
Quoted 10 lines
meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb +3
-3PR = "r1" PV = "${LINUX_VERSION}+git${SRCPV}" -# Override COMPATIBLE_MACHINE to include your machine in a bbappend -# file. Leaving it empty here ensures an early explicit build failure. -COMPATIBLE_MACHINE = "(^$)" +# Override COMPATIBLE_MACHINE to include your yourmachine in a bbappend +# file. +COMPATIBLE_MACHINE_yourmachine = "yourmachine"
This breaks the autobuilder:
Cheers,
Richard
Re: [Patch v2 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides
Quoted 4 lines · Darren
Indeed, because the SRCURI was made machine specific. In the case of Linux Yocto custom... Their is no namespace pollution to worry about, as there is with Linux Yocto... Should we perhaps drop all the overrides and provide comented examples instead?
That, or we ask Beth to mask out this recipe in the nightly-qa-skeleton build...
Cheers,
Richard
Quoted 61 lines · Richard Purdie
Quoted 38 lines · On Fri, 2014-04-11 at 10:59 -0700, [email protected] wrote:
From: Nitin A Kamble <[email protected]>
Use machine overrides for variables for this skeleton kernel recipe so that people following skeleton do it right at the beginning.
The machine overrides for the variables reduces variable name-space pollution and avoids unintentional influences on other layers.
Signed-off-by Nitin A Kamble <[email protected]>--- meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb +6
-4@@ -44,21 +44,23 @@ inherit kernel require recipes-kernel/linux/linux-yocto.inc +#Note: Replace the yourmachine string with your actual machine name here + # Override SRC_URI in a bbappend file to point at a different source # tree if you do not want to build from Linus' tree. -SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=machine" +SRC_URI_yourmachine = "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=git;nocheckout=1;name=yourmachine" -LINUX_VERSION ?= "3.4" -LINUX_VERSION_EXTENSION ?= "-custom" +LINUX_VERSION_yourmachine ?= "3.4" +LINUX_VERSION_EXTENSION_yourmachine ?= "-custom" # Override SRCREV to point to a different commit in a bbappend file to # build a different release of the Linux kernel. # tag: v3.4 76e10d158efb6d4516018846f60c2ab5501900bc -SRCREV_machine="76e10d158efb6d4516018846f60c2ab5501900bc" +SRCREV_yourmachine="76e10d158efb6d4516018846f60c2ab5501900bc"meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb line 66
Quoted 10 lines
meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb +3
-3PR = "r1" PV = "${LINUX_VERSION}+git${SRCPV}" -# Override COMPATIBLE_MACHINE to include your machine in a bbappend -# file. Leaving it empty here ensures an early explicit build failure. -COMPATIBLE_MACHINE = "(^$)" +# Override COMPATIBLE_MACHINE to include your yourmachine in a bbappend +# file. +COMPATIBLE_MACHINE_yourmachine = "yourmachine"This breaks the autobuilder:
Cheers,
Richard