Skip to contentSkip to conversation

flite: new package

PATCH New Samuel Martin 3 participants 4 messages Apr 13, 2014 – Apr 20, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/2 flite: new package

Cc Eric Jarrige <[email protected]>
Cc Julien Boibessot <[email protected]>

---
changes v3 -> v4:
- rebase
- don't remove FLITE_DIR (Yann)

changes v2 -> v3:
- move flite package in package/flite (flat package tree)
- remove duplicate --enable-shared options (Peter, ThomasP)
- misc. cosmetic fixes
- make flite honor the DESTDIR env. var., so add a patch to fix its build system (ThomasP)

changes v1 -> v2:
- fix dependencies

---
 package/Config.in                                  |  1 +
 package/flite/Config.in                            | 16 +++++++++
 .../flite-0001-now-honor-DESTDIR-env.-var.patch    | 30 ++++++++++++++++
 package/flite/flite.mk                             | 41 ++++++++++++++++++++++
 4 files changed, 88 insertions(+)
 create mode 100644 package/flite/Config.in
 create mode 100644 package/flite/flite-0001-now-honor-DESTDIR-env.-var.patch
 create mode 100644 package/flite/flite.mk
package/Config.in +1 -0
index 4a7fed6..8e6e590 100644
@@ -9,6 +9,7 @@ source "package/bellagio/Config.in"
 source "package/faad2/Config.in"
 source "package/ffmpeg/Config.in"
 source "package/flac/Config.in"
+source "package/flite/Config.in"
 source "package/gstreamer/Config.in"
 source "package/gstreamer1/Config.in"
 source "package/jack2/Config.in"
package/flite/Config.in new file +16 -0
new file mode 100644
index 0000000..a02f8fe
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_FLITE
+	bool "flite"
+	depends on BR2_USE_WCHAR
+	help
+	  Flite: a small, fast run time synthesis engine.
+
+	  Flite (festival-lite) is a small, fast run-time synthesis engine
+	  developed at CMU and primarily designed for small embedded machines
+	  and/or large servers. Flite is designed as an alternative synthesis
+	  engine to Festival for voices built using the FestVox suite of voice
+	  building tools.
+
+	  http://www.speech.cs.cmu.edu/flite
+
+comment "flite require a toolchain with WCHAR support"
+	depends on !BR2_USE_WCHAR
package/flite/flite-0001-now-honor-DESTDIR-env.-var.patch new file +30 -0
new file mode 100644
index 0000000..5972f34
@@ -0,0 +1,30 @@
+From 658f3243238efe951f6242fa384e990d77078afc Mon Sep 17 00:00:00 2001
+From: Samuel Martin <[email protected]>
+Date: Fri, 27 Dec 2013 17:42:39 +0100
+Subject: [PATCH] now honor DESTDIR env. var.
+
+Flite used a handwritten a Makefile which doesn't honor DESTDIR environment
+variable, though it uses autoconf.
+
+Signed-off-by: Samuel Martin <[email protected]>
+---
+ config/config.in | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/config/config.in b/config/config.in
+index 914d2bf..43f1a56 100644
+--- a/config/config.in
++++ b/config/config.in
+@@ -49,6 +49,6 @@ include $(TOP)/config/$(langvox).lv
+ prefix        = @prefix@
+ exec_prefix   = @exec_prefix@
+ EXEEXT	      = @EXEEXT@
+-INSTALLBINDIR = @bindir@
+-INSTALLLIBDIR = @libdir@
+-INSTALLINCDIR = @includedir@/flite
++INSTALLBINDIR = $(DESTDIR)@bindir@
++INSTALLLIBDIR = $(DESTDIR)@libdir@
++INSTALLINCDIR = $(DESTDIR)@includedir@/flite
+--
+1.8.5.2
+
package/flite/flite.mk new file +41 -0

41 lines not on this page · raw message

Signature · 1 line
1.9.2
#1 lore raw

PATCH v4 2/2 canfestival: new package

Cc Eric Jarrige <[email protected]>
Cc Julien Boibessot <[email protected]>
Cc Davide Viti <[email protected]>

---
changes v3 -> v4:
- rebase
- pass --prefix=/usr to the configure call (Davide)
- misc. cleanup in canfestival.mk (Yann)
- keep package/Config.in alphabetically ordered

changes v2 -> v3:
- rename package libcanfestival -> canfestival (follow upstream name)
- add option to install examples
- use latest revision
- use tarball instead of hg clone
- cosmetic fixes and typos (Peter and Yegor)
- add note about the standard mainline can interface (Peter)
- set default max bus number to 1 (Peter)

changes v1 -> v2:
- clean/fix *.mk

---
 package/Config.in                                  |   1 +
 package/canfestival/Config.in                      | 101 +++
 .../canfestival-0001-now-honor-DESTDIR.patch       | 787 +++++++++++++++++++++
 package/canfestival/canfestival.mk                 |  54 ++
 4 files changed, 943 insertions(+)
 create mode 100644 package/canfestival/Config.in
 create mode 100644 package/canfestival/canfestival-0001-now-honor-DESTDIR.patch
 create mode 100644 package/canfestival/canfestival.mk
package/Config.in +1 -0
index 8e6e590..201da62 100644
@@ -705,6 +705,7 @@ endmenu
 menu "Networking"
 source "package/agentpp/Config.in"
 source "package/c-ares/Config.in"
+source "package/canfestival/Config.in"
 source "package/cppzmq/Config.in"
 source "package/czmq/Config.in"
 source "package/filemq/Config.in"
package/canfestival/Config.in new file +101 -0

101 lines not on this page · raw message

package/canfestival/canfestival-0001-now-honor-DESTDIR.patch new file +787 -0

787 lines not on this page · raw message

package/canfestival/canfestival.mk new file +54 -0

54 lines not on this page · raw message

Signature · 1 line
1.9.2
#2 lore raw

PATCH v4 2/2 canfestival: new package

Just a few cosmetic things

On Sun, Apr 13, 2014 at 07:41:35PM +0200, Samuel Martin wrote:
[...]

package/canfestival/Config.in line 9

Quoted 10 lines
package/canfestival/Config.in new file +9 -0
@@ -0,0 +1,101 @@
+config BR2_PACKAGE_CANFESTIVAL
+	bool "CanFestival"
+	depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm
+	help
+	  CanFestival is an OpenSource CANOpen framework, licensed with GPLv2
+	  and LGPLv2.
+
+	  http://www.canfestival.org
+

here help comment is ended with a dot

package/canfestival/Config.in line 22

Quoted 13 lines
package/canfestival/Config.in new file +13 -0
+if BR2_PACKAGE_CANFESTIVAL
+
+choice
+	prompt "driver to use"
+	default BR2_PACKAGE_CANFESTIVAL_SOCKET
+
+config BR2_PACKAGE_CANFESTIVAL_ANAGATE_LINUX
+	bool "anagate_linux"
+	help
+	  AnaGate CAN(duo) driver for linux
+
+	  http://www.anagate.de/en/index.html
+

here the sentence is not ended with a dot

package/canfestival/Config.in line 29

Quoted 7 lines
package/canfestival/Config.in new file +7 -0
+config BR2_PACKAGE_CANFESTIVAL_PEAK_LINUX
+	bool "peak_linux"
+	help
+	  Linux build host installed Peak driver and library
+
+	  http://www.peak-system.com/linux/
+

missing dot at the end of the help sentence
The description is not very clear to me

package/canfestival/Config.in line 34

Quoted 5 lines
package/canfestival/Config.in new file +5 -0
+config BR2_PACKAGE_CANFESTIVAL_VIRTUAL
+	bool "virtual"
+	help
+	  Unix pipe based virtual can driver
+

I'd use capital CAN
missing dot

package/canfestival/Config.in line 39

Quoted 5 lines
package/canfestival/Config.in new file +5 -0
+config BR2_PACKAGE_CANFESTIVAL_VIRTUAL_KERNEL
+	bool "virtual_kernel"
+	help
+	  Kernel module virtual can driver
+

I'd use capital CAN
missing dot

package/canfestival/Config.in line 53

Quoted 7 lines
package/canfestival/Config.in new file +7 -0
+config BR2_PACKAGE_CANFESTIVAL_LINCAN
+	bool "lincan"
+	help
+	  Lincan driver
+
+	  http://www.ocera.org/download/components/WP7/lincan-0.3.3.html
+

missing dot

package/canfestival/Config.in line 60

Quoted 7 lines
package/canfestival/Config.in new file +7 -0
+config BR2_PACKAGE_CANFESTIVAL_CAN4LINUX
+	bool "can4linux"
+	help
+	  Can4linux driver
+
+	  http://www.port.de/engl/canprod/hw_can4linux.html
+

missing dot

package/canfestival/Config.in line 67

Quoted 7 lines
package/canfestival/Config.in new file +7 -0
+config BR2_PACKAGE_CANFESTIVAL_COPCICAN_LINUX
+	bool "copcican_linux"
+	help
+	  User space driver interface for CO-PCICAN card
+
+	  http://www.cosateq.com/
+

missing dot

package/canfestival/Config.in line 74

Quoted 7 lines
package/canfestival/Config.in new file +7 -0
+config BR2_PACKAGE_CANFESTIVAL_COPCICAN_COMEDI
+	bool "copcican_comedi"
+	help
+	  COMEDI driver interface for CO-PCICAN card
+
+	  http://www.cosateq.com/
+

missing dot

regards,
Davide

#3 lore raw

PATCH v4 1/2 flite: new package

In reply to Samuel Martin

Dear Samuel Martin,

Quoted 3 lines · Samuel Martin
Cc Eric Jarrige <[email protected]>
Cc Julien Boibessot <[email protected]>

Applied, after doing two changes. See below.

package/flite/Config.in line 11

Quoted 5 lines
package/flite/Config.in new file +5 -0
+	  Flite (festival-lite) is a small, fast run-time synthesis engine
+	  developed at CMU and primarily designed for small embedded machines
+	  and/or large servers. Flite is designed as an alternative synthesis
+	  engine to Festival for voices built using the FestVox suite of voice
+	  building tools.

I've rewrapped that to use a smaller number of columns.

package/flite/Config.in line 15

Quoted 3 lines
package/flite/Config.in new file +3 -0
+	  http://www.speech.cs.cmu.edu/flite
+
+comment "flite require a toolchain with WCHAR support"

RTFM: this was not the right format for such comments ;-)

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com