platform-drivers-x86: intel_pmic_gpio: Fix off-by-one valid offset range check
PATCH v2 1/1 platform-drivers-x86: intel_pmic_gpio: Fix off-by-one valid offset range check
Only pin 0-7 support input, so the valid offset range should be 0 ~ 7.
Signed-off-by Axel Lin <[email protected]>
---
This is v2 of "[PATCH] platform-drivers: x86: Fix off-by-one valid offset range checking"
drivers/platform/x86/intel_pmic_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/platform/x86/intel_pmic_gpio.c +2 -2
@@ -91,7 +91,7 @@ static void pmic_program_irqtype(int gpio, int type)static int pmic_gpio_direction_input (struct gpio_chip *chip,unsigned offset) { -if (offset >8 ) { +if (offset >=8 ) {pr_err ("only pin 0-7 support input\n" );return -1 ;/* we only have 8 GPIO can use as input */ }
@@ -130,7 +130,7 @@ static int pmic_gpio_get(struct gpio_chip *chip, unsigned offset)int ret;/* we only have 8 GPIO pins we can use as input */ -if (offset >8 ) +if (offset >=8 )return -EOPNOTSUPP ; ret =intel_scu_ipc_ioread8 (GPIO0 + offset, &r);if (ret <0 )
Signature · 1 line
1.8.3.2
Thanks! Looks good for me.
-----Original Message-----
From: Axel Lin [mailto:[email protected]]
Sent: Tuesday, April 15, 2014 10:54 AM
To: Matthew Garrett
Cc: Du, Alek; [email protected]
Subject: [PATCH v2] platform-drivers-x86: intel_pmic_gpio: Fix off-by-one valid offset range check
Only pin 0-7 support input, so the valid offset range should be 0 ~ 7.
Signed-off-by Axel Lin <[email protected]>
---
This is v2 of "[PATCH] platform-drivers: x86: Fix off-by-one valid offset range checking"
drivers/platform/x86/intel_pmic_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/platform/x86/intel_pmic_gpio.c +2 -2
@@ -91,7 +91,7 @@ static void pmic_program_irqtype(int gpio, int type)static int pmic_gpio_direction_input (struct gpio_chip *chip,unsigned offset) { -if (offset >8 ) { +if (offset >=8 ) {pr_err ("only pin 0-7 support input\n" );return -1 ;/* we only have 8 GPIO can use as input */ }
@@ -130,7 +130,7 @@ static int pmic_gpio_get(struct gpio_chip *chip, unsigned offset)int ret;/* we only have 8 GPIO pins we can use as input */ -if (offset >8 ) +if (offset >=8 )return -EOPNOTSUPP ; ret =intel_scu_ipc_ioread8 (GPIO0 + offset, &r);if (ret <0 )
--
1.8.3.2