Skip to contentSkip to conversation

x86: LLVMLinux: Wrap -mno-80387 with cc-option

PATCH In review [email protected] 3 participants 5 messages Apr 22, 2014 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: LLVMLinux: Wrap -mno-80387 with cc-option

From: Behan Webster <[email protected]>

Wrap -mno-80387 gcc options with cc-option so they don't break clang.

---
 arch/x86/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/x86/Makefile +3 -1
index d1b7c37..ce6ad7e 100644
@@ -83,7 +83,9 @@ else
         KBUILD_CFLAGS += -m64
 
         # Don't autogenerate traditional x87, MMX or SSE instructions
-        KBUILD_CFLAGS += -mno-mmx -mno-sse -mno-80387 -mno-fp-ret-in-387
+        KBUILD_CFLAGS += -mno-mmx -mno-sse
+        KBUILD_CFLAGS += $(call cc-option,-mno-80387)
+        KBUILD_CFLAGS += $(call cc-option,-mno-fp-ret-in-387)
 
 	# Use -mpreferred-stack-boundary=3 if supported.
 	KBUILD_CFLAGS += $(call cc-option,-mpreferred-stack-boundary=3)
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 14 lines · * [email protected] <[email protected]> wrote:

From: Behan Webster <[email protected]>

Wrap -mno-80387 gcc options with cc-option so they don't break clang.

---
 arch/x86/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/x86/Makefile +0 -0
index d1b7c37..ce6ad7e 100644

arch/x86/Makefile else · line 88

Quoted 7 lines
arch/x86/Makefile +3 -1
@@ -83,7 +83,9 @@ else
         KBUILD_CFLAGS += -m64
 
         # Don't autogenerate traditional x87, MMX or SSE instructions
-        KBUILD_CFLAGS += -mno-mmx -mno-sse -mno-80387 -mno-fp-ret-in-387
+        KBUILD_CFLAGS += -mno-mmx -mno-sse
+        KBUILD_CFLAGS += $(call cc-option,-mno-80387)
+        KBUILD_CFLAGS += $(call cc-option,-mno-fp-ret-in-387)

Is there a clang equivalent option that inhibits all things FPU opcode generation by the compiler?

That's the general purpose of -no-80387.

Thanks,

Ingo

#2 lore raw
Quoted 18 lines · Ingo Molnar
Quoted 16 lines · * [email protected] <[email protected]> wrote:

From: Behan Webster <[email protected]>

Wrap -mno-80387 gcc options with cc-option so they don't break clang.

---
  arch/x86/Makefile | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
arch/x86/Makefile +0 -0
index d1b7c37..ce6ad7e 100644
@@ -83,7 +83,9 @@ else
          KBUILD_CFLAGS += -m64
 
Quoted 7 lines

arch/x86/Makefile else · line 88

Quoted 5 lines
arch/x86/Makefile +3 -1
          # Don't autogenerate traditional x87, MMX or SSE instructions
-        KBUILD_CFLAGS += -mno-mmx -mno-sse -mno-80387 -mno-fp-ret-in-387
+        KBUILD_CFLAGS += -mno-mmx -mno-sse
+        KBUILD_CFLAGS += $(call cc-option,-mno-80387)
+        KBUILD_CFLAGS += $(call cc-option,-mno-fp-ret-in-387)

Is there a clang equivalent option that inhibits all things FPU opcode generation by the compiler?

Not that I've found yet. Still investigating.

Quoted 1 line

That's the general purpose of -no-80387.

Yes, I understand what this is trying to accomplish. At this point I'd just like this new code not to break the use of clang with v3.15.

I will submit another patch which adds similar functionality when compiled with clang once I have that answer.

Behan

Signature · 2 lines
Behan Webster
[email protected]
#3 lore raw
Quoted 25 lines · Behan Webster
Quoted 11 lines · Ingo Molnar
Quoted 9 lines · * [email protected] <[email protected]> wrote:

From: Behan Webster <[email protected]>

Wrap -mno-80387 gcc options with cc-option so they don't break clang.

---
 arch/x86/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Quoted 13 lines

arch/x86/Makefile else · line 87

Quoted 11 lines
arch/x86/Makefile +3 -1
index d1b7c37..ce6ad7e 100644
@@ -83,7 +83,9 @@ else
         KBUILD_CFLAGS += -m64
         # Don't autogenerate traditional x87, MMX or SSE instructions
-        KBUILD_CFLAGS += -mno-mmx -mno-sse -mno-80387 -mno-fp-ret-in-387
+        KBUILD_CFLAGS += -mno-mmx -mno-sse
+        KBUILD_CFLAGS += $(call cc-option,-mno-80387)
+        KBUILD_CFLAGS += $(call cc-option,-mno-fp-ret-in-387)

Is there a clang equivalent option that inhibits all things FPU opcode generation by the compiler?

Quoted 6 lines

Not that I've found yet. Still investigating.

Quoted 1 line

That's the general purpose of -no-80387.

Yes, I understand what this is trying to accomplish. At this point I'd just like this new code not to break the use of clang with v3.15.

Agreed.

Quoted 2 lines

I will submit another patch which adds similar functionality when compiled with clang once I have that answer.

Thanks!

Ingo

#4 lore raw
In reply to [email protected]
x86: LLVMLinux: Wrap -mno-80387 with cc-option
Commit-ID:  8f2dd677bec68fb55904799a82674c9e64b23be3
Gitweb:     http://git.kernel.org/tip/8f2dd677bec68fb55904799a82674c9e64b23be3
Author:     Behan Webster <[email protected]>
AuthorDate: Mon, 21 Apr 2014 22:40:27 -0700
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 22 Apr 2014 11:41:16 +0200

x86: LLVMLinux: Wrap -mno-80387 with cc-option

Wrap -mno-80387 gcc options with cc-option so they don't break clang.

---
 arch/x86/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/x86/Makefile +3 -1
index d1b7c37..ce6ad7e 100644
@@ -83,7 +83,9 @@ else
         KBUILD_CFLAGS += -m64
 
         # Don't autogenerate traditional x87, MMX or SSE instructions
-        KBUILD_CFLAGS += -mno-mmx -mno-sse -mno-80387 -mno-fp-ret-in-387
+        KBUILD_CFLAGS += -mno-mmx -mno-sse
+        KBUILD_CFLAGS += $(call cc-option,-mno-80387)
+        KBUILD_CFLAGS += $(call cc-option,-mno-fp-ret-in-387)
 
 	# Use -mpreferred-stack-boundary=3 if supported.
 	KBUILD_CFLAGS += $(call cc-option,-mpreferred-stack-boundary=3)