Skip to contentSkip to conversation

Input: ads7877: Remove bitrotted comment

PATCH In review Mark Brown 2 participants 4 messages Apr 22, 2014 – Apr 25, 2014

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 Input: ads7877: Remove bitrotted comment

From: Mark Brown <[email protected]>

While searching for users of spi_async() I found a reference in the ad7877 driver to using it to initiate data transfer from the interrupt handler. However there is no code for this, instead the interrupt handler is a threaded handler and uses spi_sync() instead.

Remove the bitrotted comment, though in actual fact the use case mentioned is a great use for spi_async() since it would cut down on latency handling the interrupt by saving us a context switch before we start SPI.

This was previously implemented, it was removed in commit b534422b2d11 (Input: ad7877 - switch to using threaded IRQ) for code complexity reasons. It may be better to revert that commit instead.

---
 drivers/input/touchscreen/ad7877.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/input/touchscreen/ad7877.c +0 -5
index 6793c85903ae..523865daa1d3 100644
@@ -210,11 +210,6 @@ static bool gpio3;
 module_param(gpio3, bool, 0);
 MODULE_PARM_DESC(gpio3, "If gpio3 is set to 1 AUX3 acts as GPIO3");
 
-/*
- * ad7877_read/write are only used for initial setup and for sysfs controls.
- * The main traffic is done using spi_async() in the interrupt handler.
- */
-
 static int ad7877_read(struct spi_device *spi, u16 reg)
 {
 	struct ser_req *req;
Signature · 1 line
1.9.2
maintainer
#1 lore raw
Quoted 7 lines · Mark Brown

From: Mark Brown <[email protected]>

While searching for users of spi_async() I found a reference in the ad7877 driver to using it to initiate data transfer from the interrupt handler. However there is no code for this, instead the interrupt handler is a threaded handler and uses spi_sync() instead.

Quoted 7 lines

Remove the bitrotted comment, though in actual fact the use case mentioned is a great use for spi_async() since it would cut down on latency handling the interrupt by saving us a context switch before we start SPI.

This was previously implemented, it was removed in commit b534422b2d11 (Input: ad7877 - switch to using threaded IRQ) for code complexity reasons. It may be better to revert that commit instead.

Hmm, maybe.. although I think original would cause device 'stuck' if call to spi_async() fails, so probably not a straight revert...

Quoted 26 lines
---
 drivers/input/touchscreen/ad7877.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/input/touchscreen/ad7877.c +0 -5
index 6793c85903ae..523865daa1d3 100644
@@ -210,11 +210,6 @@ static bool gpio3;
 module_param(gpio3, bool, 0);
 MODULE_PARM_DESC(gpio3, "If gpio3 is set to 1 AUX3 acts as GPIO3");
 
-/*
- * ad7877_read/write are only used for initial setup and for sysfs controls.
- * The main traffic is done using spi_async() in the interrupt handler.
- */
-
 static int ad7877_read(struct spi_device *spi, u16 reg)
 {
 	struct ser_req *req;
Signature · 1 line
1.9.2
Signature · 1 line
Dmitry
author
#2 lore raw
Quoted 6 lines · Dmitry Torokhov
Quoted 3 lines · Mark Brown

Remove the bitrotted comment, though in actual fact the use case mentioned is a great use for spi_async() since it would cut down on latency handling the interrupt by saving us a context switch before we start SPI.

Quoted 6 lines
Quoted 3 lines

This was previously implemented, it was removed in commit b534422b2d11 (Input: ad7877 - switch to using threaded IRQ) for code complexity reasons. It may be better to revert that commit instead.

Hmm, maybe.. although I think original would cause device 'stuck' if call to spi_async() fails, so probably not a straight revert...

Probably best just to apply this, then - someone can always reimplement if they need to.

maintainer
#3 lore raw
Quoted 11 lines · Mark Brown
Quoted 9 lines · Dmitry Torokhov
Quoted 7 lines · Mark Brown

Remove the bitrotted comment, though in actual fact the use case mentioned is a great use for spi_async() since it would cut down on latency handling the interrupt by saving us a context switch before we start SPI.

This was previously implemented, it was removed in commit b534422b2d11 (Input: ad7877 - switch to using threaded IRQ) for code complexity reasons. It may be better to revert that commit instead.

Quoted 5 lines
Quoted 2 lines

Hmm, maybe.. although I think original would cause device 'stuck' if call to spi_async() fails, so probably not a straight revert...

Probably best just to apply this, then - someone can always reimplement if they need to.

OK, applied.

Thanks.

Signature · 1 line
Dmitry