staging/rtl8821ae: fix sparse address space warning

PATCH Superseded Anders Darander 2 participants 2 messages Apr 23, 2014 Staging

lore

Share & tools

lore

Anders Darander

author

2014-04-23 12:06 UTC #0 lore raw

PATCH 1/1 staging/rtl8821ae: fix sparse address space warning

When unmapping the pci memory, the pointer was explicitly casted to void*, thus omitting the __iomem designation.

Signed-off-by Anders Darander <[email protected]>

---
 drivers/staging/rtl8821ae/pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/rtl8821ae/pci.c +2 -2

index a562aa6..d934ecb 100644
@@ -2416,7 +2416,7 @@ fail3:
 	ieee80211_free_hw(hw);
 
 	if (rtlpriv->io.pci_mem_start != 0)
-		pci_iounmap(pdev, (void *)rtlpriv->io.pci_mem_start);
+		pci_iounmap(pdev, (void __iomem *)rtlpriv->io.pci_mem_start);
 
 fail2:
 	pci_release_regions(pdev);

@@ -2479,7 +2479,7 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
 
 	list_del(&rtlpriv->list);
 	if (rtlpriv->io.pci_mem_start != 0) {
-		pci_iounmap(pdev, (void *)rtlpriv->io.pci_mem_start);
+		pci_iounmap(pdev, (void __iomem *)rtlpriv->io.pci_mem_start);
 		pci_release_regions(pdev);
 	}

Signature · 1 line

2.0.0.rc0

Dan Carpenter

2014-04-23 12:31 UTC #1 lore raw

Quoted 2 lines · Anders Darander

When unmapping the pci memory, the pointer was explicitly casted to void*, thus omitting the __iomem designation.

It looks like the struct definition should be updated instead of every single reference being casted.

regards,
dan carpenter