Skip to contentSkip to conversation

tests/gem_bo_falloc: New igt for testing gem_fallocate() ioctl

RFC In review [email protected] 2 participants 3 messages Apr 25, 2014

lore
Share & tools
lore
#0 lore raw

RFC 1/1 tests/gem_bo_falloc: New igt for testing gem_fallocate() ioctl

From: "Siluvery, Arun" <[email protected]>

This ioctl allows vary the effective size of the gem object. User can mark certain range in object space as scratch thus effectively modifying the size used.

---
 tests/Makefile.sources |   1 +
 tests/gem_bo_falloc.c  | 469 +++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 470 insertions(+)
 create mode 100644 tests/gem_bo_falloc.c
tests/Makefile.sources +1 -0
index 88866ac..25c010e 100644
@@ -120,6 +120,7 @@ TESTS_progs = \
 	gem_unref_active_buffers \
 	gem_vmap_blits \
 	gem_wait_render_timeout \
+	gem_bo_falloc \
 	gen3_mixed_blits \
 	gen3_render_linear_blits \
 	gen3_render_mixed_blits \
tests/gem_bo_falloc.c new file +469 -0

469 lines not on this page · raw message

Signature · 6 lines
1.9.2

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

tests/gem_bo_falloc.c line 456

Quoted 9 lines · On Fri, Apr 25, 2014 at 01:50:32PM +0100, [email protected] wrote:
tests/gem_bo_falloc.c new file +9 -0
+int main(int argc, char **argv)
+{
+	igt_subtest_init(argc, argv);
+
+	igt_fixture
+		fd = drm_open_any();
+
+	igt_subtest("gem_falloc arguments validation")
+		test_gem_falloc_arguments_validation(fd);

We tend to have no spaces in subtest names, please use dash '-' instead. space have a good chance to upset our tooling.
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#2 lore raw
Quoted 13 lines · Daniel Vetter

tests/gem_bo_falloc.c line 456

Quoted 9 lines · On Fri, Apr 25, 2014 at 01:50:32PM +0100, [email protected] wrote:
tests/gem_bo_falloc.c new file +9 -0
+int main(int argc, char **argv)
+{
+	igt_subtest_init(argc, argv);
+
+	igt_fixture
+		fd = drm_open_any();
+
+	igt_subtest("gem_falloc arguments validation")
+		test_gem_falloc_arguments_validation(fd);

We tend to have no spaces in subtest names, please use dash '-' instead. space have a good chance to upset our tooling.

Also no need to repeat gem_falloc in each subtest, our tooling generates an overall testcase name of "igt/$test_binary/$subtest_name". So adding gem_falloc again is redundant.
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch