staging: gs_fpgaboot: remove __TIMESTAMP__ macro
PATCH 1/1 staging: gs_fpgaboot: remove __TIMESTAMP__ macro
We specifically build the kernel with -Werror=date-time to detect such macros, which gives us this error:
gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-Werror=date-time]
pr_info("built at %s UTC\n", __TIMESTAMP__);
The obvious fix is to remove the printk output line.
drivers/staging/gs_fpgaboot/gs_fpgaboot.c +0 -1
@@ -373,7 +373,6 @@ static int __init gs_fpgaboot_init(void) r =-1 ;pr_info ("FPGA DOWNLOAD --->\n" ); -pr_info ("built at %s UTC\n" , __TIMESTAMP__);pr_info ("FPGA image file name: %s\n" , file);
________________________________________
From: Arnd Bergmann <[email protected]>
Sent: Tuesday, March 25, 2014 8:48 AM
To: [email protected]
Cc: [email protected]; Insop Song
Subject: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro
We specifically build the kernel with -Werror=date-time to detect such macros, which gives us this error:
gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-Werror=date-time]
pr_info("built at %s UTC\n", __TIMESTAMP__);
The obvious fix is to remove the printk output line.
drivers/staging/gs_fpgaboot/gs_fpgaboot.c +0 -1
@@ -373,7 +373,6 @@ static int __init gs_fpgaboot_init(void) r =-1 ;pr_info ("FPGA DOWNLOAD --->\n" ); -pr_info ("built at %s UTC\n" , __TIMESTAMP__);pr_info ("FPGA image file name: %s\n" , file);
Quoted 5 lines · Arnd Bergmann
We specifically build the kernel with -Werror=date-time to detect such macros, which gives us this error:
gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-Werror=date-time]
pr_info("built at %s UTC\n", __TIMESTAMP__);
Worse, gcc 4.1.2 doesn't seem to understand __TIMESTAMP__:
drivers/staging/gs_fpgaboot/gs_fpgaboot.c: In function ‘gs_fpgaboot_init’:drivers/staging/gs_fpgaboot/gs_fpgaboot.c:376: error: ‘__TIMESTAMP__’ undeclared (first use in this function) drivers/staging/gs_fpgaboot/gs_fpgaboot.c:376: error: (Each undeclared identifier is reported only once drivers/staging/gs_fpgaboot/gs_fpgaboot.c:376: error: for each function it appears in.)
Quoted 3 lines
The obvious fix is to remove the printk output line.
Signed-off-by Arnd Bergmann <[email protected]>
drivers/staging/gs_fpgaboot/gs_fpgaboot.c static int __init gs_fpgaboot_init(void) · line 378
Quoted 12 lines
drivers/staging/gs_fpgaboot/gs_fpgaboot.c +0
-1@@ -373,7 +373,6 @@ static int __init gs_fpgaboot_init(void) r =-1 ;pr_info ("FPGA DOWNLOAD --->\n" ); -pr_info ("built at %s UTC\n" , __TIMESTAMP__);pr_info ("FPGA image file name: %s\n" , file);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds