Skip to contentSkip to conversation

mmc: wmt-sdmmc: Remove deprecated IRQF_DISABLED

PATCH RESEND Superseded Axel Lin 2 participants 3 messages Apr 27, 2014 – Jun 16, 2014

Subsystems (2)
MMC, SD and SDIO Arm/VT8500 Arm architecture
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH RESEND 1/1 mmc: wmt-sdmmc: Remove deprecated IRQF_DISABLED

It's a NOOP since 2.6.35 and it will be removed one day. This is not trivial because current code uses hard coded 32 instead of IRQF_DISABLED in the request_irq call.

Signed-off-by Axel Lin <[email protected]>

---
This patch was sent on:
http://www.spinics.net/lists/linux-mmc/msg22644.html

 drivers/mmc/host/wmt-sdmmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/wmt-sdmmc.c +1 -1
index 5501c9f..8a48a50 100644
@@ -829,7 +829,7 @@ static int wmt_mci_probe(struct platform_device *pdev)
 		goto fail3;
 	}
 
-	ret = request_irq(dma_irq, wmt_mci_dma_isr, 32, "sdmmc", priv);
+	ret = request_irq(dma_irq, wmt_mci_dma_isr, 0, "sdmmc", priv);
 	if (ret) {
 		dev_err(&pdev->dev, "Register DMA IRQ fail\n");
 		goto fail4;
Signature · 1 line
1.8.1.2
author
#1 lore raw

PATCH RESEND 1/1 mmc: wmt-sdmmc: Remove deprecated IRQF_DISABLED

2014-04-27 18:25 GMT+08:00 Axel Lin <[email protected]>:

Quoted 17 lines

It's a NOOP since 2.6.35 and it will be removed one day. This is not trivial because current code uses hard coded 32 instead of IRQF_DISABLED in the request_irq call.

Signed-off-by Axel Lin <[email protected]>

---
This patch was sent on:
http://www.spinics.net/lists/linux-mmc/msg22644.html

 drivers/mmc/host/wmt-sdmmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/wmt-sdmmc.c +0 -0
index 5501c9f..8a48a50 100644

drivers/mmc/host/wmt-sdmmc.c static int wmt_mci_probe(struct platform_device *pdev) · line 832

Quoted 5 lines
drivers/mmc/host/wmt-sdmmc.c +1 -1
@@ -829,7 +829,7 @@ static int wmt_mci_probe(struct platform_device *pdev)
                goto fail3;
        }
 
-       ret = request_irq(dma_irq, wmt_mci_dma_isr, 32, "sdmmc", priv);
+       ret = request_irq(dma_irq, wmt_mci_dma_isr, 0, "sdmmc", priv);

Hi Ulf,
Would you pick up this one?

I have no idea why current uses hard-coded 32 rather than IRQF_DISABLED. IRQF_DISABLED is marked as DEPRECATED anyway, so just set 0 for the flags field of request_irq.

Regards,
Axel

Applied
#2 lore raw

PATCH RESEND 1/1 mmc: wmt-sdmmc: Remove deprecated IRQF_DISABLED

In reply to Axel Lin
Quoted 5 lines · Axel Lin

It's a NOOP since 2.6.35 and it will be removed one day. This is not trivial because current code uses hard coded 32 instead of IRQF_DISABLED in the request_irq call.

Signed-off-by Axel Lin <[email protected]>

Thanks! Applied for next.

Kind regards
Uffe

Quoted 25 lines

---
This patch was sent on:
http://www.spinics.net/lists/linux-mmc/msg22644.html

 drivers/mmc/host/wmt-sdmmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/wmt-sdmmc.c +1 -2
index 5501c9f..8a48a50 100644
@@ -829,7 +829,7 @@ static int wmt_mci_probe(struct platform_device *pdev)
                goto fail3;
        }
 
-       ret = request_irq(dma_irq, wmt_mci_dma_isr, 32, "sdmmc", priv);
+       ret = request_irq(dma_irq, wmt_mci_dma_isr, 0, "sdmmc", priv);
        if (ret) {
                dev_err(&pdev->dev, "Register DMA IRQ fail\n");
                goto fail4;
--

1.8.1.2