fsl-usb: do not test for PHY_CLK_VALID bit on controller version 1.6
Subsystems (2)
PATCH 1/1 fsl-usb: do not test for PHY_CLK_VALID bit on controller version 1.6
Per reference manuals of Freescale P1020 and P2020 SoCs, USB controller present in these SoCs has bit 17 of USBx_CONTROL register marked as Reserved - there is no PHY_CLK_VALID bit there.
Testing for this bit in ehci_fsl_setup_phy() behaves differently on two P1020RDB boards available here - on one board test passes and fsl-usb init succeeds, but on other board test fails, causing fsl-usb init to fail.
This patch changes ehci_fsl_setup_phy() not to test PHY_CLK_VALID on controller version 1.6 that (per manual) does not have this bit.
Signed-off-by Nikita Yushchenko <[email protected]>
--- drivers/usb/host/ehci-fsl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/host/ehci-fsl.c +2 -1
@@ -248,7 +248,8 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,break ; } -if (pdata->have_sysif_regs && pdata->controller_ver && +if (pdata->have_sysif_regs && + pdata->controller_ver >FSL_USB_VER_1_6 && (phy_mode ==FSL_USB2_PHY_ULPI )) {/* check PHY_CLK_VALID to get phy clk valid */ if (!(spin_event_timeout(in_be32(non_ehci + FSL_SOC_USB_CTRL) &
Signature · 1 line
1.7.10.4