Skip to contentSkip to conversation

tests/pm_pc8: skip the test if runtime PM is disabled

PATCH In review Imre Deak 3 participants 7 messages Apr 25, 2014 – Apr 28, 2014

lore
Share & tools
lore

Imre Deak

author
#0 lore raw

PATCH 1/1 tests/pm_pc8: skip the test if runtime PM is disabled

The PC8 state won't be entered unless runtime PM is enabled, so support for PC8 residency counters alone is not enough to run this test.

---
 tests/pm_pc8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/pm_pc8.c +1 -1
index 010af44..9a95326 100644
@@ -769,7 +769,7 @@ static void setup_environment(void)
 	printf("Runtime PM support: %d\n", has_runtime_pm);
 	printf("PC8 residency support: %d\n", has_pc8);
 
-	igt_require(has_runtime_pm || has_pc8);
+	igt_require(has_runtime_pm);
 }
 
 static void teardown_environment(void)
Signature · 1 line
1.8.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Imre Deak

The PC8 state won't be entered unless runtime PM is enabled, so support for PC8 residency counters alone is not enough to run this test.

Quoted 24 lines
---
 tests/pm_pc8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/pm_pc8.c +1 -1
index 010af44..9a95326 100644
@@ -769,7 +769,7 @@ static void setup_environment(void)
 	printf("Runtime PM support: %d\n", has_runtime_pm);
 	printf("PC8 residency support: %d\n", has_pc8);
 
-	igt_require(has_runtime_pm || has_pc8);
+	igt_require(has_runtime_pm);
 }
 
 static void teardown_environment(void)
Signature · 6 lines
1.8.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#2 lore raw

2014-04-25 5:08 GMT-03:00 Daniel Vetter <[email protected]>:

Quoted 3 lines · Imre Deak
Quoted 2 lines

The PC8 state won't be entered unless runtime PM is enabled, so support for PC8 residency counters alone is not enough to run this test.

This is true only for the very latest kernels. We have Kernels with PC8 support and without runtime PM support. Do you actually need this specific patch to solve any problems you're currently having? If not, maybe we could revert it so people with stable Kernels will be able to run IGT.

Thanks,
Paulo

Quoted 38 lines
Quoted 2 lines
Quoted 20 lines
---
 tests/pm_pc8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/pm_pc8.c +1 -2
index 010af44..9a95326 100644
@@ -769,7 +769,7 @@ static void setup_environment(void)
      printf("Runtime PM support: %d\n", has_runtime_pm);
      printf("PC8 residency support: %d\n", has_pc8);
 
-     igt_require(has_runtime_pm || has_pc8);
+     igt_require(has_runtime_pm);
 }
 
 static void teardown_environment(void)
--

1.8.4

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 1 line
Paulo Zanoni
author
#3 lore raw
Quoted 10 lines · Paulo Zanoni

2014-04-25 5:08 GMT-03:00 Daniel Vetter <[email protected]>:

Quoted 3 lines · Imre Deak
Quoted 2 lines

The PC8 state won't be entered unless runtime PM is enabled, so support for PC8 residency counters alone is not enough to run this test.

This is true only for the very latest kernels. We have Kernels with PC8 support and without runtime PM support. Do you actually need this specific patch to solve any problems you're currently having? If not, maybe we could revert it so people with stable Kernels will be able to run IGT.

The following one needs this at least on BDW/current kernel:
https://bugs.freedesktop.org/show_bug.cgi?id=77565

I might be wrong, but I thought we don't need backward compatibility in igt. We could also make the check kernel version dependent, I'm not sure if it's worth the effort.

--Imre

Quoted 45 lines

Thanks,
Paulo

Quoted 38 lines
Quoted 2 lines
Quoted 20 lines
---
 tests/pm_pc8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/pm_pc8.c +1 -2
index 010af44..9a95326 100644
@@ -769,7 +769,7 @@ static void setup_environment(void)
      printf("Runtime PM support: %d\n", has_runtime_pm);
      printf("PC8 residency support: %d\n", has_pc8);
 
-     igt_require(has_runtime_pm || has_pc8);
+     igt_require(has_runtime_pm);
 }
 
 static void teardown_environment(void)
--

1.8.4

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

2014-04-28 15:22 GMT-03:00 Imre Deak <[email protected]>:

Quoted 6 lines · Paulo Zanoni
Quoted 5 lines

2014-04-25 5:08 GMT-03:00 Daniel Vetter <[email protected]>:

Quoted 3 lines · Imre Deak
Quoted 2 lines

The PC8 state won't be entered unless runtime PM is enabled, so support for PC8 residency counters alone is not enough to run this test.

Quoted 8 lines
Quoted 5 lines

This is true only for the very latest kernels. We have Kernels with PC8 support and without runtime PM support. Do you actually need this specific patch to solve any problems you're currently having? If not, maybe we could revert it so people with stable Kernels will be able to run IGT.

The following one needs this at least on BDW/current kernel:
https://bugs.freedesktop.org/show_bug.cgi?id=77565

This is not a fix to the bug. By skipping the whole test suite, this patch is just hiding the fact that PC8 doesn't work on BDW. Yes, PC8 on BDW (specifically) won't work without runtime PM, but that's not true for HSW on some Kernels. The proper fix to the bug above is to fix RC6 on BDW, or revert the revert.

Quoted 54 lines

I might be wrong, but I thought we don't need backward compatibility in igt. We could also make the check kernel version dependent, I'm not sure if it's worth the effort.

--Imre

Quoted 45 lines

Thanks,
Paulo

Quoted 38 lines
Quoted 2 lines
Quoted 20 lines
---
 tests/pm_pc8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/pm_pc8.c +1 -2
index 010af44..9a95326 100644
@@ -769,7 +769,7 @@ static void setup_environment(void)
      printf("Runtime PM support: %d\n", has_runtime_pm);
      printf("PC8 residency support: %d\n", has_pc8);
 
-     igt_require(has_runtime_pm || has_pc8);
+     igt_require(has_runtime_pm);
 }
 
 static void teardown_environment(void)
--

1.8.4

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 1 line
Paulo Zanoni
author
#5 lore raw
Quoted 13 lines · Paulo Zanoni

2014-04-28 15:22 GMT-03:00 Imre Deak <[email protected]>:

Quoted 12 lines · Paulo Zanoni
Quoted 10 lines

2014-04-25 5:08 GMT-03:00 Daniel Vetter <[email protected]>:

Quoted 3 lines · Imre Deak
Quoted 2 lines

The PC8 state won't be entered unless runtime PM is enabled, so support for PC8 residency counters alone is not enough to run this test.

This is true only for the very latest kernels. We have Kernels with PC8 support and without runtime PM support. Do you actually need this specific patch to solve any problems you're currently having? If not, maybe we could revert it so people with stable Kernels will be able to run IGT.

Quoted 8 lines
Quoted 2 lines

The following one needs this at least on BDW/current kernel:
https://bugs.freedesktop.org/show_bug.cgi?id=77565

This is not a fix to the bug. By skipping the whole test suite, this patch is just hiding the fact that PC8 doesn't work on BDW. Yes, PC8 on BDW (specifically) won't work without runtime PM, but that's not true for HSW on some Kernels. The proper fix to the bug above is to fix RC6 on BDW, or revert the revert.

The igt patch is not supposed to fix the issue, but it is correct for new kernels on all platforms. In case runtime PM is disabled - for example because it didn't get enabled in the first place or because RC6 is force disabled through a module option - the test should be skipped.

--Imre

Quoted 58 lines
Quoted 55 lines

I might be wrong, but I thought we don't need backward compatibility in igt. We could also make the check kernel version dependent, I'm not sure if it's worth the effort.

--Imre

Quoted 45 lines

Thanks,
Paulo

Quoted 38 lines
Quoted 2 lines
Quoted 20 lines
---
 tests/pm_pc8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/pm_pc8.c +1 -2
index 010af44..9a95326 100644
@@ -769,7 +769,7 @@ static void setup_environment(void)
      printf("Runtime PM support: %d\n", has_runtime_pm);
      printf("PC8 residency support: %d\n", has_pc8);
 
-     igt_require(has_runtime_pm || has_pc8);
+     igt_require(has_runtime_pm);
 }
 
 static void teardown_environment(void)
--

1.8.4

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#6 lore raw
In reply to Paulo Zanoni
Quoted 13 lines · Paulo Zanoni

2014-04-28 15:22 GMT-03:00 Imre Deak <[email protected]>:

Quoted 12 lines · Paulo Zanoni
Quoted 10 lines

2014-04-25 5:08 GMT-03:00 Daniel Vetter <[email protected]>:

Quoted 3 lines · Imre Deak
Quoted 2 lines

The PC8 state won't be entered unless runtime PM is enabled, so support for PC8 residency counters alone is not enough to run this test.

This is true only for the very latest kernels. We have Kernels with PC8 support and without runtime PM support. Do you actually need this specific patch to solve any problems you're currently having? If not, maybe we could revert it so people with stable Kernels will be able to run IGT.

Quoted 8 lines
Quoted 2 lines

The following one needs this at least on BDW/current kernel:
https://bugs.freedesktop.org/show_bug.cgi?id=77565

This is not a fix to the bug. By skipping the whole test suite, this patch is just hiding the fact that PC8 doesn't work on BDW. Yes, PC8 on BDW (specifically) won't work without runtime PM, but that's not true for HSW on some Kernels. The proper fix to the bug above is to fix RC6 on BDW, or revert the revert.

Note that recently we made RC6 a requirement for runtime PM, so fixing it is the only option for re-enabling runtime PM.

Quoted 56 lines
Quoted 53 lines

I might be wrong, but I thought we don't need backward compatibility in igt. We could also make the check kernel version dependent, I'm not sure if it's worth the effort.

--Imre

Quoted 45 lines

Thanks,
Paulo

Quoted 38 lines
Quoted 2 lines
Quoted 20 lines
---
 tests/pm_pc8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/pm_pc8.c +1 -2
index 010af44..9a95326 100644
@@ -769,7 +769,7 @@ static void setup_environment(void)
      printf("Runtime PM support: %d\n", has_runtime_pm);
      printf("PC8 residency support: %d\n", has_pc8);
 
-     igt_require(has_runtime_pm || has_pc8);
+     igt_require(has_runtime_pm);
 }
 
 static void teardown_environment(void)
--

1.8.4

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx