Skip to contentSkip to conversation

net/designware: ensure device private data is DMA aligned.

PATCH In review Ian Campbell 1 participant 1 message Apr 28, 2014 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 net/designware: ensure device private data is DMA aligned.

struct dw_eth_dev contains fields which are accessed via DMA, so make sure it is aligned to a dma boundary. Without this I see:

    ERROR: v7_dcache_inval_range - start address is not aligned - 0x7fb677e0

---
v2: Sign of with my own mail not my work mail. I made these changes on my own time, but a .gitconfig vcsh mismerge caused "git commit -s" to use the wrong thing. (I wondered why everyone was CCing me at work...)

---
 drivers/net/designware.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/designware.c +2 -1
index 9824b42..b70df82 100644
@@ -414,7 +414,8 @@ int designware_initialize(ulong base_addr, u32 interface)
 	 * Since the priv structure contains the descriptors which need a strict
 	 * buswidth alignment, memalign is used to allocate memory
 	 */
-	priv = (struct dw_eth_dev *) memalign(16, sizeof(struct dw_eth_dev));
+	priv = (struct dw_eth_dev *) memalign(ARCH_DMA_MINALIGN,
+					      sizeof(struct dw_eth_dev));
 	if (!priv) {
 		free(dev);
 		return -ENOMEM;
Signature · 1 line
1.9.0