i40e: fix passing wrong error code to i40e_open()
Subsystems (3)
PATCH 1/1 i40e: fix passing wrong error code to i40e_open()
The commit 6c167f582ea9 ("i40e: Refactor and cleanup i40e_open(), adding i40e_vsi_open()") introduced a new function i40e_vsi_open() with the regression by a typo. Due to the commit, the wrong error code would be passed to i40e_open(). Fix this error in i40e_vsi_open() by turning the macro into a negative value so that i40e_open() could return the pertinent error code correctly.
---
3.14 appears to be affected. Petition for -stable.
drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/i40e/i40e_main.c +1 -1
@@ -4310,7 +4310,7 @@ int i40e_vsi_open(struct i40e_vsi *vsi) goto err_setup_rx;if (!vsi->netdev) { - err =EINVAL ; + err = -EINVAL ; goto err_setup_rx; } snprintf(int_name, sizeof(int_name) - 1, "%s-%s",
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available. Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
Quoted 8 lines · Jean Sacren
The commit
6c167f582ea9("i40e: Refactor and cleanupi40e_open(), addingi40e_vsi_open()") introduced a new functioni40e_vsi_open()with the regression by a typo. Due to the commit, the wrong error code would be passed toi40e_open(). Fix this error ini40e_vsi_open()by turning the macro into a negative value so thati40e_open()could return the pertinent error code correctly.Fixes 6c167f582ea9 ("i40e: Refactor and cleanup i40e_open(), adding
Quoted 8 lines
i40e_vsi_open()")Signed-off-by Jean Sacren <[email protected]>Cc Elizabeth Kappler <[email protected]>---
3.14 appears to be affected. Petition for -stable.drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks Jean, I have added it to my queue.