batman-adv: increase orig refcount when storing ref in gw_node

PATCH Superseded Antonio Quartulli 1 participant 1 message May 1, 2014

lore

Share & tools

lore

Antonio Quartulli

author

2014-05-01 22:16 UTC #0 lore raw

PATCH 1/1 batman-adv: increase orig refcount when storing ref in gw_node

From: Antonio Quartulli <[email protected]>

A pointer to the orig_node representing a bat-gateway is stored in the gw_node->orig_node member, but the refcount for such orig_node is never increased.
This leads to memory faults when gw_node->orig_node is accessed and the originator has already been freed.

Fix this by increasing the refcount on gw_node creation and decreasing it on gw_node free.

Signed-off-by Antonio Quartulli <[email protected]>

---
 gateway_client.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

gateway_client.c +6 -1

index d7fafc1..cfaa2fc 100644
@@ -42,8 +42,10 @@
 
 static void batadv_gw_node_free_ref(struct batadv_gw_node *gw_node)
 {
-	if (atomic_dec_and_test(&gw_node->refcount))
+	if (atomic_dec_and_test(&gw_node->refcount)) {
+		batadv_orig_node_free_ref(gw_node->orig_node);
 		kfree_rcu(gw_node, rcu);
+	}
 }
 
 static struct batadv_gw_node *

@@ -406,6 +408,9 @@ static void batadv_gw_node_add(struct batadv_priv *bat_priv,
 	if (gateway->bandwidth_down == 0)
 		return;
 
+	if (!atomic_inc_not_zero(&orig_node->refcount))
+		return;
+
 	gw_node = kzalloc(sizeof(*gw_node), GFP_ATOMIC);
 	if (!gw_node)
 		return;

Signature · 1 line

1.8.3.2