libata-sff: remove dead code
PATCH 1/1 libata-sff: remove dead code
Ever since v2.6.19 the code contains a check for CONFIG_NO_ATA_LEGACY. But that macro has never been defined. Apparently no one ran into problems on platforms that do not support compatibility mode. So remove this code that has been dead for over seven years.
---
Untested!
Perhaps the test should have been
#if !defined(CONFIG_PATA_LEGACY)
I wouldn't know if that's correct. But after seven years it doesn't matter anyhow, so I did not bother to research that.
drivers/ata/libata-sff.c | 9 --------- 1 file changed, 9 deletions(-)
drivers/ata/libata-sff.c +0 -9
@@ -2433,15 +2433,6 @@ int ata_pci_sff_activate_host(struct ata_host *host, mask = (1 <<2 ) | (1 <<0 );if ((tmp8 & mask) != mask) legacy_mode =1 ; -#if defined(CONFIG_NO_ATA_LEGACY ) -/* Some platforms with PCI limits cannot address compat -port space. In that case we punt if their firmware has -left a device in compatibility mode */ -if (legacy_mode) { -printk (KERN_ERR "ata: Compatibility mode ATA is not supported on this platform, skipping.\n" ); -return -EOPNOTSUPP ; - } -#endif }if (!devres_open_group (dev,NULL ,GFP_KERNEL ))
Signature · 1 line
1.9.0
Quoted 3 lines · Paul Bolle
Ever since v2.6.19 the code contains a check for
CONFIG_NO_ATA_LEGACY. But that macro has never been defined. Apparently no one ran into problems on platforms that do not support compatibility mode.
It was needed for some of the FRV devices I belive. Please check with David Howells if it's still relevant (even if its not used in the default configs)
Alan
[Added David.]
Quoted 7 lines · Alan Cox
Quoted 3 lines · Paul Bolle
Ever since v2.6.19 the code contains a check for
CONFIG_NO_ATA_LEGACY. But that macro has never been defined. Apparently no one ran into problems on platforms that do not support compatibility mode.It was needed for some of the FRV devices I belive. Please check with David Howells if it's still relevant
This code has been behind (effectively) an "#if 0" check for seven years. So either there was no problem to begin with, the problem is fixed somewhere else, or no one is actually using the affected devices. So I doubt this is still relevant. But maybe David thinks otherwise...
Quoted 1 line
(even if its not used in the default configs)
It's not used (and has never been used) regardless which config one tries.
Paul Bolle
Quoted 8 lines
Quoted 2 lines
It was needed for some of the FRV devices I belive. Please check with David Howells if it's still relevant
This code has been behind (effectively) an "#if 0" check for seven years. So either there was no problem to begin with, the problem is fixed somewhere else, or no one is actually using the affected devices. So I doubt this is still relevant. But maybe David thinks otherwise...
Quoted 4 lines
Quoted 1 line
(even if its not used in the default configs)
It's not used (and has never been used) regardless which config one tries.
Unless you are editing the config with out of tree changes. Which is possible which is why I said ask Dave. It's probably fine but best to be safe.
Alan
Quoted 3 lines · Alan Cox
Unless you are editing the config with out of tree changes. Which is possible which is why I said ask Dave. It's probably fine but best to be safe.
If you mean adding a "config NO_ATA_LEGACY" entry to some Kconfig file, and setting that symbol during "make *config", that will obviously work.
But if you mean (hand) editing the .config, that wouldn't work, as the line for CONFIG_NO_ATA_LEGACY would be dropped during "make *config", wouldn't it?
Paul Bolle