Skip to contentSkip to conversation

leds: lp55xx: add DT bindings for LP55231

PATCH In review Daniel Mack 3 participants 3 messages May 5, 2014 – May 8, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: lp55xx: add DT bindings for LP55231

The TI55231 appears to be fully compatible to the 5523 model from National Semicondutor. This patch just adds DT bindings for it.

---
 Documentation/devicetree/bindings/leds/leds-lp55xx.txt | 8 +++++++-
 drivers/leds/leds-lp5523.c                             | 3 ++-
 2 files changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/leds/leds-lp55xx.txt +7 -1
index c55b8c0..1b66a41 100644
@@ -1,7 +1,13 @@
 Binding for TI/National Semiconductor LP55xx Led Drivers
 
 Required properties:
-- compatible: "national,lp5521" or "national,lp5523" or "ti,lp5562" or "ti,lp8501"
+- compatible: one of
+	national,lp5521
+	national,lp5523
+	ti,lp55231
+	ti,lp5562
+	ti,lp8501
+
 - reg: I2C slave address
 - clock-mode: Input clock mode, (0: automode, 1: internal, 2: external)
 
drivers/leds/leds-lp5523.c +2 -1
index 4ade66a..7e46f57 100644
@@ -1,5 +1,5 @@
 /*
- * lp5523.c - LP5523 LED Driver
+ * lp5523.c - LP5523, LP55231 LED Driver
  *
  * Copyright (C) 2010 Nokia Corporation
  * Copyright (C) 2012 Texas Instruments
@@ -815,6 +815,7 @@ MODULE_DEVICE_TABLE(i2c, lp5523_id);
 #ifdef CONFIG_OF
 static const struct of_device_id of_lp5523_leds_match[] = {
 	{ .compatible = "national,lp5523", },
+	{ .compatible = "ti,lp55231", },
 	{},
 };
 
Signature · 1 line
1.9.0
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Daniel Mack

The TI55231 appears to be fully compatible to the 5523 model from National Semicondutor. This patch just adds DT bindings for it.

Thanks!
You got a good point. Vendor name is correct because LP55231 was released not by National but by TI.

Best regards,
Milo

#2 lore raw
Quoted 10 lines · Milo Kim
Quoted 5 lines · Daniel Mack

The TI55231 appears to be fully compatible to the 5523 model from National Semicondutor. This patch just adds DT bindings for it.

Applied with Milo's ACK,
Thanks,
-Bryan

Quoted 8 lines

Thanks!
You got a good point. Vendor name is correct because LP55231 was released not by National but by TI.

Best regards,
Milo