Skip to contentSkip to conversation

libdrm: Fix drm.h include in qxl drm header file

PATCH In review Andreas Boll 2 participants 4 messages May 5, 2014 – Jul 28, 2014 DRM drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libdrm: Fix drm.h include in qxl drm header file

Use "drm.h" instead of "drm/drm.h" as used in the other header files. Fixes xserver-xorg-video-qxl build with KMS support on Debian, where this file is installed in /usr/include/libdrm.

Fixes Debian bug #746807

---
 include/drm/qxl_drm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/drm/qxl_drm.h +1 -1
index 5d7de70..1e331a8 100644
@@ -25,7 +25,7 @@
 #define QXL_DRM_H
 
 #include <stddef.h>
-#include "drm/drm.h"
+#include "drm.h"
 
 /* Please note that modifications to all structs defined here are
  * subject to backwards-compatibility constraints.
Signature · 1 line
1.9.2
#1 lore raw

ping

2014-05-05 23:54 GMT+02:00 Andreas Boll <[email protected]>:

Quoted 28 lines

Use "drm.h" instead of "drm/drm.h" as used in the other header files. Fixes xserver-xorg-video-qxl build with KMS support on Debian, where this file is installed in /usr/include/libdrm.

Fixes Debian bug #746807

---
 include/drm/qxl_drm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/drm/qxl_drm.h +1 -2
index 5d7de70..1e331a8 100644
@@ -25,7 +25,7 @@
 #define QXL_DRM_H
 
 #include <stddef.h>
-#include "drm/drm.h"
+#include "drm.h"
 
 /* Please note that modifications to all structs defined here are
  * subject to backwards-compatibility constraints.
--

1.9.2

Reviewed-by
#2 lore raw
Quoted 7 lines · Andreas Boll

ping

2014-05-05 23:54 GMT+02:00 Andreas Boll <[email protected]>:

Quoted 4 lines

Use "drm.h" instead of "drm/drm.h" as used in the other header files. Fixes xserver-xorg-video-qxl build with KMS support on Debian, where this file is installed in /usr/include/libdrm.

I believe that's the default location for most linux distributions. Seems like not many of us build the qxl ddx :\

FWIW

Quoted 29 lines
Quoted 22 lines

Fixes Debian bug #746807

---
 include/drm/qxl_drm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/drm/qxl_drm.h +1 -2
index 5d7de70..1e331a8 100644
@@ -25,7 +25,7 @@
 #define QXL_DRM_H
 
 #include <stddef.h>
-#include "drm/drm.h"
+#include "drm.h"
 
 /* Please note that modifications to all structs defined here are
  * subject to backwards-compatibility constraints.
--
Quoted 2 lines

1.9.2

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

2014-07-28 17:06 GMT+02:00 Emil Velikov <[email protected]>:

Quoted 8 lines · Andreas Boll
Quoted 7 lines

ping

2014-05-05 23:54 GMT+02:00 Andreas Boll <[email protected]>:

Quoted 4 lines

Use "drm.h" instead of "drm/drm.h" as used in the other header files. Fixes xserver-xorg-video-qxl build with KMS support on Debian, where this file is installed in /usr/include/libdrm.

Quoted 6 lines

I believe that's the default location for most linux distributions. Seems like not many of us build the qxl ddx :\

FWIW

Thanks!
Pushed.

Quoted 30 lines
Quoted 29 lines
Quoted 22 lines

Fixes Debian bug #746807

---
 include/drm/qxl_drm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/drm/qxl_drm.h +1 -2
index 5d7de70..1e331a8 100644
@@ -25,7 +25,7 @@
 #define QXL_DRM_H
 
 #include <stddef.h>
-#include "drm/drm.h"
+#include "drm.h"
 
 /* Please note that modifications to all structs defined here are
  * subject to backwards-compatibility constraints.
--
Quoted 2 lines

1.9.2

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel