Skip to contentSkip to conversation

Fixing Coding style Warnings in file drivers/staging/comedi/drivers/das08.h

PATCH In review Sheetal Tigadoli 2 participants 2 messages May 6, 2014 – May 7, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fixing Coding style Warnings in file drivers/staging/comedi/drivers/das08.h

This patch fixes coding style warnings such as 'lines exceeding 80 characters limit' & 'lines begining with space character', in file drivers/staging/comedi/drivers/das08.h

This patch is sent to complete one of Eudyptula Challenges

---
 drivers/staging/comedi/drivers/das08.h |   56 +++++++++++++++++---------------
 1 file changed, 30 insertions(+), 26 deletions(-)
drivers/staging/comedi/drivers/das08.h +30 -26
index 2a30d76..741b36b 100644
@@ -1,25 +1,24 @@
 /*
-    das08.h
-
-    Header for das08.c and das08_cs.c
-
-    Copyright (C) 2003 Frank Mori Hess <[email protected]>
-
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-
-*/
+ *  das08.h
+ *
+ *  Header for das08.c and das08_cs.c
+ *
+ *  Copyright (C) 2003 Frank Mori Hess <[email protected]>
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program; if not, write to the Free Software
+ *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
 
 #ifndef _DAS08_H
 #define _DAS08_H
@@ -50,7 +49,8 @@ struct das08_board_struct {
 };
 
 struct i8254_struct {
-	int channels;		/*  available channels. Some could be used internally. */
+	int channels;		/*  available channels. Some could be used
+				    internally. */
 	int logic2phys[3];	/*  to know which physical channel is. */
 	int mode[3];		/*  the index is the real counter. */
 	unsigned int iobase;
@@ -62,11 +62,15 @@ struct i8254_struct {
 #define I8254_CTRL 3
 
 struct das08_private_struct {
-	unsigned int do_mux_bits;	/*  bits for do/mux register on boards without separate do register */
-	unsigned int do_bits;	/*  bits for do register on boards with register dedicated to digital out only */
+	unsigned int do_mux_bits;	/*  bits for do/mux register on boards
+					    without separate do register */
+	unsigned int do_bits;		/*  bits for do register on boards
+					    with register dedicated to digital
+					    out only */
 	const unsigned int *pg_gainlist;
-	struct pci_dev *pdev;	/*  struct for pci-das08 */
-	unsigned int pci_iobase;	/*  additional base address for pci-das08 */
+	struct pci_dev *pdev;		/*  struct for pci-das08 */
+	unsigned int pci_iobase;	/*  additional base address for
+					    pci-das08 */
 	struct i8254_struct i8254;
 };
 
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 2 lines · Sheetal Tigadoli

This patch fixes coding style warnings such as 'lines exceeding 80 characters limit' & 'lines begining with space character', in file drivers/staging/comedi/drivers/das08.h

This is poor patch subject style.
Please use "[PATCH] subsystem: description" style.

Quoted 1 line

This patch is sent to complete one of Eudyptula Challenges

Please do not include any "Eudyptula Challenge" line in the commit log.

drivers/staging/comedi/drivers/das08.h

Quoted 1 line
drivers/staging/comedi/drivers/das08.h +0 -0

[]

drivers/staging/comedi/drivers/das08.h struct das08_board_struct { · line 51

Quoted 5 lines
drivers/staging/comedi/drivers/das08.h +2 -1
@@ -50,7 +49,8 @@ struct das08_board_struct {
 struct i8254_struct {
-	int channels;		/*  available channels. Some could be used internally. */
+	int channels;		/*  available channels. Some could be used
+				    internally. */

Multiline comment style should use

	/*
	 * comment lines
	 * ...
	 */