Skip to contentSkip to conversation

attr: Fix uclibc builds

PATCH In review Richard Purdie 2 participants 4 messages May 6, 2014

lore
Share & tools
lore

Richard Purdie

author
#0 lore raw

PATCH 1/1 attr: Fix uclibc builds

attr needs libintl headers and libs. Add in the missing dependency and the missing linker flag.

Signed-off-by Richard Purdie <[email protected]>

---

meta/recipes-support/attr/attr.inc +3 -1
index 873c1ff..63964e75 100644
@@ -2,7 +2,7 @@ SUMMARY = "Utilities for manipulating filesystem extended attributes"
 HOMEPAGE = "http://savannah.nongnu.org/projects/attr/"
 SECTION = "libs"
 
-DEPENDS = "ncurses"
+DEPENDS = "ncurses virtual/libintl"
 
 LICENSE = "LGPLv2.1+ & GPLv2+"
 LICENSE_${PN} = "GPLv2+"

@@ -17,6 +17,8 @@ SRC_URI = "http://download.savannah.gnu.org/releases/attr/${BP}.src.tar.gz \
 
 require ea-acl.inc
 
+LDFLAGS_append_libc-uclibc = " -lintl"
+
 # libdir should point to .la
 do_install_append() {
 	sed -i ${D}${libdir}/libattr.la -e \
#1 lore raw

Richard

Quoted 10 lines · Richard Purdie

attr needs libintl headers and libs. Add in the missing dependency and the missing linker flag.

Signed-off-by Richard Purdie <[email protected]>

---

meta/recipes-support/attr/attr.inc +0 -0
index 873c1ff..63964e75 100644

meta/recipes-support/attr/attr.inc SUMMARY = "Utilities for manipulating filesystem extended attributes" · line 6

Quoted 6 lines
meta/recipes-support/attr/attr.inc +1 -1
@@ -2,7 +2,7 @@ SUMMARY = "Utilities for manipulating filesystem extended attributes"
 HOMEPAGE = "http://savannah.nongnu.org/projects/attr/"
 SECTION = "libs"
 
-DEPENDS = "ncurses"
+DEPENDS = "ncurses virtual/libintl"

may be something like
http://git.openembedded.org/openembedded-core-contrib/commit/?h=kraj/musl&id=6c67b40e4784e12ed6a71ab4696710b913e55455

is needed here.

Secondly we already have

LDFLAGS_append_libc-uclibc = "${@['', ' -lintl '][(d.getVar('PN', True) == d.getVar('BPN', True)) and (d.getVar('USE_NLS', True) == 'yes')]}"

in ea-acl.inc

Quoted 18 lines
meta/recipes-support/attr/attr.inc +2 -1
 LICENSE = "LGPLv2.1+ & GPLv2+"
 LICENSE_${PN} = "GPLv2+"

@@ -17,6 +17,8 @@ SRC_URI = "http://download.savannah.gnu.org/releases/attr/${BP}.src.tar.gz \
 
 require ea-acl.inc
 
+LDFLAGS_append_libc-uclibc = " -lintl"
+
 # libdir should point to .la
 do_install_append() {
        sed -i ${D}${libdir}/libattr.la -e \
 
 
--

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#2 lore raw
Quoted 27 lines · Khem Raj

Richard

Quoted 10 lines · Richard Purdie

attr needs libintl headers and libs. Add in the missing dependency and the missing linker flag.

Signed-off-by Richard Purdie <[email protected]>

---

meta/recipes-support/attr/attr.inc +0 -0
index 873c1ff..63964e75 100644

meta/recipes-support/attr/attr.inc SUMMARY = "Utilities for manipulating filesystem extended attributes" · line 6

Quoted 6 lines
meta/recipes-support/attr/attr.inc +1 -1
@@ -2,7 +2,7 @@ SUMMARY = "Utilities for manipulating filesystem extended attributes"
 HOMEPAGE = "http://savannah.nongnu.org/projects/attr/"
 SECTION = "libs"
 
-DEPENDS = "ncurses"
+DEPENDS = "ncurses virtual/libintl"

may be something like
http://git.openembedded.org/openembedded-core-contrib/commit/?h=kraj/musl&id=6c67b40e4784e12ed6a71ab4696710b913e55455

is needed here.

Quoted 7 lines

Secondly we already have

LDFLAGS_append_libc-uclibc = "${@['', ' -lintl '][(d.getVar('PN', True) == d.getVar('BPN', True)) and (d.getVar('USE_NLS', True) == 'yes')]}"

in ea-acl.inc

Hmm, I hadn't seen that. The trouble is that I'm setting up uclibc as a multilib and this conditional may be wrong, we may need to rethink the PN == BPN as it isn't in the multilib case.

Cheers,

Richard

#3 lore raw
Quoted 1 line · Richard Purdie

PN == BPN as it isn't in the multilib case.

we may not need that any more since back than we did not differentiate between native and target recipes.