net: davinci_mdio: Use of_mdiobus_register()
Subsystems (3)
PATCH 1/1 net: davinci_mdio: Use of_mdiobus_register()
of_mdiobus_register() calls mdiobus_register() internally, so the functionality is preserved. However, by calling the of_ variant, phy nodes can be augmented with extra information.
--- drivers/net/ethernet/ti/davinci_mdio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/ti/davinci_mdio.c +2 -1
@@ -38,6 +38,7 @@#include <linux/davinci_emac.h> #include <linux/of.h> #include <linux/of_device.h> +#include <linux/of_mdio.h> #include <linux/pinctrl/consumer.h> /*
@@ -389,7 +390,7 @@ static int davinci_mdio_probe(struct platform_device *pdev) }/* register the mii bus */ - ret =mdiobus_register (data->bus); + ret =of_mdiobus_register (data->bus, dev->of_node);if (ret) goto bail_out;
Signature · 1 line
1.9.0
Hi,
2014-05-06 8:18 GMT-07:00 Daniel Mack <[email protected]>:
Quoted 3 lines
of_mdiobus_register()callsmdiobus_register()internally, so the functionality is preserved. However, by calling theof_variant, phy nodes can be augmented with extra information.
Are there any non Device Tree aware platforms using this driver? of_mdiobus_register() is an empty stub returning -ENOSYS when CONFIG_OF is not set, maybe we should make it return mdiobus_register() instead...
Quoted 34 lines
Signed-off-by Daniel Mack <[email protected]>--- drivers/net/ethernet/ti/davinci_mdio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/net/ethernet/ti/davinci_mdio.c +2
-2@@ -38,6 +38,7 @@#include <linux/davinci_emac.h> #include <linux/of.h> #include <linux/of_device.h> +#include <linux/of_mdio.h> #include <linux/pinctrl/consumer.h> /* @@ -389,7 +390,7 @@ static int davinci_mdio_probe(struct platform_device *pdev) }/* register the mii bus */ - ret =mdiobus_register (data->bus); + ret =of_mdiobus_register (data->bus, dev->of_node);if (ret) goto bail_out; --1.9.0
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 1 line
Florian
Quoted 9 lines · Florian Fainelli
2014-05-06 8:18 GMT-07:00 Daniel Mack <[email protected]>:
Quoted 3 lines
of_mdiobus_register()callsmdiobus_register()internally, so the functionality is preserved. However, by calling theof_variant, phy nodes can be augmented with extra information.Are there any non Device Tree aware platforms using this driver?
of_mdiobus_register()is an empty stub returning-ENOSYSwhenCONFIG_OFis not set, maybe we should make it returnmdiobus_register()instead...
Ah, good point. Yes, what you propose seems like a valid fix. I'll send a patch for that.
Thanks,
Daniel