Skip to contentSkip to conversation

pvpanic: Set high notifier priority

PATCH New Takashi Iwai 1 participant 1 message May 6, 2014 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pvpanic: Set high notifier priority

We've observed the missing pvpanic call at panic, and it turned out that this was blocked by the broken notifier of drm_fb_helper, where scheduling may be called during switching to the fb console. It's fairly difficult to fix the drm_fb problem and a quick fix isn't foreseen, a simpler solution for the missing pvpanic call would be just to call this earlier.

In order to assure that, this patch sets a higher priority to pvpanic notifier_block. Once when the issue of drm_fb is resolved, we can remove this priority again.

---
 drivers/platform/x86/pvpanic.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/pvpanic.c +1 -0
index c9f6e511daa6..073a90a63dbc 100644
@@ -70,6 +70,7 @@ pvpanic_panic_notify(struct notifier_block *nb, unsigned long code,
 
 static struct notifier_block pvpanic_panic_nb = {
 	.notifier_call = pvpanic_panic_notify,
+	.priority = 1, /* let this called before broken drm_fb_helper */
 };
 
 
Signature · 1 line
1.9.2