Skip to contentSkip to conversation

ifplugd: Added ifplugd recipe.

PATCH In review Søren Holm 3 participants 5 messages May 7, 2014 – May 8, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ifplugd: Added ifplugd recipe.

---
 .../ifplugd/files/ifplugd.conf                     | 42 ++++++++++++++++++++++
 .../recipes-connectivity/ifplugd/ifplugd_0.28.bb   | 23 ++++++++++++
 2 files changed, 65 insertions(+)
 create mode 100644 meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf
 create mode 100644 meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb
meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file +42 -0
new file mode 100644
index 0000000..1e0f83a
@@ -0,0 +1,42 @@
+# -*-sh-*-
+# $Id: ifplugd.conf 43 2003-09-13 11:25:11Z lennart $
+
+# This file is part of ifplugd.
+#
+# ifplugd is free software; you can redistribute it and/or modify it under
+# the terms of the GNU General Public License as published by the Free
+# Software Foundation; either version 2 of the License, or (at your
+# option) any later version.
+#
+# ifplugd is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+# for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with ifplugd; if not, write to the Free Software Foundation,
+# Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
+
+# ifplugd configuration file
+
+# Please note that this is a bourne shell fragment sourced by the
+# init script of ifplugd.
+
+# Specify the interfaces to control here, separated by spaces.
+# Ifplugd processes will be started for each of these interfaces when
+# the ifplugd init script is called with the "start" argument. You may
+# use the magic string "auto" to make the init script start or stop
+# ifplugd processes for ALL eth and wlan interfaces that are available
+# according to /proc/net/dev. Note that the list of interfaces
+# appearing in /proc/net/dev may depend on which kernel modules you
+# have loaded.
+INTERFACES="eth0"
+
+# Additional parameters for ifplugd.
+# (Run "ifplugd -h" for further information.)
+ARGS="-fwI -u0 -d10"
+
+# Additional parameters for ifplugd for the specified interface.  Note
+# that $ARGS is ignored, when a variable like this is set for an
+# interface
+#ARGS_wlan0="-MwI -u5 -d5"
meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file +23 -0
new file mode 100644
index 0000000..340d5f4
@@ -0,0 +1,23 @@
+DESCRIPTION = "Daemon for monitoring ethernet device link state"
+SRC_URI     = "http://0pointer.de/lennart/projects/ifplugd/ifplugd-0.28.tar.gz \
+               file://ifplugd.conf"
+DEPENDS     = "libdaemon"
+LICENSE     = "GPLv2"
+
+LIC_FILES_CHKSUM = "file://LICENSE;md5=94d55d512a9ba36caa9b7df079bae19f"
+
+SRC_URI[md5sum] = "df6f4bab52f46ffd6eb1f5912d4ccee3"
+SRC_URI[sha256sum] = "474754ac4ab32d738cbf2a4a3e87ee0a2c71b9048a38bdcd7df1e4f9fd6541f0"
+
+EXTRA_OECONF_append = "--disable-lynx"
+
+
+INITSCRIPT_PACKAGES = "${PN}"
+INITSCRIPT_NAME_${PN} = "${PN}"
+INITSCRIPT_PARAMS_${PN} = "defaults 90"
+
+do_install_append() {
+	install -m 644 ${WORKDIR}/ifplugd.conf ${D}${sysconfdir}/ifplugd/
+}
+
+inherit autotools update-rc.d
\ No newline at end of file
Signature · 1 line
1.9.1
#1 lore raw

Hi Søren,

So leaving aside that ifplugd is completely dead upstream, a few small pieces of feedback on the recipe:

Quoted 65 lines · On Wednesday 07 May 2014 11:26:17 Søren Holm wrote:
---
 .../ifplugd/files/ifplugd.conf                     | 42
++++++++++++++++++++++ .../recipes-connectivity/ifplugd/ifplugd_0.28.bb   |
23 ++++++++++++ 2 files changed, 65 insertions(+)
 create mode 100644

meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf create mode 100644 meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb

(quoted diff) +0 -0

b/meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file mode 100644
index 0000000..1e0f83a

meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file +42 -0
@@ -0,0 +1,42 @@
+# -*-sh-*-
+# $Id: ifplugd.conf 43 2003-09-13 11:25:11Z lennart $
+
+# This file is part of ifplugd.
+#
+# ifplugd is free software; you can redistribute it and/or modify it under
+# the terms of the GNU General Public License as published by the Free
+# Software Foundation; either version 2 of the License, or (at your
+# option) any later version.
+#
+# ifplugd is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+# for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with ifplugd; if not, write to the Free Software Foundation,
+# Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
+
+# ifplugd configuration file
+
+# Please note that this is a bourne shell fragment sourced by the
+# init script of ifplugd.
+
+# Specify the interfaces to control here, separated by spaces.
+# Ifplugd processes will be started for each of these interfaces when
+# the ifplugd init script is called with the "start" argument. You may
+# use the magic string "auto" to make the init script start or stop
+# ifplugd processes for ALL eth and wlan interfaces that are available
+# according to /proc/net/dev. Note that the list of interfaces
+# appearing in /proc/net/dev may depend on which kernel modules you
+# have loaded.
+INTERFACES="eth0"
+
+# Additional parameters for ifplugd.
+# (Run "ifplugd -h" for further information.)
+ARGS="-fwI -u0 -d10"
+
+# Additional parameters for ifplugd for the specified interface.  Note
+# that $ARGS is ignored, when a variable like this is set for an
+# interface
+#ARGS_wlan0="-MwI -u5 -d5"
(quoted diff) +0 -0

b/meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file mode 100644
index 0000000..340d5f4

meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb line 1

Quoted 1 line
meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file +1 -0
@@ -0,0 +1,23 @@
+DESCRIPTION = "Daemon for monitoring ethernet device link state"

Please use SUMMARY instead of DESCRIPTION of a

meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb line 5

Quoted 5 lines
meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file +1 -0
+SRC_URI     =

"http://0pointer.de/lennart/projects/ifplugd/ifplugd-0.28.tar.gz \ +
file://ifplugd.conf"

meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file +2 -0
+DEPENDS     = "libdaemon"
+LICENSE     = "GPLv2"

Please don't indent the values here. Also SRC_URI should be after DEPENDS and the license fields (before the SRC_URI checksums).

BTW, looking at the ifplugd recipe we have in OE-Classic, do we need the patches we had there?

http://cgit.openembedded.org/openembedded/tree/recipes/ifplugd

Quoted 5 lines
meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file +4 -0
+LIC_FILES_CHKSUM = "file://LICENSE;md5=94d55d512a9ba36caa9b7df079bae19f"
+
+SRC_URI[md5sum] = "df6f4bab52f46ffd6eb1f5912d4ccee3"
+SRC_URI[sha256sum] =

"474754ac4ab32d738cbf2a4a3e87ee0a2c71b9048a38bdcd7df1e4f9fd6541f0" +

meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb line 21

Quoted 10 lines
meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file +10 -0
+EXTRA_OECONF_append = "--disable-lynx"
+
+
+INITSCRIPT_PACKAGES = "${PN}"
+INITSCRIPT_NAME_${PN} = "${PN}"
+INITSCRIPT_PARAMS_${PN} = "defaults 90"
+
+do_install_append() {
+	install -m 644 ${WORKDIR}/ifplugd.conf ${D}${sysconfdir}/ifplugd/
+}

Again, referring to the ifplugd recipe from OE-Classic we probably need a CONFFILES line to point to the conf file you're installing.

Quoted 1 line

+inherit autotools update-rc.d

Typically the inherit line should be higher than this.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#2 lore raw
Quoted 74 lines · On Wednesday 07 May 2014 11:34:23 Paul Eggleton wrote:

Hi Søren,

So leaving aside that ifplugd is completely dead upstream, a few small pieces of feedback on the recipe:

Quoted 68 lines · On Wednesday 07 May 2014 11:26:17 Søren Holm wrote:

---

 .../ifplugd/files/ifplugd.conf                     | 42

++++++++++++++++++++++ .../recipes-connectivity/ifplugd/ifplugd_0.28.bb |
23 ++++++++++++ 2 files changed, 65 insertions(+)

 create mode 100644

meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf create mode
100644 meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb

diff --git a/meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf b/meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file mode 100644
index 0000000..1e0f83a

meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file +6 -0
@@ -0,0 +1,42 @@
+# -*-sh-*-
+# $Id: ifplugd.conf 43 2003-09-13 11:25:11Z lennart $
+
+# This file is part of ifplugd.
+#
+# ifplugd is free software; you can redistribute it and/or modify it

under

meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file +36 -0
+# the terms of the GNU General Public License as published by the Free
+# Software Foundation; either version 2 of the License, or (at your
+# option) any later version.
+#
+# ifplugd is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+# for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with ifplugd; if not, write to the Free Software Foundation,
+# Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
+
+# ifplugd configuration file
+
+# Please note that this is a bourne shell fragment sourced by the
+# init script of ifplugd.
+
+# Specify the interfaces to control here, separated by spaces.
+# Ifplugd processes will be started for each of these interfaces when
+# the ifplugd init script is called with the "start" argument. You may
+# use the magic string "auto" to make the init script start or stop
+# ifplugd processes for ALL eth and wlan interfaces that are available
+# according to /proc/net/dev. Note that the list of interfaces
+# appearing in /proc/net/dev may depend on which kernel modules you
+# have loaded.
+INTERFACES="eth0"
+
+# Additional parameters for ifplugd.
+# (Run "ifplugd -h" for further information.)
+ARGS="-fwI -u0 -d10"
+
+# Additional parameters for ifplugd for the specified interface.  Note
+# that $ARGS is ignored, when a variable like this is set for an
+# interface
+#ARGS_wlan0="-MwI -u5 -d5"
(quoted diff) +0 -0

b/meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file

Quoted 8 lines

meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb line 1

Quoted 6 lines

mode 100644
index 0000000..340d5f4

meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file +1 -0
@@ -0,0 +1,23 @@
+DESCRIPTION = "Daemon for monitoring ethernet device link state"

Please use SUMMARY instead of DESCRIPTION of a

Sorry, that should have been "Please use SUMMARY instead of DESCRIPTION for a short description like this".

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#3 lore raw

Thanks for the feedback Paul

Are there a document stating the "best pratice" sequence of lines in recipes?

that said I might have been grabing the recipe from OE-Classic. Before posting this patch I tried to find the recipe on layers.openembedded.org without luck.

But just skip the patch - connman is the way to go I guess.

Onsdag den 7. maj 2014 11:43:40 skrev Paul Eggleton:

Quoted 91 lines · On Wednesday 07 May 2014 11:34:23 Paul Eggleton wrote:
Quoted 76 lines

Hi Søren,

So leaving aside that ifplugd is completely dead upstream, a few small pieces of feedback on the recipe:

Quoted 70 lines · On Wednesday 07 May 2014 11:26:17 Søren Holm wrote:

---

 .../ifplugd/files/ifplugd.conf                     | 42

++++++++++++++++++++++ .../recipes-connectivity/ifplugd/ifplugd_0.28.bb

23 ++++++++++++ 2 files changed, 65 insertions(+)

 create mode 100644

meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf create mode
100644 meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb

diff --git a/meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf b/meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file mode 100644
index 0000000..1e0f83a

meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file +6 -0
@@ -0,0 +1,42 @@
+# -*-sh-*-
+# $Id: ifplugd.conf 43 2003-09-13 11:25:11Z lennart $
+
+# This file is part of ifplugd.
+#
+# ifplugd is free software; you can redistribute it and/or modify it

under

meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file +5 -0
+# the terms of the GNU General Public License as published by the Free
+# Software Foundation; either version 2 of the License, or (at your
+# option) any later version.
+#
+# ifplugd is distributed in the hope that it will be useful, but

WITHOUT

meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file +31 -0
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+# for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with ifplugd; if not, write to the Free Software Foundation,
+# Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
+
+# ifplugd configuration file
+
+# Please note that this is a bourne shell fragment sourced by the
+# init script of ifplugd.
+
+# Specify the interfaces to control here, separated by spaces.
+# Ifplugd processes will be started for each of these interfaces when
+# the ifplugd init script is called with the "start" argument. You may
+# use the magic string "auto" to make the init script start or stop
+# ifplugd processes for ALL eth and wlan interfaces that are available
+# according to /proc/net/dev. Note that the list of interfaces
+# appearing in /proc/net/dev may depend on which kernel modules you
+# have loaded.
+INTERFACES="eth0"
+
+# Additional parameters for ifplugd.
+# (Run "ifplugd -h" for further information.)
+ARGS="-fwI -u0 -d10"
+
+# Additional parameters for ifplugd for the specified interface.  Note
+# that $ARGS is ignored, when a variable like this is set for an
+# interface
+#ARGS_wlan0="-MwI -u5 -d5"

diff --git a/meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb b/meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file

Quoted 8 lines

meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb line 1

Quoted 6 lines

mode 100644
index 0000000..340d5f4

meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file +1 -0
@@ -0,0 +1,23 @@
+DESCRIPTION = "Daemon for monitoring ethernet device link state"

Please use SUMMARY instead of DESCRIPTION of a

Sorry, that should have been "Please use SUMMARY instead of DESCRIPTION for a short description like this".

Cheers,
Paul

Signature · 1 line
Søren Holm
#4 lore raw

Hi Søren,

Quoted 3 lines · Søren Holm

Thanks for the feedback Paul

Are there a document stating the "best pratice" sequence of lines in recipes?

I usually refer to Openembedded Styleguide at [1]. It also links to a similar page on Yocto's site.

[1] http://www.openembedded.org/wiki/Styleguide

Quoted 107 lines

that said I might have been grabing the recipe from OE-Classic. Before posting this patch I tried to find the recipe on layers.openembedded.org without luck.

But just skip the patch - connman is the way to go I guess.

Onsdag den 7. maj 2014 11:43:40 skrev Paul Eggleton:

Quoted 86 lines · On Wednesday 07 May 2014 11:34:23 Paul Eggleton wrote:
Quoted 76 lines

Hi Søren,

So leaving aside that ifplugd is completely dead upstream, a few small pieces of feedback on the recipe:

Quoted 70 lines · On Wednesday 07 May 2014 11:26:17 Søren Holm wrote:

---

 .../ifplugd/files/ifplugd.conf                     | 42

++++++++++++++++++++++ .../recipes-connectivity/ifplugd/ifplugd_0.28.bb

23 ++++++++++++ 2 files changed, 65 insertions(+)

 create mode 100644

meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf create mode
100644 meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb

diff --git a/meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf b/meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file mode 100644
index 0000000..1e0f83a

meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file +6 -0
@@ -0,0 +1,42 @@
+# -*-sh-*-
+# $Id: ifplugd.conf 43 2003-09-13 11:25:11Z lennart $
+
+# This file is part of ifplugd.
+#
+# ifplugd is free software; you can redistribute it and/or modify it

under

meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file +5 -0
+# the terms of the GNU General Public License as published by the Free
+# Software Foundation; either version 2 of the License, or (at your
+# option) any later version.
+#
+# ifplugd is distributed in the hope that it will be useful, but

WITHOUT

meta-networking/recipes-connectivity/ifplugd/files/ifplugd.conf new file +31 -0
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+# for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with ifplugd; if not, write to the Free Software Foundation,
+# Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
+
+# ifplugd configuration file
+
+# Please note that this is a bourne shell fragment sourced by the
+# init script of ifplugd.
+
+# Specify the interfaces to control here, separated by spaces.
+# Ifplugd processes will be started for each of these interfaces when
+# the ifplugd init script is called with the "start" argument. You may
+# use the magic string "auto" to make the init script start or stop
+# ifplugd processes for ALL eth and wlan interfaces that are available
+# according to /proc/net/dev. Note that the list of interfaces
+# appearing in /proc/net/dev may depend on which kernel modules you
+# have loaded.
+INTERFACES="eth0"
+
+# Additional parameters for ifplugd.
+# (Run "ifplugd -h" for further information.)
+ARGS="-fwI -u0 -d10"
+
+# Additional parameters for ifplugd for the specified interface.  Note
+# that $ARGS is ignored, when a variable like this is set for an
+# interface
+#ARGS_wlan0="-MwI -u5 -d5"

diff --git a/meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb b/meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file

Quoted 8 lines

meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb line 1

Quoted 6 lines

mode 100644
index 0000000..340d5f4

meta-networking/recipes-connectivity/ifplugd/ifplugd_0.28.bb new file +1 -0
@@ -0,0 +1,23 @@
+DESCRIPTION = "Daemon for monitoring ethernet device link state"

Please use SUMMARY instead of DESCRIPTION of a

Quoted 5 lines

Sorry, that should have been "Please use SUMMARY instead of DESCRIPTION for a short description like this".

Cheers,
Paul

--
Søren Holm
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel