Skip to contentSkip to conversation

staging : android: Fixes a coding style issue in timed_gpio.c

PATCH In review John Church 2 participants 3 messages May 7, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging : android: Fixes a coding style issue in timed_gpio.c

This patch fixes a coding style issue for a line that was over 80 characters long.

---
 drivers/staging/android/timed_gpio.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/android/timed_gpio.c +2 -2
index f7d124d..180c209 100644
@@ -92,8 +92,8 @@ static int timed_gpio_probe(struct platform_device *pdev)
 		return -EBUSY;
 
 	gpio_data = devm_kzalloc(&pdev->dev,
-				sizeof(struct timed_gpio_data) * pdata->num_gpios,
-				GFP_KERNEL);
+			sizeof(struct timed_gpio_data) * pdata->num_gpios,
+			GFP_KERNEL);
 	if (!gpio_data)
 		return -ENOMEM;
 
Signature · 1 line
1.7.10.4
Reviewed-by on v1 1/1
#1 lore raw

I wonder if there is some kind of tutorial which teaches people to choose the least specific subject possible? We should find which tutorial it is and update it. John, can you give us a hint here which tutorial you are using?

Quoted 3 lines · John Church

This patch fixes a coding style issue for a line that was over 80 characters long.

Anyway, looks ok.

regards,
dan carpenter

#2 lore raw
Quoted 4 lines · Dan Carpenter

I wonder if there is some kind of tutorial which teaches people to choose the least specific subject possible? We should find which tutorial it is and update it. John, can you give us a hint here which tutorial you are using?

I'm doing the Eudyptula Challenge. Task 10 is to fix a coding style issue and submit it the relevant maintainers.

Quoted 13 lines · John Church
Quoted 3 lines

This patch fixes a coding style issue for a line that was over 80 characters long.

Anyway, looks ok.

regards,
dan carpenter

Thanks for your advice Dan. I've setup git send-email and mutt now so I could test the patch properly before sending.

Regards,
John