virtio_scsi: remove ACCESS_ONCE() in virtscsi_pick_vq

PATCH In review Ming Lei 1 participant 1 message May 7, 2014

Subsystems (2)

SCSI virtio block and SCSI drivers

lore

Share & tools

lore

Ming Lei

author

2014-05-07 14:13 UTC #0 lore raw

PATCH 1/2 virtio_scsi: remove ACCESS_ONCE() in virtscsi_pick_vq

Access to tgt->req_vq is strictly serialized by spin_lock of tgt->tgt_lock, so the ACCESS_ONCE() isn't necessary.

Cc Paolo Bonzini <[email protected]>

Signed-off-by Ming Lei <[email protected]>

---
 drivers/scsi/virtio_scsi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/scsi/virtio_scsi.c +1 -1

index 16bfd50..aead20f 100644
@@ -565,7 +565,7 @@ static struct virtio_scsi_vq *virtscsi_pick_vq(struct virtio_scsi *vscsi,
 	 * the smp_read_barrier_depends() in virtscsi_req_done.
 	 */
 	if (atomic_inc_return(&tgt->reqs) > 1)
-		vq = ACCESS_ONCE(tgt->req_vq);
+		vq = tgt->req_vq;
 	else {
 		queue_num = smp_processor_id();
 		while (unlikely(queue_num >= vscsi->num_queues))

Signature · 1 line

1.7.9.5