staging: wlags49_h2: fix sparse warning "should it be static"

PATCH In review Luis Ortega 2 participants 2 messages May 7, 2014 – May 23, 2014 Staging

Share & tools

Luis Ortega

author

2014-05-07 14:32 UTC #0 lore raw

PATCH 1/1 staging: wlags49_h2: fix sparse warning "should it be static"

Fixes the following warning:
drivers/staging/wlags49_h2/sta_h2.c:4471:10: warning: symbol 'fw_image' was not declared. Should it be static?

Signed-off-by Luis Ortega <[email protected]>

---
 drivers/staging/wlags49_h2/sta_h2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/wlags49_h2/sta_h2.c +1 -1

index 0ba8def..2838faa 100644
@@ -4468,7 +4468,7 @@ static const CFG_RANGE20_STRCT fw_image_infocompat[] = {
 	{ 0000, 0000, 0000, 0000, { { 0000, 0000, 0000 } } }	/* endsentinel */
 };
 
-memimage fw_image = {
+static memimage fw_image = {
 	"FUPU7D37dhfwci\001C",			/* signature, <format number>, C/Bin type */
 	(CFG_PROG_STRCT *) fw_image_code,
 	0x000F368E,

--
1.9.2

Greg KH

maintainer

2014-05-23 18:50 UTC #1 lore raw

Quoted 13 lines · Luis Ortega

Fixes the following warning:
drivers/staging/wlags49_h2/sta_h2.c:4471:10: warning: symbol 'fw_image' was not declared. Should it be static?
Signed-off-by Luis Ortega <[email protected]>
---
 drivers/staging/wlags49_h2/sta_h2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wlags49_h2/sta_h2.c +0 -0
index 0ba8def..2838faa 100644

drivers/staging/wlags49_h2/sta_h2.c static const CFG_RANGE20_STRCT fw_image_infocompat[] = { · line 4474

Quoted 8 lines

drivers/staging/wlags49_h2/sta_h2.c +1 -1

@@ -4468,7 +4468,7 @@ static const CFG_RANGE20_STRCT fw_image_infocompat[] = {
 	{ 0000, 0000, 0000, 0000, { { 0000, 0000, 0000 } } }	/* endsentinel */
 };
 
-memimage fw_image = {
+static memimage fw_image = {
 	"FUPU7D37dhfwci\001C",			/* signature, <format number>, C/Bin type */
 	(CFG_PROG_STRCT *) fw_image_code,
 	0x000F368E,

ALWAYS test build your patches. This patch breaks the build :(

greg k-h