staging: winbond: use dev_err() instead of printk()
PATCH 1/1 staging: winbond: use dev_err() instead of printk()
For obvious error messages, use dev_err() in order to provide userspace with more useful information and use the common kernel coding style.
---
this applies to v3.15-rc4
greetings from Linuxdays Vienna, Austria
drivers/staging/winbond/wb35tx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/winbond/wb35tx.c +3 -3
@@ -49,7 +49,7 @@ static void Wb35Tx_complete(struct urb *pUrb)/* The URB is completed, check the result */ if (pWb35Tx->EP4VM_status !=0 ) { -printk ("URB submission failed\n" ); +dev_err (&pUrb->dev->dev,"URB submission failed\n" ); pWb35Tx->EP4vm_state =VM_STOP ; goto error; }
@@ -96,7 +96,7 @@ static void Wb35Tx(struct wbsoft_priv *adapter) pWb35Tx->EP4vm_state =VM_RUNNING ; retv =usb_submit_urb (pUrb,GFP_ATOMIC );if (retv <0 ) { -printk ("EP4 Tx Irp sending error\n" ); +dev_err (&pUrb->dev->dev,"EP4 Tx Irp sending error\n" ); goto cleanup; }
@@ -218,7 +218,7 @@ static void Wb35Tx_EP2VM_complete(struct urb *pUrb)/* The Urb is completed, check the result */ if (pWb35Tx->EP2VM_status !=0 ) { -printk ("EP2 IoCompleteRoutine return error\n" ); +dev_err (&pUrb->dev->dev,"EP2 IoCompleteRoutine return error\n" ); pWb35Tx->EP2vm_state =VM_STOP ; goto error; }
Signature · 1 line
1.7.10.4
Quoted 7 lines · Martin Kepplinger
For obvious error messages, use
dev_err()in order to provide userspace with more useful information and use the common kernel coding style.Signed-off-by Martin Kepplinger <[email protected]>---
this applies to v3.15-rc4
Do these kinds of patches against linux-next. This patch applies fine so it's not a worry.
regards,
dan carpenter
Quoted 3 lines · Martin Kepplinger
For obvious error messages, use
dev_err()in order to provide userspace with more useful information and use the common kernel coding style.
PATCH RESEND 1/1 staging: winbond: use dev_err() instead of printk()
For obvious error messages, use dev_err() in order to provide userspace with more useful information and use the common kernel coding style.
---
i just waited a week or so. this applies to next-20140516.
greetings from Linuxdays Vienna, Austria
drivers/staging/winbond/wb35tx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/winbond/wb35tx.c +3 -3
@@ -49,7 +49,7 @@ static void Wb35Tx_complete(struct urb *pUrb)/* The URB is completed, check the result */ if (pWb35Tx->EP4VM_status !=0 ) { -printk ("URB submission failed\n" ); +dev_err (&pUrb->dev->dev,"URB submission failed\n" ); pWb35Tx->EP4vm_state =VM_STOP ; goto error; }
@@ -96,7 +96,7 @@ static void Wb35Tx(struct wbsoft_priv *adapter) pWb35Tx->EP4vm_state =VM_RUNNING ; retv =usb_submit_urb (pUrb,GFP_ATOMIC );if (retv <0 ) { -printk ("EP4 Tx Irp sending error\n" ); +dev_err (&pUrb->dev->dev,"EP4 Tx Irp sending error\n" ); goto cleanup; }
@@ -218,7 +218,7 @@ static void Wb35Tx_EP2VM_complete(struct urb *pUrb)/* The Urb is completed, check the result */ if (pWb35Tx->EP2VM_status !=0 ) { -printk ("EP2 IoCompleteRoutine return error\n" ); +dev_err (&pUrb->dev->dev,"EP2 IoCompleteRoutine return error\n" ); pWb35Tx->EP2vm_state =VM_STOP ; goto error; }
Signature · 1 line
1.7.10.4
Quoted 6 lines · Martin Kepplinger
For obvious error messages, use
dev_err()in order to provide userspace with more useful information and use the common kernel coding style.Signed-off-by Martin Kepplinger <[email protected]>---
i just waited a week or so. this applies to next-20140516.
A week is too short a time. You will always get a message that your patch was either applied or dropped.
Quoted 2 lines
greetings from Linuxdays Vienna, Austria
Hi hi. Greetings from Africa. :)
regards,
dan carpenter