Skip to contentSkip to conversation

weston: add lcms, libpoppler-glib dependenies

PATCH In review Tim Orling 3 participants 8 messages May 9, 2014 – May 10, 2014

lore
Share & tools
lore

Tim Orling

author
#0 lore raw

PATCH 1/1 weston: add lcms, libpoppler-glib dependenies

From: Tim Orling <[email protected]>

fixes for JaMa test-dependencies build (oe-core-contrib/jansa/daisy-backports)

---
 meta/recipes-graphics/wayland/weston_1.4.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/wayland/weston_1.4.0.bb +1 -1
index 5213166..abacb58 100644
@@ -16,7 +16,7 @@ SRC_URI[sha256sum] = "74a2319d98e9cdb1acf24659699719aa89ac268cf549759271e326edc5
 inherit autotools pkgconfig useradd
 
 DEPENDS = "libxkbcommon gdk-pixbuf pixman cairo glib-2.0 jpeg"
-DEPENDS += "wayland virtual/egl pango"
+DEPENDS += "wayland virtual/egl pango lcms libpoppler-glib"
 
 EXTRA_OECONF = "--enable-setuid-install \
                 --disable-xwayland \
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 1 line · Tim Orling

+DEPENDS += "wayland virtual/egl pango lcms libpoppler-glib"

For a start libpoppler isn't in oe-core, so this causes a build failure for everyone not using meta-oe.

These are for the basic test applications: I'd prefer to see a patch that either forcibly disabled the checks or added configure options so the dependencies can be controlled.

Ross

#2 lore raw
Quoted 9 lines · Ross
Quoted 1 line · Tim Orling

+DEPENDS += "wayland virtual/egl pango lcms libpoppler-glib"

For a start libpoppler isn't in oe-core, so this causes a build failure for everyone not using meta-oe.

These are for the basic test applications: I'd prefer to see a patch that either forcibly disabled the checks or added configure options so the dependencies can be controlled.

FWIW: I've sent WIP patch a while ago, but never finished it
http://patchwork.openembedded.org/patch/57011/

IIRC it doesn't apply to current version now.

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw
Quoted 11 lines · Martin Jansa
Quoted 6 lines

For a start libpoppler isn't in oe-core, so this causes a build failure for everyone not using meta-oe.

These are for the basic test applications: I'd prefer to see a patch that either forcibly disabled the checks or added configure options so the dependencies can be controlled.

FWIW: I've sent WIP patch a while ago, but never finished it
http://patchwork.openembedded.org/patch/57011/

IIRC it doesn't apply to current version now.

If definitely doesn't apply to master: weston doesn't check for poppler anymore as the PDF viewer was removed.

LCMS should have an explicit with/without as it is used for colour management in the server.

Ross

author
#4 lore raw

Consider this patch DOA. I'll try over the weekend to apply a more appropriate fix, unless someone else wants to jump in. There are plenty of other packages on the list :)

Quoted 21 lines · Ross
Quoted 11 lines · Martin Jansa
Quoted 6 lines

For a start libpoppler isn't in oe-core, so this causes a build failure for everyone not using meta-oe.

These are for the basic test applications: I'd prefer to see a patch that either forcibly disabled the checks or added configure options so the dependencies can be controlled.

FWIW: I've sent WIP patch a while ago, but never finished it
http://patchwork.openembedded.org/patch/57011/

IIRC it doesn't apply to current version now.

If definitely doesn't apply to master: weston doesn't check for poppler anymore as the PDF viewer was removed.

LCMS should have an explicit with/without as it is used for colour management in the server.

Ross

#5 lore raw
In reply to Burton, Ross
Quoted 8 lines · Ross
Quoted 7 lines · Martin Jansa
Quoted 6 lines

For a start libpoppler isn't in oe-core, so this causes a build failure for everyone not using meta-oe.

These are for the basic test applications: I'd prefer to see a patch that either forcibly disabled the checks or added configure options so the dependencies can be controlled.

Quoted 7 lines
Quoted 4 lines

FWIW: I've sent WIP patch a while ago, but never finished it
http://patchwork.openembedded.org/patch/57011/

IIRC it doesn't apply to current version now.

If definitely doesn't apply to master: weston doesn't check for poppler anymore as the PDF viewer was removed.

Something still links with it as shows in test-dependencies reports:

weston/weston/latest lost dependency on lcms weston/weston-examples/latest lost dependency on libpoppler-glib

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
author
#6 lore raw

From upstream:
clients: Drop pdf viewer sample client
http://cgit.freedesktop.org/wayland/weston/commit/?id=a72d37566780ab8abab235cd21817733962cb1e1

Quoted 25 lines · Martin Jansa
Quoted 8 lines · Ross
Quoted 7 lines · Martin Jansa
Quoted 6 lines

For a start libpoppler isn't in oe-core, so this causes a build failure for everyone not using meta-oe.

These are for the basic test applications: I'd prefer to see a patch that either forcibly disabled the checks or added configure options so the dependencies can be controlled.

Quoted 7 lines
Quoted 4 lines

FWIW: I've sent WIP patch a while ago, but never finished it
http://patchwork.openembedded.org/patch/57011/

IIRC it doesn't apply to current version now.

If definitely doesn't apply to master: weston doesn't check for poppler anymore as the PDF viewer was removed.

Something still links with it as shows in test-dependencies reports:

weston/weston/latest lost dependency on lcms weston/weston-examples/latest lost dependency on libpoppler-glib

--
Martin 'JaMa' Jansa jabber: [email protected]

#7 lore raw
In reply to Martin Jansa
Quoted 4 lines · Martin Jansa

Something still links with it as shows in test-dependencies reports:

weston/weston/latest lost dependency on lcms weston/weston-examples/latest lost dependency on libpoppler-glib

Sorry, I meant weston master, not oe-core master.

Ross