cpufreq: powernv: make local function static

PATCH Applied Brian Norris 5 participants 5 messages May 11, 2014 – May 19, 2014

Subsystems (2)

PowerPC CPU frequency scaling framework

lore

Share & tools

lore

Brian Norris

author

2014-05-11 07:51 UTC #0 lore raw

PATCH 1/1 cpufreq: powernv: make local function static

powernv_cpufreq_get() is only referenced in this file.

Signed-off-by Brian Norris <[email protected]>

Cc Viresh Kumar <[email protected]>

Cc Rafael J. Wysocki <[email protected]>

Cc [email protected]

---
 drivers/cpufreq/powernv-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/cpufreq/powernv-cpufreq.c +1 -1

index af4968813e76..bb1d08dc8cc8 100644
@@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg)
  * firmware for CPU 'cpu'. This value is reported through the sysfs
  * file cpuinfo_cur_freq.
  */
-unsigned int powernv_cpufreq_get(unsigned int cpu)
+static unsigned int powernv_cpufreq_get(unsigned int cpu)
 {
 	struct powernv_smp_call_data freq_data;

Signature · 1 line

1.9.1

Srivatsa S. Bhat

Reviewed-by on v1 1/1

2014-05-11 18:32 UTC #1 lore raw

Quoted 7 lines · Brian Norris

powernv_cpufreq_get() is only referenced in this file.
Signed-off-by Brian Norris <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc Rafael J. Wysocki <[email protected]>
Cc [email protected]
Cc [email protected]

Reviewed-by Srivatsa S. Bhat <[email protected]>

Regards,
Srivatsa S. Bhat

Quoted 17 lines

---
 drivers/cpufreq/powernv-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/cpufreq/powernv-cpufreq.c +1 -1

index af4968813e76..bb1d08dc8cc8 100644
@@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg)
  * firmware for CPU 'cpu'. This value is reported through the sysfs
  * file cpuinfo_cur_freq.
  */
-unsigned int powernv_cpufreq_get(unsigned int cpu)
+static unsigned int powernv_cpufreq_get(unsigned int cpu)
 {
 	struct powernv_smp_call_data freq_data;

Gautham R Shenoy

Reviewed-by

2014-05-12 05:54 UTC #2 lore raw

Quoted 10 lines · Srivatsa S. Bhat

Quoted 7 lines · Brian Norris
powernv_cpufreq_get() is only referenced in this file.
Signed-off-by Brian Norris <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc Rafael J. Wysocki <[email protected]>
Cc [email protected]
Cc [email protected]
Reviewed-by Srivatsa S. Bhat <[email protected]>

Thanks for this fix Brian.

Reviewed-by Gautham R. Shenoy <[email protected]>

--
Thanks and Regards
gautham.

Quoted 21 lines

Regards,
Srivatsa S. Bhat

Quoted 17 lines

---
 drivers/cpufreq/powernv-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/cpufreq/powernv-cpufreq.c +1 -1

index af4968813e76..bb1d08dc8cc8 100644
@@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg)
  * firmware for CPU 'cpu'. This value is reported through the sysfs
  * file cpuinfo_cur_freq.
  */
-unsigned int powernv_cpufreq_get(unsigned int cpu)
+static unsigned int powernv_cpufreq_get(unsigned int cpu)
 {
 	struct powernv_smp_call_data freq_data;

Rafael J. Wysocki

Applied

2014-05-19 23:21 UTC #3 lore raw

Quoted 10 lines · Gautham R Shenoy

Quoted 9 lines · Srivatsa S. Bhat
Quoted 7 lines · Brian Norris
powernv_cpufreq_get() is only referenced in this file.
Signed-off-by Brian Norris <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc Rafael J. Wysocki <[email protected]>
Cc [email protected]
Cc [email protected]

Quoted 5 lines

Quoted 1 line
Reviewed-by Srivatsa S. Bhat <[email protected]>
Thanks for this fix Brian.
Reviewed-by Gautham R. Shenoy <[email protected]>

Queued up for 3.16, thanks!

Quoted 31 lines

--
Thanks and Regards
gautham.
Quoted 8 lines
Regards,
Srivatsa S. Bhat
Quoted 4 lines
---
 drivers/cpufreq/powernv-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines
drivers/cpufreq/powernv-cpufreq.c static void powernv_read_cpu_freq(void *arg) · line 241
Quoted 13 lines
drivers/cpufreq/powernv-cpufreq.c +1 -1
index af4968813e76..bb1d08dc8cc8 100644
@@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg)
  * firmware for CPU 'cpu'. This value is reported through the sysfs
  * file cpuinfo_cur_freq.
  */
-unsigned int powernv_cpufreq_get(unsigned int cpu)
+static unsigned int powernv_cpufreq_get(unsigned int cpu)
 {
 	struct powernv_smp_call_data freq_data;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines

I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Viresh Kumar

maintainer Acked-by on v1 1/1

2014-05-12 04:24 UTC #4 lore raw

In reply to Brian Norris

Quoted 16 lines · Brian Norris

powernv_cpufreq_get() is only referenced in this file.
Signed-off-by Brian Norris <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc Rafael J. Wysocki <[email protected]>
Cc [email protected]
Cc [email protected]
---
 drivers/cpufreq/powernv-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/powernv-cpufreq.c +0 -0
index af4968813e76..bb1d08dc8cc8 100644

drivers/cpufreq/powernv-cpufreq.c static void powernv_read_cpu_freq(void *arg) · line 238

Quoted 5 lines

drivers/cpufreq/powernv-cpufreq.c +1 -1

@@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg)
  * firmware for CPU 'cpu'. This value is reported through the sysfs
  * file cpuinfo_cur_freq.
  */
-unsigned int powernv_cpufreq_get(unsigned int cpu)
+static unsigned int powernv_cpufreq_get(unsigned int cpu)

Please make this as static as well: cpufreq_freq_attr_cpuinfo_nominal_freq

and add my

Acked-by Viresh Kumar <[email protected]> on V2.