Skip to contentSkip to conversation

hwmon: (emc1403) Various enhancements

PATCH In review Guenter Roeck 2 participants 3 messages May 12, 2014 – May 13, 2014

lore
Share & tools
lore
#0 lore raw

cover hwmon: (emc1403) Various enhancements

See individual patches for details.

Patches apply on top of the previously submitted patches by Jean Delvare and Josef Gajdusek, which should be available in linux-next by tomorrow and are available in the hwmon-next branch of
git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git.

Caveat: Compile tested only, not ready for integration.
Especially min_hyst, max_hyst, and fault attributes need testing (not sure if I interpreted the datasheets correctly), but also alarm and fault attributes on EMC14x2. Plus of course the regmap conversion. I am sure I have a test board somewhere, but can't find it right now, so testing may take a bit. Josef, if you have time, would be great if you can give it a try.

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#2 lore raw

Review

Quoted 6 lines · Josef Gajdusek

Had to fix wrong variable being printed in show_bit(). After that, everything on the 1412 seems to work fine including alarms.

(quoted diff) +1 -1
-	return sprintf(buf, "%d\n", !!(retval & sda->index));
+	return sprintf(buf, "%d\n", !!(val & sda->index));

Hi Josef,

Fixed with v2. Thanks a lot for the feedback!

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors