Skip to contentSkip to conversation

drivers/clocksource: do not trace read_sched_clock

PATCH In review [email protected] 2 participants 4 messages May 13, 2014 – May 23, 2014 Clocksource, clockevent drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/clocksource: do not trace read_sched_clock

From: Yang Wei <[email protected]>

We do not need to trace read_sched_clock function, so add notrace attribute for this function.

---
 drivers/clocksource/dw_apb_timer_of.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/dw_apb_timer_of.c +1 -1
index 2a2ea27..d305fb0 100644
@@ -106,7 +106,7 @@ static void __init add_clocksource(struct device_node *source_timer)
 	sched_rate = rate;
 }
 
-static u64 read_sched_clock(void)
+static u64 notrace read_sched_clock(void)
 {
 	return ~__raw_readl(sched_io_base);
 }
Signature · 1 line
1.7.9.5
author
#1 lore raw

Hi Daniel,

What do you think of it?

Regards
Wei

Quoted 23 lines · On 05/13/2014 11:10 AM, [email protected] wrote:

From: Yang Wei <[email protected]>

We do not need to trace read_sched_clock function, so add notrace attribute for this function.

---
  drivers/clocksource/dw_apb_timer_of.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/dw_apb_timer_of.c +1 -1
index 2a2ea27..d305fb0 100644
@@ -106,7 +106,7 @@ static void __init add_clocksource(struct device_node *source_timer)
  	sched_rate = rate;
  }
 
-static u64 read_sched_clock(void)
+static u64 notrace read_sched_clock(void)
  {
  	return ~__raw_readl(sched_io_base);
  }
#2 lore raw
Quoted 11 lines · Yang,Wei

Hi Daniel,

What do you think of it?

Regards
Wei

Quoted 4 lines · On 05/13/2014 11:10 AM, [email protected] wrote:

From: Yang Wei <[email protected]>

We do not need to trace read_sched_clock function, so add notrace attribute for this function.

Hi Yang,

I agree with your patch. Applied in my tree for 3.16

Please in the future fix the subject name:

clocksource: [driver]: [A-Z]....

Thanks
-- Daniel

Quoted 20 lines
Quoted 19 lines
---
  drivers/clocksource/dw_apb_timer_of.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/dw_apb_timer_of.c +1 -1
index 2a2ea27..d305fb0 100644
@@ -106,7 +106,7 @@ static void __init add_clocksource(struct
 device_node *source_timer)
      sched_rate = rate;
  }
-static u64 read_sched_clock(void)
+static u64 notrace read_sched_clock(void)
  {
      return ~__raw_readl(sched_io_base);
  }
Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
author
#3 lore raw
Quoted 13 lines · Daniel Lezcano
Quoted 11 lines · Yang,Wei

Hi Daniel,

What do you think of it?

Regards
Wei

Quoted 4 lines · On 05/13/2014 11:10 AM, [email protected] wrote:

From: Yang Wei <[email protected]>

We do not need to trace read_sched_clock function, so add notrace attribute for this function.

Quoted 7 lines

Hi Yang,

I agree with your patch. Applied in my tree for 3.16

Please in the future fix the subject name:

clocksource: [driver]: [A-Z]....

Daniel, Got it. I would be careful next time:-)

Thanks
Wei

Quoted 26 lines

Thanks
-- Daniel

Quoted 20 lines
Quoted 19 lines
---
  drivers/clocksource/dw_apb_timer_of.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/dw_apb_timer_of.c +1 -1
index 2a2ea27..d305fb0 100644
@@ -106,7 +106,7 @@ static void __init add_clocksource(struct
 device_node *source_timer)
      sched_rate = rate;
  }
-static u64 read_sched_clock(void)
+static u64 notrace read_sched_clock(void)
  {
      return ~__raw_readl(sched_io_base);
  }