Skip to contentSkip to conversation

scripts/tags.sh: add regular expression replacement pattern for memcg

PATCH Jianyu Zhan 2 participants 2 messages May 13, 2014 – May 14, 2014

lore
Share & tools
lore
#0 lore raw

Hi, Prarit,

Quoted 3 lines
Quoted 1 line

Currently, no regular expression replacement pattern for PageCgroug*

^^^ *Cgroup*

Sorry for the typo, fixed. Thanks.

Quoted 8 lines
Quoted 3 lines

defined, which causes quite a few pain while reading code. Just get rid of it.

IMO the patch looks fine but can you fixup your changelog a little bit? I think the new "standard" has become an explanation and example of the problem, an explanation of what is wrong, and what you did to fix it (including an example of output if possible). That way we know what was changed and why :)

Yep, you are right. Rewrote the wording.
Would you mind signing your Reviewed-by if it is Ok? Thanks.

---<8---
Currently, while using ctags to read code, we would get stumbled on PageCgroup* symbols: no definition found. And it is quite dull to manually dig it out.

This patch adds regular expression replacement pattern for such symbols, like what have done for the PageXXX flag. It will teach ctags to find out the definition for us.

---
 scripts/tags.sh | 8 ++++++++
 1 file changed, 8 insertions(+)
scripts/tags.sh +8 -0
index f2c5b00..7d3ebfe 100755
@@ -187,6 +187,10 @@ exuberant()
 	--regex-c++='/TESTCLEARFLAG_FALSE\(([^,)]*).*/TestClearPage\1/' \
 	--regex-c++='/__TESTCLEARFLAG_FALSE\(([^,)]*).*/__TestClearPage\1/' \
 	--regex-c++='/_PE\(([^,)]*).*/PEVENT_ERRNO__\1/'		\
+	--regex-c++='/TESTPCGFLAG\(([^,)]*).*/PageCgroup\1/'		\
+	--regex-c++='/SETPCGFLAG\(([^,)]*).*/SetPageCgroup\1/'		\
+	--regex-c++='/CLEARPCGFLAG\(([^,)]*).*/ClearPageCgroup\1/'	\
+	--regex-c++='/TESTCLEARPCGFLAG\(([^,)]*).*/TestClearPageCgroup\1/' \
 	--regex-c='/PCI_OP_READ\((\w*).*[1-4]\)/pci_bus_read_config_\1/' \
 	--regex-c='/PCI_OP_WRITE\((\w*).*[1-4]\)/pci_bus_write_config_\1/' \
 	--regex-c='/DEFINE_(MUTEX|SEMAPHORE|SPINLOCK)\((\w*)/\2/v/'	\
@@ -244,6 +248,10 @@ emacs()
 	--regex='/__CLEARPAGEFLAG_NOOP(\([^,)]*\).*/__ClearPage\1/' \
 	--regex='/TESTCLEARFLAG_FALSE(\([^,)]*\).*/TestClearPage\1/' \
 	--regex='/__TESTCLEARFLAG_FALSE(\([^,)]*\).*/__TestClearPage\1/' \
+	--regex='/TESTPCGFLAG\(([^,)]*).*/PageCgroup\1/'	\
+	--regex='/SETPCGFLAG\(([^,)]*).*/SetPageCgroup\1/'	\
+	--regex='/CLEARPCGFLAG\(([^,)]*).*/ClearPageCgroup\1/'	\
+	--regex='/TESTCLEARPCGFLAG\(([^,)]*).*/TestClearPageCgroup\1/' \
 	--regex='/_PE(\([^,)]*\).*/PEVENT_ERRNO__\1/'		\
 	--regex='/PCI_OP_READ(\([a-z]*[a-z]\).*[1-4])/pci_bus_read_config_\1/' \
 	--regex='/PCI_OP_WRITE(\([a-z]*[a-z]\).*[1-4])/pci_bus_write_config_\1/'
Signature · 1 line
2.0.0-rc1
#1 lore raw
Quoted 9 lines · Jianyu Zhan

Currently, while using ctags to read code, we would get stumbled on PageCgroup* symbols: no definition found. And it is quite dull to manually dig it out.

This patch adds regular expression replacement pattern for such symbols, like what have done for the PageXXX flag. It will teach ctags to find out the definition for us.

Applied to kbuild.git#misc, thanks.

Michal