Skip to contentSkip to conversation

ufs: core: Add WB buffer resize support

PATCH Superseded Huan Tang 4 participants 12 messages Oct 28, 2024 – Apr 23, 2025

Subsystems (2)
lore
Share & tools
lore

Huan Tang

author
#0 lore raw

PATCH v3 1/1 ufs: core: Add WB buffer resize support

Support WB buffer resize function through sysfs, the host can obtain resize hint and resize status and enable the resize operation. To achieve this goals, three sysfs nodes have been added:
1. wb_toggle_buf_resize
2. wb_buf_resize_hint
3. wb_buf_resize_status

The detailed definition of the three nodes can be found in the sysfs documentation.

Changelog
===
v2 - > v3:
remove needless code:
drivers/ufs/core/ufs-sysfs.c:441:2:
index = ufshcd_wb_get_query_index(hba)

v1 - > v2:
remove unused variable "u8 index", drivers/ufs/core/ufs-sysfs.c:419:12: warning: variable 'index' set but not used.

v1

	https://lore.kernel.org/all/[email protected]/
v2
	https://lore.kernel.org/all/[email protected]/
---
 Documentation/ABI/testing/sysfs-driver-ufs | 52 ++++++++++++++++++++++
 drivers/ufs/core/ufs-sysfs.c               | 42 +++++++++++++++++
 drivers/ufs/core/ufshcd.c                  | 15 +++++++
 include/ufs/ufs.h                          |  5 ++-
 include/ufs/ufshcd.h                       |  1 +
 5 files changed, 114 insertions(+), 1 deletion(-)
Documentation/ABI/testing/sysfs-driver-ufs +52 -0
index 5fa6655aee84..dbaa84277801 100644
@@ -1559,3 +1559,55 @@ Description:
 		Symbol - HCMID. This file shows the UFSHCD manufacturer id.
 		The Manufacturer ID is defined by JEDEC in JEDEC-JEP106.
 		The file is read only.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/wb_toggle_buf_resize
+What:		/sys/bus/platform/devices/*.ufs/wb_toggle_buf_resize
+Date:		Qct 2024
+Contact:	Huan Tang <[email protected]>
+Description:
+		The host can decrease or increase the WriteBooster Buffer size by setting
+		this file.
+
+		======  ======================================
+		00h  Idle (There is no resize operation)
+		01h  Decrease WriteBooster Buffer Size
+		02h  Increase WriteBooster Buffer Size
+		Others  Reserved
+		======  ======================================
+
+		The file is write only.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_buf_resize_hint
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_buf_resize_hint
+Date:		Qct 2024
+Contact:	Huan Tang <[email protected]>
+Description:
+		wb_buf_resize_hint indicates hint information about which type of resize for
+		WriteBooster Buffer is recommended by the device.
+
+		======  ======================================
+		00h  Recommend keep the buffer size
+		01h  Recommend to decrease the buffer size
+		02h  Recommend to increase the buffer size
+		Others: Reserved
+		======  ======================================
+
+		The file is read only.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_buf_resize_status
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_buf_resize_status
+Date:		Qct 2024
+Contact:	Huan Tang <[email protected]>
+Description:
+		The host can check the Resize operation status of the WriteBooster Buffer
+		by reading this file.
+
+		======  ========================================
+		00h  Idle (resize operation is not issued)
+		01h  Resize operation in progress
+		02h  Resize operation completed successfully
+		03h  Resize operation general failure
+		Others  Reserved
+		======  ========================================
+
+		The file is read only.
drivers/ufs/core/ufs-sysfs.c +42 -0

72 lines not on this page · raw message

drivers/ufs/core/ufshcd.c +15 -0
index 630409187c10..c28915debab6 100644
@@ -6167,6 +6167,21 @@ static bool ufshcd_wb_need_flush(struct ufs_hba *hba)
 	return ufshcd_wb_presrv_usrspc_keep_vcc_on(hba, avail_buf);
 }
 
+int ufshcd_wb_toggle_buf_resize(struct ufs_hba *hba, u32 op)
+{
+	int ret;
+	u8 index;
+
+	index = ufshcd_wb_get_query_index(hba);
+	ret = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,
+				   QUERY_ATTR_IDN_WB_BUF_RESIZE_EN, index, 0, &op);
+	if (ret)
+		dev_err(hba->dev, "%s: Enable WB buf resize operation failed %d\n",
+			__func__, ret);
+
+	return ret;
+}
+
 static void ufshcd_rpm_dev_flush_recheck_work(struct work_struct *work)
 {
 	struct ufs_hba *hba = container_of(to_delayed_work(work),
include/ufs/ufs.h +4 -1
index e594abe5d05f..f737d98044ac 100644
@@ -181,7 +181,10 @@ enum attr_idn {
 	QUERY_ATTR_IDN_WB_BUFF_LIFE_TIME_EST    = 0x1E,
 	QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE        = 0x1F,
 	QUERY_ATTR_IDN_EXT_IID_EN		= 0x2A,
-	QUERY_ATTR_IDN_TIMESTAMP		= 0x30
+	QUERY_ATTR_IDN_TIMESTAMP		= 0x30,
+	QUERY_ATTR_IDN_WB_BUF_RESIZE_HINT	= 0x3C,
+	QUERY_ATTR_IDN_WB_BUF_RESIZE_EN		= 0x3D,
+	QUERY_ATTR_IDN_WB_BUF_RESIZE_STATUS	= 0x3E,
 };
 
 /* Descriptor idn for Query requests */
include/ufs/ufshcd.h +1 -0
index a95282b9f743..cbe208ce9293 100644
@@ -1454,6 +1454,7 @@ int ufshcd_advanced_rpmb_req_handler(struct ufs_hba *hba, struct utp_upiu_req *r
 				     struct scatterlist *sg_list, enum dma_data_direction dir);
 int ufshcd_wb_toggle(struct ufs_hba *hba, bool enable);
 int ufshcd_wb_toggle_buf_flush(struct ufs_hba *hba, bool enable);
+int ufshcd_wb_toggle_buf_resize(struct ufs_hba *hba, u32 op);
 int ufshcd_suspend_prepare(struct device *dev);
 int __ufshcd_suspend_prepare(struct device *dev, bool rpm_ok_for_spm);
 void ufshcd_resume_complete(struct device *dev);
Signature · 1 line
2.39.0
#1 lore raw
Quoted 6 lines · Huan Tang
Documentation/ABI/testing/sysfs-driver-ufs +6 -0
+What:		/sys/bus/platform/drivers/ufshcd/*/wb_toggle_buf_resize
+What:		/sys/bus/platform/devices/*.ufs/wb_toggle_buf_resize
+Date:		Qct 2024
+Contact:	Huan Tang <[email protected]>
+Description:
+		The host can decrease or increase the WriteBooster Buffer size by setting

Documentation/ABI/testing/sysfs-driver-ufs Description: · line 1578

Quoted 10 lines
Documentation/ABI/testing/sysfs-driver-ufs +10 -0
+		this file.
+
+		======  ======================================
+		00h  Idle (There is no resize operation)
+		01h  Decrease WriteBooster Buffer Size
+		02h  Increase WriteBooster Buffer Size
+		Others  Reserved
+		======  ======================================
+
+		The file is write only.

The name "wb_toggle_buf_resize" is not clear and will make users guess what the purpose of this sysfs attribute is. Please choose a name that is more clear, e.g. "wb_resize_action".

Additionally, please change the word "file" into "attribute" to maintain consistency with the rest of the sysfs documentation.

Please also make sure that the documentation is consistent with the code. The above documentation mentions the value 0 while the code doesn't allow writing the value zero.

Quoted 6 lines
Documentation/ABI/testing/sysfs-driver-ufs +6 -0
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_buf_resize_status
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_buf_resize_status
+Date:		Qct 2024
+Contact:	Huan Tang <[email protected]>
+Description:

Documentation/ABI/testing/sysfs-driver-ufs Description: · line 1611

Quoted 10 lines
Documentation/ABI/testing/sysfs-driver-ufs +10 -0
+		The host can check the Resize operation status of the WriteBooster Buffer
+		by reading this file.
+
+		======  ========================================
+		00h  Idle (resize operation is not issued)
+		01h  Resize operation in progress
+		02h  Resize operation completed successfully
+		03h  Resize operation general failure
+		Others  Reserved
+		======  ========================================

For the three new attributes: please use words in sysfs instead of numbers. Using numbers is not user-friendly.

drivers/ufs/core/ufs-sysfs.c static ssize_t wb_flush_threshold_store(struct device *dev, · line 418

Quoted 5 lines
drivers/ufs/core/ufs-sysfs.c +5 -0
+static ssize_t wb_toggle_buf_resize_store(struct device *dev,
+		struct device_attribute *attr, const char *buf, size_t count)
+{
+	struct ufs_hba *hba = dev_get_drvdata(dev);
+	unsigned int wb_buf_resize_op;

Please introduce an enumeration type instead of using 'unsigned int'. Please also choose a more descriptive variable name than 'op'.

Quoted 4 lines
drivers/ufs/core/ufshcd.c +4 -0
+int ufshcd_wb_toggle_buf_resize(struct ufs_hba *hba, u32 op)
+{
+	int ret;
+	u8 index;

drivers/ufs/core/ufshcd.c static bool ufshcd_wb_need_flush(struct ufs_hba *hba) · line 6183

Quoted 10 lines
drivers/ufs/core/ufshcd.c +10 -0
+
+	index = ufshcd_wb_get_query_index(hba);
+	ret = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,
+				   QUERY_ATTR_IDN_WB_BUF_RESIZE_EN, index, 0, &op);
+	if (ret)
+		dev_err(hba->dev, "%s: Enable WB buf resize operation failed %d\n",
+			__func__, ret);
+
+	return ret;
+}

This function doesn't toggle anything - it sets the value of the bWriteBoosterBufferResizeEn attribute. Please reflect this in the function name, e.g. by renaming this function into ufshcd_wb_set_resize_en(). Additionally, the name of the 'op' argument doesn't reflect the purpose of that argument. How about renaming it into 'enum wb_resize_en' where the wb_resize_en type support the three values idle = 0, decrease = 1 and increase = 2?

Thanks,

Bart.

author
#2 lore raw
Quoted 2 lines

For the three new attributes: please use words in sysfs instead of numbers. Using numbers is not user-friendly.

Hi Bart

Thank you for your reply!
Thanks for your suggestions

I am confused about the above sentence and I don't understand it. Can you give me more detailed guidance?

v4
https://lore.kernel.org/all/[email protected]/

Thanks
Huan

#3 lore raw
Quoted 6 lines · Huan Tang
Quoted 2 lines

For the three new attributes: please use words in sysfs instead of numbers. Using numbers is not user-friendly.

Hi Bart

Quoted 7 lines

Thank you for your reply!
Thanks for your suggestions

I am confused about the above sentence and I don't understand it. Can you give me more detailed guidance?

v4
https://lore.kernel.org/all/[email protected]/

Hi Huan,

Please modify the implementation of sysfs attributes like
wb_toggle_buf_resize such that a string is accepted (e.g. increase, decrease) instead of numbers (1, 2).

See also how sysfs_match_string() is used in e.g. drivers/scsi/sd.c. Several sd sysfs attributes support writing a string into sysfs attributes and that string is translated into a number.

Thanks,

Bart.

author
#4 lore raw
Quoted 6 lines

Hi Huan,

Please modify the implementation of sysfs attributes like wb_toggle_buf_resize such that a string is accepted (e.g. increase, decrease) instead of numbers (1, 2).

Quoted 7 lines

See also how sysfs_match_string() is used in e.g. drivers/scsi/sd.c. Several sd sysfs attributes support writing a string into sysfs attributes and that string is translated into a number.

Thanks,

Bart.

Hi Bart,

Thank you for your reply and guidance.
I got it.

I have submitted the v6 patch according to your suggestions.Could you please review it again?

v6 patch:
https://lore.kernel.org/all/[email protected]/

Thanks
Huan

#5 lore raw
Quoted 2 lines · Huan Tang

I have submitted the v6 patch according to your suggestions.Could you please review it again?

The WB buffer resize functionality will be included in the JEDEC UFS 4.1 standard and that standard has not yet been published. Do the JEDEC rules allow inclusion in the upstream kernel of functionality that has not yet been published?

Thanks,

Bart.

author
#6 lore raw
Quoted 4 lines

The WB buffer resize functionality will be included in the JEDEC UFS 4.1 standard and that standard has not yet been published. Do the JEDEC rules allow inclusion in the upstream kernel of functionality that has not yet been published?

Hi Bart,

Thank you for your reply .
Sorry, my mistake; let's wait for JEDEC to officially release it before continuing the discussion

Thanks
Huan

author
#7 lore raw

PATCH v11 1/1 ufs: core: Add WB buffer resize support

In reply to Bart Van Assche

Follow JESD220G, Support WB buffer resize function through sysfs, the host can obtain resize hint and resize status, and enable the resize operation. To achieve this goals, three sysfs nodes have been added:
1. wb_resize_enable
2. wb_resize_hint
3. wb_resize_status
The detailed definition of the three nodes can be found in the sysfs documentation.

Changelog
===
v10 - > v11:
1.change "fail" to "failure", change "FAIL" to "FAILURE" 2.fix coding style issue in "wb_resize_hint_show" and "wb_resize_status_show"
3.remove ext_wb_sup sysfs node
4.only use one tab in front of "="

v9 - > v10:
fix commit message error:remove "^M"

v8 - > v9:

	1.Add "ext_wb_sup" node
	2.Fix some coding errors,for example: "gerneral" ->"general"
	3.Add a check bit0 of ext_wb_sup
	4.Following Bean's advice: use enum in ufshcd_wb_set_resize_en

v7 - > v8:
1.Optimized the description in the sysfs-driver-ufs file 2.Replace uppercase with lowercase, for example: "KEEP"-> "keep" 3.Fix coding style issues with switch/case statements

v6 - > v7:
1.Use "xxxx_to_string" for string convert
2.Use uppercase characters, for example: "keep" -> "KEEP" 3.Resize enable mode support "IDLE"

v5 - > v6:
1.Fix mistake: obtain the return value of "sysfs_emit"

v4 - > v5:
1.For the three new attributes: use words in sysfs instead of numbers

v3 - > v4:
1.modify three attributes name and description in document 2.add enum wb_resize_en in ufs.h
3.modify function name and parameters in ufs-sysfs.c, ufshcd.h, ufshcd.c

v2 - > v3:
Remove needless code:
drivers/ufs/core/ufs-sysfs.c:441:2:
index = ufshcd_wb_get_query_index(hba)

v1 - > v2:
Remove unused variable "u8 index", drivers/ufs/core/ufs-sysfs.c:419:12: warning: variable 'index' set but not used.

v1

	https://lore.kernel.org/all/[email protected]/
v2
	https://lore.kernel.org/all/[email protected]/
v3
	https://lore.kernel.org/all/[email protected]/
v4
	https://lore.kernel.org/all/[email protected]/
v5
	https://lore.kernel.org/all/[email protected]/
v6
	https://lore.kernel.org/all/[email protected]/
v7
	https://lore.kernel.org/all/[email protected]/
v8
	https://lore.kernel.org/all/[email protected]/
v9
	https://lore.kernel.org/all/[email protected]/
v10
	https://lore.kernel.org/all/[email protected]/
---
 Documentation/ABI/testing/sysfs-driver-ufs |  49 ++++++++
 drivers/ufs/core/ufs-sysfs.c               | 133 +++++++++++++++++++++
 drivers/ufs/core/ufshcd.c                  |  18 +++
 include/ufs/ufs.h                          |  34 +++++-
 include/ufs/ufshcd.h                       |   1 +
 5 files changed, 234 insertions(+), 1 deletion(-)
Documentation/ABI/testing/sysfs-driver-ufs +49 -0
index ae0191295d29..e7b49bc894f5 100644
@@ -1604,3 +1604,52 @@ Description:
 		prevent the UFS from frequently performing clock gating/ungating.
 
 		The attribute is read/write.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/wb_resize_enable
+What:		/sys/bus/platform/devices/*.ufs/wb_resize_enable
+Date:		April 2025
+Contact:	Huan Tang <[email protected]>
+Description:
+		The host can enable the WriteBooster buffer resize by setting this
+		attribute.
+
+		========  ======================================
+		idle      There is no resize operation
+		decrease  Decrease WriteBooster buffer size
+		increase  Increase WriteBooster buffer size
+		========  ======================================
+
+		The file is write only.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_resize_hint
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_resize_hint
+Date:		April 2025
+Contact:	Huan Tang <[email protected]>
+Description:
+		wb_resize_hint indicates hint information about which type of resize
+		for WriteBooster buffer is recommended by the device.
+
+		=========  ======================================
+		keep       Recommend keep the buffer size
+		decrease   Recommend to decrease the buffer size
+		increase   Recommend to increase the buffer size
+		=========  ======================================
+
+		The file is read only.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_resize_status
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_resize_status
+Date:		April 2025
+Contact:	Huan Tang <[email protected]>
+Description:
+		The host can check the resize operation status of the WriteBooster
+		buffer by reading this attribute.
+
+		================  ========================================
+		idle              Resize operation is not issued
+		in_progress       Resize operation in progress
+		complete_success  Resize operation completed successfully
+		general_failure   Resize operation general failure
+		================  ========================================
+
+		The file is read only.
drivers/ufs/core/ufs-sysfs.c +133 -0

169 lines not on this page · raw message

drivers/ufs/core/ufshcd.c +18 -0
index 83b092cbb864..a73838062ddf 100644
@@ -6068,6 +6068,21 @@ int ufshcd_wb_toggle_buf_flush(struct ufs_hba *hba, bool enable)
 	return ret;
 }
 
+int ufshcd_wb_set_resize_en(struct ufs_hba *hba, enum wb_resize_en en_mode)
+{
+	int ret;
+	u8 index;
+
+	index = ufshcd_wb_get_query_index(hba);
+	ret = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,
+				QUERY_ATTR_IDN_WB_BUF_RESIZE_EN, index, 0, &en_mode);
+	if (ret)
+		dev_err(hba->dev, "%s: Enable WB buf resize operation failed %d\n",
+			__func__, ret);
+
+	return ret;
+}
+
 static bool ufshcd_wb_presrv_usrspc_keep_vcc_on(struct ufs_hba *hba,
 						u32 avail_buf)
 {
@@ -8067,6 +8082,9 @@ static void ufshcd_wb_probe(struct ufs_hba *hba, const u8 *desc_buf)
 	 */
 	dev_info->wb_buffer_type = desc_buf[DEVICE_DESC_PARAM_WB_TYPE];
 
+	dev_info->ext_wb_sup =  get_unaligned_be16(desc_buf +
+						DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP);
+
 	dev_info->b_presrv_uspc_en =
 		desc_buf[DEVICE_DESC_PARAM_WB_PRESRV_USRSPC_EN];
 
include/ufs/ufs.h +33 -1
index 8a24ed59ec46..3f2b1772f9fd 100644
@@ -180,7 +180,10 @@ enum attr_idn {
 	QUERY_ATTR_IDN_AVAIL_WB_BUFF_SIZE       = 0x1D,
 	QUERY_ATTR_IDN_WB_BUFF_LIFE_TIME_EST    = 0x1E,
 	QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE        = 0x1F,
-	QUERY_ATTR_IDN_TIMESTAMP		= 0x30
+	QUERY_ATTR_IDN_TIMESTAMP		= 0x30,
+	QUERY_ATTR_IDN_WB_BUF_RESIZE_HINT	= 0x3C,
+	QUERY_ATTR_IDN_WB_BUF_RESIZE_EN		= 0x3D,
+	QUERY_ATTR_IDN_WB_BUF_RESIZE_STATUS	= 0x3E,
 };
 
 /* Descriptor idn for Query requests */
@@ -289,6 +292,7 @@ enum device_desc_param {
 	DEVICE_DESC_PARAM_PRDCT_REV		= 0x2A,
 	DEVICE_DESC_PARAM_HPB_VER		= 0x40,
 	DEVICE_DESC_PARAM_HPB_CONTROL		= 0x42,
+	DEVICE_DESC_PARAM_EXT_WB_SUP		= 0x4D,
 	DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP	= 0x4F,
 	DEVICE_DESC_PARAM_WB_PRESRV_USRSPC_EN	= 0x53,
 	DEVICE_DESC_PARAM_WB_TYPE		= 0x54,
@@ -383,6 +387,11 @@ enum {
 	UFSHCD_AMP		= 3,
 };
 
+/* Possible values for wExtendedWriteBoosterSupport */
+enum {
+	UFS_DEV_WB_BUF_RESIZE	= BIT(0),
+};
+
 /* Possible values for dExtendedUFSFeaturesSupport */
 enum {
 	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(4),
@@ -454,6 +463,28 @@ enum ufs_ref_clk_freq {
 	REF_CLK_FREQ_INVAL	= -1,
 };
 
+/* bWriteBoosterBufferResizeEn attribute */
+enum wb_resize_en {
+	WB_RESIZE_EN_IDLE	= 0,
+	WB_RESIZE_EN_DECREASE	= 1,
+	WB_RESIZE_EN_INCREASE	= 2,
+};
+
+/* bWriteBoosterBufferResizeHint attribute */
+enum wb_resize_hint {
+	WB_RESIZE_HINT_KEEP	= 0,
+	WB_RESIZE_HINT_DECREASE	= 1,
+	WB_RESIZE_HINT_INCREASE	= 2,
+};
+
+/* bWriteBoosterBufferResizeStatus attribute */
+enum wb_resize_status {
+	WB_RESIZE_STATUS_IDLE	= 0,
+	WB_RESIZE_STATUS_IN_PROGRESS	= 1,
+	WB_RESIZE_STATUS_COMPLETE_SUCCESS	= 2,
+	WB_RESIZE_STATUS_GENERAL_FAILURE	= 3,
+};
+
 /* Query response result code */
 enum {
 	QUERY_RESULT_SUCCESS                    = 0x00,
@@ -578,6 +609,7 @@ struct ufs_dev_info {
 	bool    wb_buf_flush_enabled;
 	u8	wb_dedicated_lu;
 	u8      wb_buffer_type;
+	u16	ext_wb_sup;
 
 	bool	b_rpm_dev_flush_capable;
 	u8	b_presrv_uspc_en;
include/ufs/ufshcd.h +1 -0
index f56050ce9445..722307182630 100644
@@ -1471,6 +1471,7 @@ int ufshcd_advanced_rpmb_req_handler(struct ufs_hba *hba, struct utp_upiu_req *r
 				     struct scatterlist *sg_list, enum dma_data_direction dir);
 int ufshcd_wb_toggle(struct ufs_hba *hba, bool enable);
 int ufshcd_wb_toggle_buf_flush(struct ufs_hba *hba, bool enable);
+int ufshcd_wb_set_resize_en(struct ufs_hba *hba, enum wb_resize_en en_mode);
 int ufshcd_suspend_prepare(struct device *dev);
 int __ufshcd_suspend_prepare(struct device *dev, bool rpm_ok_for_spm);
 void ufshcd_resume_complete(struct device *dev);
Signature · 1 line
2.39.0
reviewer Reviewed-by on v11 1/1
#8 lore raw
Quoted 9 lines · Huan Tang

Follow JESD220G, Support WB buffer resize function through sysfs, the host can obtain resize hint and resize status, and enable the resize operation. To achieve this goals, three sysfs nodes have been added:
1. wb_resize_enable
2. wb_resize_hint
3. wb_resize_status
The detailed definition of the three nodes can be found in the sysfs documentation.

Please do not use the git send-email --in-reply-to option when posting a new version of a patch or a new version of a patch series - this may cause patches to be overlooked. Since this patch looks fine to me:

#9 lore raw
In reply to Huan Tang

Huan,

Quoted 3 lines

Follow JESD220G, Support WB buffer resize function through sysfs, the host can obtain resize hint and resize status, and enable the resize operation. To achieve this goals, three sysfs nodes have been added:

Applied to 6.16/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen
#10 lore raw
In reply to Huan Tang
Quoted 9 lines · Huan Tang
(quoted diff) +0 -0
@@ -8067,6 +8082,9 @@ static void ufshcd_wb_probe(struct ufs_hba
 *hba, const u8 *desc_buf)
  	 */

  dev_info->wb_buffer_type =
desc_buf[DEVICE_DESC_PARAM_WB_TYPE];

(quoted diff) +2 -0
+	dev_info->ext_wb_sup =  get_unaligned_be16(desc_buf +
+						DEVICE_DESC_PARAM_EX
Quoted 3 lines

T_UFS_FEATURE_SUP);
+

Hi Huan,

DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP seems to be incorrect. It should be DEVICE_DESC_PARAM_EXT_WB_SUP

Thanks.
Peter

Quoted 92 lines

  dev_info->b_presrv_uspc_en = desc_buf[DEVICE_DESC_PARAM_WB_PRESRV_USRSPC_EN];

include/ufs/ufs.h +4 -1
index 8a24ed59ec46..3f2b1772f9fd 100644
@@ -180,7 +180,10 @@ enum attr_idn {
  	QUERY_ATTR_IDN_AVAIL_WB_BUFF_SIZE       = 0x1D,
  	QUERY_ATTR_IDN_WB_BUFF_LIFE_TIME_EST    = 0x1E,
  	QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE        = 0x1F,
-	QUERY_ATTR_IDN_TIMESTAMP		= 0x30
+	QUERY_ATTR_IDN_TIMESTAMP		= 0x30,
+	QUERY_ATTR_IDN_WB_BUF_RESIZE_HINT	= 0x3C,
+	QUERY_ATTR_IDN_WB_BUF_RESIZE_EN		= 0x3D,
+	QUERY_ATTR_IDN_WB_BUF_RESIZE_STATUS	= 0x3E,
  };


 /* Descriptor idn for Query requests */

include/ufs/ufs.h +1 -0
@@ -289,6 +292,7 @@ enum device_desc_param {
  	DEVICE_DESC_PARAM_PRDCT_REV		= 0x2A,
  	DEVICE_DESC_PARAM_HPB_VER		= 0x40,
  	DEVICE_DESC_PARAM_HPB_CONTROL		= 0x42,
+	DEVICE_DESC_PARAM_EXT_WB_SUP		= 0x4D,
  	DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP	= 0x4F,
  	DEVICE_DESC_PARAM_WB_PRESRV_USRSPC_EN	= 0x53,
  	DEVICE_DESC_PARAM_WB_TYPE		= 0x54,
@@ -383,6 +387,11 @@ enum {
  	UFSHCD_AMP		= 3,
  };

include/ufs/ufs.h +5 -0
+/* Possible values for wExtendedWriteBoosterSupport */
+enum {
+	UFS_DEV_WB_BUF_RESIZE	= BIT(0),
+};
+

 /* Possible values for dExtendedUFSFeaturesSupport */ enum {
  UFS_DEV_HIGH_TEMP_NOTIF = BIT(4),

include/ufs/ufs.h +0 -0
@@ -454,6 +463,28 @@ enum ufs_ref_clk_freq {
  	REF_CLK_FREQ_INVAL	= -1,
  };

include/ufs/ufs.h +22 -0
+/* bWriteBoosterBufferResizeEn attribute */
+enum wb_resize_en {
+	WB_RESIZE_EN_IDLE	= 0,
+	WB_RESIZE_EN_DECREASE	= 1,
+	WB_RESIZE_EN_INCREASE	= 2,
+};
+
+/* bWriteBoosterBufferResizeHint attribute */
+enum wb_resize_hint {
+	WB_RESIZE_HINT_KEEP	= 0,
+	WB_RESIZE_HINT_DECREASE	= 1,
+	WB_RESIZE_HINT_INCREASE	= 2,
+};
+
+/* bWriteBoosterBufferResizeStatus attribute */
+enum wb_resize_status {
+	WB_RESIZE_STATUS_IDLE	= 0,
+	WB_RESIZE_STATUS_IN_PROGRESS	= 1,
+	WB_RESIZE_STATUS_COMPLETE_SUCCESS	= 2,
+	WB_RESIZE_STATUS_GENERAL_FAILURE	= 3,
+};
+

 /* Query response result code */
 enum {
  QUERY_RESULT_SUCCESS                    = 0x00,

include/ufs/ufs.h +1 -0
@@ -578,6 +609,7 @@ struct ufs_dev_info {
  	bool    wb_buf_flush_enabled;
  	u8	wb_dedicated_lu;
  	u8      wb_buffer_type;
+	u16	ext_wb_sup;


  bool b_rpm_dev_flush_capable;
  u8 b_presrv_uspc_en;

include/ufs/ufshcd.h +0 -0
index f56050ce9445..722307182630 100644
@@ -1471,6 +1471,7 @@ int ufshcd_advanced_rpmb_req_handler(struct

ufs_hba *hba, struct utp_upiu_req *r
       struct scatterlist *sg_list, enum dma_data_direction dir);
 int ufshcd_wb_toggle(struct ufs_hba *hba, bool enable); int ufshcd_wb_toggle_buf_flush(struct ufs_hba *hba, bool enable); +int ufshcd_wb_set_resize_en(struct ufs_hba *hba, enum wb_resize_en en_mode);
 int ufshcd_suspend_prepare(struct device *dev);
 int __ufshcd_suspend_prepare(struct device *dev, bool rpm_ok_for_spm);
 void ufshcd_resume_complete(struct device *dev);

author
#11 lore raw
Quoted 2 lines

DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP seems to be incorrect. It should be DEVICE_DESC_PARAM_EXT_WB_SUP

Hi peter sir,

Thanks for your reply and advice!
I'll fix it right away

Best wishes to you !

Thanks
Huan