drm/i915/dp: force eDP lane count to max available lanes on BDW
Subsystems (2)
PATCH 1/1 drm/i915/dp: force eDP lane count to max available lanes on BDW
There are certain BDW high res eDP machines that regressed due to
commit 38aecea0ccbb909d635619cba22f1891e589b434
Author: Daniel Vetter <[email protected]> Date: Mon Mar 3 11:18:10 2014 +0100
drm/i915: reverse dp link param selection, prefer fast over wide again
The commit lead to 2 lanes at 5.4 Gbps being used instead of 4 lanes at 2.7 Gbps on the affected machines. Link training succeeded for both, but the screen remained blank with the former config. Further investigation showed that 4 lanes at 5.4 Gbps worked also.
The root cause for the blank screen using 2 lanes remains unknown, but apparently the driver for a certain other operating system by default uses the max available lanes. Follow suit on Broadwell eDP, for at least until we figure out what is going on.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76711
--- drivers/gpu/drm/i915/intel_dp.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dp.c +6 -1
@@ -849,7 +849,12 @@ intel_dp_compute_config(struct intel_encoder *encoder, bpp = dev_priv->vbt.edp_bpp; } -if (dev_priv->vbt.edp_lanes) { +if (IS_BROADWELL (dev)) { +/* Yes, it's an ugly hack. */ + min_lane_count = max_lane_count; +DRM_DEBUG_KMS ("forcing lane count to max (%u) on BDW\n" , + min_lane_count); + }else if (dev_priv->vbt.edp_lanes) { min_lane_count =min (dev_priv->vbt.edp_lanes, max_lane_count); DRM_DEBUG_KMS("using min %u lanes per VBT\n",
Signature · 1 line
1.9.1
We do have to continue the investigation on the link training side, but since 76711 is a critical I'm completely in favor of this workaround for now.
I just tested and it worked very well here, so:
Quoted 53 lines · Jani Nikula
There are certain BDW high res eDP machines that regressed due to
commit
38aecea0ccbb909d635619cba22f1891e589b434Author: Daniel Vetter <[email protected]> Date: Mon Mar 3 11:18:10 2014 +0100drm/i915: reverse dp link param selection, prefer fast over wide again
The commit lead to 2 lanes at 5.4 Gbps being used instead of 4 lanes at 2.7 Gbps on the affected machines. Link training succeeded for both, but the screen remained blank with the former config. Further investigation showed that 4 lanes at 5.4 Gbps worked also.
The root cause for the blank screen using 2 lanes remains unknown, but apparently the driver for a certain other operating system by default uses the max available lanes. Follow suit on Broadwell eDP, for at least until we figure out what is going on.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76711
Reviewed-by Daniel Vetter <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dp.c +6
-1@@ -849,7 +849,12 @@ intel_dp_compute_config(struct intel_encoder *encoder, bpp = dev_priv->vbt.edp_bpp; } -if (dev_priv->vbt.edp_lanes) { +if (IS_BROADWELL (dev)) { +/* Yes, it's an ugly hack. */ + min_lane_count = max_lane_count; +DRM_DEBUG_KMS ("forcing lane count to max (%u) on BDW\n", + min_lane_count); + }else if (dev_priv->vbt.edp_lanes) { min_lane_count =min (dev_priv->vbt.edp_lanes, max_lane_count);DRM_DEBUG_KMS("using min %u lanes per VBT\n",
--
1.9.1_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 2 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Rodrigo Vivi
We do have to continue the investigation on the link training side, but since 76711 is a critical I'm completely in favor of this workaround for now.
I just tested and it worked very well here, so:
Tested-by Rodrigo Vivi <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]>
Pushed to -fixes, thanks for the review and testing.
BR,
Jani.
Quoted 63 lines · Jani Nikula
Quoted 54 lines
There are certain BDW high res eDP machines that regressed due to
commit
38aecea0ccbb909d635619cba22f1891e589b434Author: Daniel Vetter <[email protected]> Date: Mon Mar 3 11:18:10 2014 +0100drm/i915: reverse dp link param selection, prefer fast over wide again
The commit lead to 2 lanes at 5.4 Gbps being used instead of 4 lanes at 2.7 Gbps on the affected machines. Link training succeeded for both, but the screen remained blank with the former config. Further investigation showed that 4 lanes at 5.4 Gbps worked also.
The root cause for the blank screen using 2 lanes remains unknown, but apparently the driver for a certain other operating system by default uses the max available lanes. Follow suit on Broadwell eDP, for at least until we figure out what is going on.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76711
Reviewed-by Daniel Vetter <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dp.c +6
-1@@ -849,7 +849,12 @@ intel_dp_compute_config(struct intel_encoder *encoder, bpp = dev_priv->vbt.edp_bpp; } -if (dev_priv->vbt.edp_lanes) { +if (IS_BROADWELL (dev)) { +/* Yes, it's an ugly hack. */ + min_lane_count = max_lane_count; +DRM_DEBUG_KMS ("forcing lane count to max (%u) on BDW\n", + min_lane_count); + }else if (dev_priv->vbt.edp_lanes) { min_lane_count =min (dev_priv->vbt.edp_lanes, max_lane_count);DRM_DEBUG_KMS("using min %u lanes per VBT\n",
--
1.9.1_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 2 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Dave Airlie
maintainerQuoted 7 lines · Jani Nikula
Quoted 6 lines · Rodrigo Vivi
We do have to continue the investigation on the link training side, but since 76711 is a critical I'm completely in favor of this workaround for now.
I just tested and it worked very well here, so:
Quoted 29 lines
Quoted 2 lines
Tested-by Rodrigo Vivi <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]>Pushed to -fixes, thanks for the review and testing.
BR,
Jani.Quoted 21 lines · Jani Nikula
Quoted 18 lines
There are certain BDW high res eDP machines that regressed due to
commit
38aecea0ccbb909d635619cba22f1891e589b434Author: Daniel Vetter <[email protected]> Date: Mon Mar 3 11:18:10 2014 +0100drm/i915: reverse dp link param selection, prefer fast over wide again
The commit lead to 2 lanes at 5.4 Gbps being used instead of 4 lanes at 2.7 Gbps on the affected machines. Link training succeeded for both, but the screen remained blank with the former config. Further investigation showed that 4 lanes at 5.4 Gbps worked also.
The root cause for the blank screen using 2 lanes remains unknown, but apparently the driver for a certain other operating system by default uses the max available lanes. Follow suit on Broadwell eDP, for at least until we figure out what is going on.
Uggh, okay this lane thing is such a pita,
On haswell the Lenovo dock in SST mode is broken by the original patch as well.
I'm not sure we want to do IS_HASWELL here as well,
I think we need to revert 38aecea0ccbb909d635619cba22f1891e589b434
Dave.
Dave Airlie
maintainerQuoted 38 lines · Dave Airlie
Quoted 7 lines · Jani Nikula
Quoted 6 lines · Rodrigo Vivi
We do have to continue the investigation on the link training side, but since 76711 is a critical I'm completely in favor of this workaround for now.
I just tested and it worked very well here, so:
Quoted 29 lines
Quoted 2 lines
Tested-by Rodrigo Vivi <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]>Pushed to -fixes, thanks for the review and testing.
BR,
Jani.Quoted 21 lines · Jani Nikula
Quoted 18 lines
There are certain BDW high res eDP machines that regressed due to
commit
38aecea0ccbb909d635619cba22f1891e589b434Author: Daniel Vetter <[email protected]> Date: Mon Mar 3 11:18:10 2014 +0100drm/i915: reverse dp link param selection, prefer fast over wide again
The commit lead to 2 lanes at 5.4 Gbps being used instead of 4 lanes at 2.7 Gbps on the affected machines. Link training succeeded for both, but the screen remained blank with the former config. Further investigation showed that 4 lanes at 5.4 Gbps worked also.
The root cause for the blank screen using 2 lanes remains unknown, but apparently the driver for a certain other operating system by default uses the max available lanes. Follow suit on Broadwell eDP, for at least until we figure out what is going on.
Quoted 7 lines
Uggh, okay this lane thing is such a pita,
On haswell the Lenovo dock in SST mode is broken by the original patch as well.
I'm not sure we want to do
IS_HASWELLhere as well,I think we need to revert
38aecea0ccbb909d635619cba22f1891e589b434
Actually adding IS_HASWELL won't work since this problem is with a standard DP port.
I'll send the reverts, though I've no idea if this another revert of a revert etc.
Dave.